diff mbox

[3/3] UBI: Fix debug message

Message ID 1435912576-27878-3-git-send-email-richard@nod.at
State Accepted
Headers show

Commit Message

Richard Weinberger July 3, 2015, 8:36 a.m. UTC 
We have to use j instead of i. i is the volume id
and not the block.

Reported-by: Alexander.Block@continental-corporation.com
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/mtd/ubi/eba.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Norris Sept. 29, 2015, 1:35 a.m. UTC | #1 
Digging through some old stuff:

On Fri, Jul 03, 2015 at 10:36:16AM +0200, Richard Weinberger wrote:
> We have to use j instead of i. i is the volume id
> and not the block.
> 
> Reported-by: Alexander.Block@continental-corporation.com
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Brian Norris <computersforpeace@gmail.com>

> ---
>  drivers/mtd/ubi/eba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
> index b55dc8e..98595c5 100644
> --- a/drivers/mtd/ubi/eba.c
> +++ b/drivers/mtd/ubi/eba.c
> @@ -1409,7 +1409,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap,
>  					continue;
>  
>  				ubi_err(ubi, "LEB:%i:%i is PEB:%i instead of %i!",
> -					vol->vol_id, i, fm_eba[i][j],
> +					vol->vol_id, j, fm_eba[i][j],
>  					scan_eba[i][j]);
>  				ubi_assert(0);
>  			}
> -- 
> 1.8.4.5
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Richard Weinberger Oct. 3, 2015, 6:10 p.m. UTC | #2 
On Tue, Sep 29, 2015 at 3:35 AM, Brian Norris
<computersforpeace@gmail.com> wrote:
> Digging through some old stuff:
>
> On Fri, Jul 03, 2015 at 10:36:16AM +0200, Richard Weinberger wrote:
>> We have to use j instead of i. i is the volume id
>> and not the block.
>>
>> Reported-by: Alexander.Block@continental-corporation.com
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>

Applied.
diff mbox

Patch

diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
index b55dc8e..98595c5 100644
--- a/drivers/mtd/ubi/eba.c
+++ b/drivers/mtd/ubi/eba.c
@@ -1409,7 +1409,7 @@  int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap,
 					continue;
 
 				ubi_err(ubi, "LEB:%i:%i is PEB:%i instead of %i!",
-					vol->vol_id, i, fm_eba[i][j],
+					vol->vol_id, j, fm_eba[i][j],
 					scan_eba[i][j]);
 				ubi_assert(0);
 			}