Message ID | 1401264104.983.12.camel@sauron.fi.intel.com |
---|---|
State | Superseded |
Headers | show |
On Wed, 2014-05-28 at 11:01 +0300, Artem Bityutskiy wrote: > + /* > + * Good commend describing what we are doing. > + */ > + c->probing = 1 Err, actually: c->probing = silent; > err = ubifs_read_superblock(c); > + c->probing = 0 > if (err) > goto out_free;
On Wed, 2014-05-28 at 08:07 +0000, Bityutskiy, Artem wrote: > On Wed, 2014-05-28 at 11:01 +0300, Artem Bityutskiy wrote: > > + /* > > + * Good commend describing what we are doing. > > + */ > > + c->probing = 1 > > Err, actually: > > c->probing = silent; > > > err = ubifs_read_superblock(c); > > + c->probing = 0 > > if (err) > > goto out_free; I guess you guys got the idea, but just in case, you also will need to add "if (!c->probing) { ubifs_error() }" in the relevant places.
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index a81c7b5..a627476 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -1210,7 +1210,12 @@ static int mount_ubifs(struct ubifs_info *c) c->mounting = 1; + /* + * Good commend describing what we are doing. + */ + c->probing = 1 err = ubifs_read_superblock(c); + c->probing = 0 if (err) goto out_free;