From patchwork Sat Jul 27 02:14:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 262369 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 741D12C0104 for ; Sat, 27 Jul 2013 12:16:05 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2u2f-0003Bp-QL; Sat, 27 Jul 2013 02:15:34 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2u2d-0008Ic-O3; Sat, 27 Jul 2013 02:15:31 +0000 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2u2W-0008FV-0v for linux-mtd@lists.infradead.org; Sat, 27 Jul 2013 02:15:24 +0000 Received: by mail-pd0-f174.google.com with SMTP id 3so2482760pdj.33 for ; Fri, 26 Jul 2013 19:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=QtCdogW6Ka9Le5Q9TdxVNTY4djX5eazz1J2yjFveyyg=; b=F/iUJQjwNUPWkqg7ZyNu6v4yi2iD/mtn0A9ZGgasfreoHk2L/cKFQekWqVr3Z+ksaj SFbDFX4/Dfn5BhVYMMlHtq6/ETyHN2y1anu4FkeM0rJRS/EjnYeCRb5c20BbfiifoGX5 9uqEqo2UXxbWBiH8agkHL9OlfQrRwOYp1EFpclS2cV7sclH8Ot2xNy9txAwNYI8facEB yyUiOgXG9AscVBYySETjQxZQAig62e/SpL1spc1GUYpk5Y3sIlxcERq4RcG+bC52F6+i 0w0VeLhrOWJAmZwlbqenGd5DMfIWj4JNYIlpOTdFpCqj4Pxa6iwPA78uZOkr9/Y85N23 ll3g== X-Received: by 10.66.148.41 with SMTP id tp9mr58467892pab.40.1374891301785; Fri, 26 Jul 2013 19:15:01 -0700 (PDT) Received: from localhost.localdomain (KD113145060135.ppp-bb.dion.ne.jp. [113.145.60.135]) by mx.google.com with ESMTPSA id bg3sm62887200pbb.44.2013.07.26.19.15.00 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 26 Jul 2013 19:15:01 -0700 (PDT) From: Akinobu Mita To: linux-mtd@lists.infradead.org Subject: [PATCH -next 1/7] mtd: tests: introduce mtd_test module Date: Sat, 27 Jul 2013 11:14:10 +0900 Message-Id: <1374891256-20248-2-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1374891256-20248-1-git-send-email-akinobu.mita@gmail.com> References: <1374891256-20248-1-git-send-email-akinobu.mita@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130726_221524_162192_8D8EF846 X-CRM114-Status: GOOD ( 17.74 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (akinobu.mita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Artem Bityutskiy , David Woodhouse , Akinobu Mita , Adrian Hunter X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This introduces mtd_test module which contains the following functions used by several mtd/tests modules. - mtdtest_erase_eraseblock() - mtdtest_scan_for_bad_eraseblocks() - mtdtest_erase_whole_device() This mtd_test module also provides the following wrapper functions for mtd_read() and mtd_write() in order to simplify the return value check in mtd/tests modules. - mtdtest_read() - mtdtest_write() These functions will be used for reducing code duplication among mtd/tests modules later. Signed-off-by: Akinobu Mita Cc: Adrian Hunter Cc: Artem Bityutskiy Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org --- drivers/mtd/tests/Makefile | 1 + drivers/mtd/tests/mtd_test.c | 117 +++++++++++++++++++++++++++++++++++++++++++ drivers/mtd/tests/mtd_test.h | 11 ++++ 3 files changed, 129 insertions(+) create mode 100644 drivers/mtd/tests/mtd_test.c create mode 100644 drivers/mtd/tests/mtd_test.h diff --git a/drivers/mtd/tests/Makefile b/drivers/mtd/tests/Makefile index bd0065c..3d642f4 100644 --- a/drivers/mtd/tests/Makefile +++ b/drivers/mtd/tests/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_MTD_TESTS) += mtd_test.o obj-$(CONFIG_MTD_TESTS) += mtd_oobtest.o obj-$(CONFIG_MTD_TESTS) += mtd_pagetest.o obj-$(CONFIG_MTD_TESTS) += mtd_readtest.o diff --git a/drivers/mtd/tests/mtd_test.c b/drivers/mtd/tests/mtd_test.c new file mode 100644 index 0000000..1fa1d63 --- /dev/null +++ b/drivers/mtd/tests/mtd_test.c @@ -0,0 +1,117 @@ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include + +#include "mtd_test.h" + +int mtdtest_erase_eraseblock(struct mtd_info *mtd, int ebnum) +{ + int err; + struct erase_info ei; + loff_t addr = ebnum * mtd->erasesize; + + memset(&ei, 0, sizeof(struct erase_info)); + ei.mtd = mtd; + ei.addr = addr; + ei.len = mtd->erasesize; + + err = mtd_erase(mtd, &ei); + if (err) { + pr_info("error %d while erasing EB %d\n", err, ebnum); + return err; + } + + if (ei.state == MTD_ERASE_FAILED) { + pr_info("some erase error occurred at EB %d\n", ebnum); + return -EIO; + } + return 0; +} +EXPORT_SYMBOL_GPL(mtdtest_erase_eraseblock); + +static int is_block_bad(struct mtd_info *mtd, int ebnum) +{ + int ret; + loff_t addr = ebnum * mtd->erasesize; + + ret = mtd_block_isbad(mtd, addr); + if (ret) + pr_info("block %d is bad\n", ebnum); + + return ret; +} + +int mtdtest_scan_for_bad_eraseblocks(struct mtd_info *mtd, unsigned char *bbt, + int ebcnt) +{ + int i, bad = 0; + + if (!mtd_can_have_bb(mtd)) + return 0; + + pr_info("scanning for bad eraseblocks\n"); + for (i = 0; i < ebcnt; ++i) { + bbt[i] = is_block_bad(mtd, i) ? 1 : 0; + if (bbt[i]) + bad += 1; + cond_resched(); + } + pr_info("scanned %d eraseblocks, %d are bad\n", i, bad); + + return 0; +} +EXPORT_SYMBOL_GPL(mtdtest_scan_for_bad_eraseblocks); + +int mtdtest_erase_whole_device(struct mtd_info *mtd, unsigned char *bbt, + int ebcnt) +{ + int err; + unsigned int i; + + for (i = 0; i < ebcnt; ++i) { + if (bbt[i]) + continue; + err = mtdtest_erase_eraseblock(mtd, i); + if (err) + return err; + cond_resched(); + } + + return 0; +} +EXPORT_SYMBOL_GPL(mtdtest_erase_whole_device); + +int mtdtest_read(struct mtd_info *mtd, loff_t addr, size_t size, void *buf) +{ + size_t read; + int err; + + err = mtd_read(mtd, addr, size, &read, buf); + /* Ignore corrected ECC errors */ + if (mtd_is_bitflip(err)) + err = 0; + if (!err && read != size) + err = -EINVAL; + + return err; +} +EXPORT_SYMBOL_GPL(mtdtest_read); + +int mtdtest_write(struct mtd_info *mtd, loff_t addr, size_t size, + const void *buf) +{ + size_t written; + int err; + + err = mtd_write(mtd, addr, size, &written, buf); + if (!err && written != size) + err = -EIO; + + return err; +} +EXPORT_SYMBOL_GPL(mtdtest_write); + +MODULE_LICENSE("GPL"); diff --git a/drivers/mtd/tests/mtd_test.h b/drivers/mtd/tests/mtd_test.h new file mode 100644 index 0000000..e61fb67 --- /dev/null +++ b/drivers/mtd/tests/mtd_test.h @@ -0,0 +1,11 @@ +#include + +int mtdtest_erase_eraseblock(struct mtd_info *mtd, int ebnum); +int mtdtest_scan_for_bad_eraseblocks(struct mtd_info *mtd, unsigned char *bbt, + int ebcnt); +int mtdtest_erase_whole_device(struct mtd_info *mtd, unsigned char *bbt, + int ebcnt); + +int mtdtest_read(struct mtd_info *mtd, loff_t addr, size_t size, void *buf); +int mtdtest_write(struct mtd_info *mtd, loff_t addr, size_t size, + const void *buf);