From patchwork Mon Jan 28 10:25:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 216154 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A25D52C008E for ; Mon, 28 Jan 2013 21:27:15 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tzluv-0006r6-EH; Mon, 28 Jan 2013 10:26:21 +0000 Received: from we-in-x022c.1e100.net ([2a00:1450:400c:c03::22c] helo=mail-we0-x22c.google.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tzlur-0006nK-A8 for linux-mtd@lists.infradead.org; Mon, 28 Jan 2013 10:26:18 +0000 Received: by mail-we0-f172.google.com with SMTP id x10so1412117wey.3 for ; Mon, 28 Jan 2013 02:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=61PxEUfF6RN0Jb3RFZM/p6fWaLd58zNPQCGBOymjHr8=; b=V2aOnKW4lCuB+R8baM94nTw5DxU8SM3YxGbN05+0uDHo2AF+qvQ/JxDuwUvSDu2BAX qHEC7m/WEa7SIZVedUk3IHFdck0Q+4TwmH95jlyB9mNJIAPf25q2IYFGW3ZgwhYW7bEp mt5GzzkfvNMDfH7URcaTQOvS65W8fYkRD8xhm23s4ew8q9vmrBowrbdgQvpy/JFbLFi1 tIkUBq8IrVlr+43LzBQsCZmEx0qE3iCqgKdI2HkbYNPdY6U2IicT5NOYIvCX3xuba8cf q0+Uj4EIQPCoPGHE0DM3pk+YKfbKgbnrqGNPF1GJ53F+r7XfF5ieEc7JchEeCYnY3a/Y 8f+w== X-Received: by 10.180.109.10 with SMTP id ho10mr8816018wib.9.1359368774638; Mon, 28 Jan 2013 02:26:14 -0800 (PST) Received: from mailgate1.roche.com (gw.bas.roche.com. [196.3.50.254]) by mx.google.com with ESMTPS id do1sm12682662wib.7.2013.01.28.02.26.13 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Jan 2013 02:26:14 -0800 (PST) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: linux-mtd@lists.infradead.org, Artem Bityutskiy , David Woodhouse Subject: [PATCH V2 4/6] mtd: bcm47xxnflash: register this as normal driver Date: Mon, 28 Jan 2013 11:25:48 +0100 Message-Id: <1359368750-19763-4-git-send-email-zajec5@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1359368750-19763-3-git-send-email-zajec5@gmail.com> References: <1359368750-19763-3-git-send-email-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130128_052617_489604_C57C0088 X-CRM114-Status: GOOD ( 14.34 ) X-Spam-Score: -1.8 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Hauke Mehrtens X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Hauke Mehrtens When platform_driver_probe() is used and no device is registered for this driver -ENODEV is returned and and error message is shown. Not all BCM47xx SoC have a nand flash chip controller and chip and for them an error message was shown. Signed-off-by: Hauke Mehrtens --- V2: rebase after change in V2 of 3/6 --- drivers/mtd/nand/bcm47xxnflash/main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/bcm47xxnflash/main.c b/drivers/mtd/nand/bcm47xxnflash/main.c index 3e20762..a52acdc 100644 --- a/drivers/mtd/nand/bcm47xxnflash/main.c +++ b/drivers/mtd/nand/bcm47xxnflash/main.c @@ -77,6 +77,7 @@ static int bcm47xxnflash_remove(struct platform_device *pdev) } static struct platform_driver bcm47xxnflash_driver = { + .probe = bcm47xxnflash_probe, .remove = bcm47xxnflash_remove, .driver = { .name = "bcma_nflash", @@ -88,11 +89,7 @@ static int __init bcm47xxnflash_init(void) { int err; - /* - * Platform device "bcma_nflash" exists on SoCs and is registered very - * early, it won't be added during runtime (use platform_driver_probe). - */ - err = platform_driver_probe(&bcm47xxnflash_driver, bcm47xxnflash_probe); + err = platform_driver_register(&bcm47xxnflash_driver); if (err) pr_err("Failed to register bcm47xx nand flash driver: %d\n", err);