From patchwork Sun Oct 30 16:28:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 122648 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D06BB6F68 for ; Mon, 31 Oct 2011 03:29:19 +1100 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RKYFu-0006kt-Ui; Sun, 30 Oct 2011 16:29:07 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RKYFu-0004Oy-M0; Sun, 30 Oct 2011 16:29:06 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RKYFq-0004Od-Vd for linux-mtd@lists.infradead.org; Sun, 30 Oct 2011 16:29:03 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:6f8:1178:4:5054:ff:fe8d:eefb] helo=pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RKYFn-0004jr-AJ; Sun, 30 Oct 2011 17:28:59 +0100 From: Wolfram Sang To: linux-mtd@lists.infradead.org Subject: [PATCH V2 2/2] mtd: tests: annotate as DANGEROUS in Kconfig Date: Sun, 30 Oct 2011 17:28:49 +0100 Message-Id: <1319992129-13588-1-git-send-email-w.sang@pengutronix.de> X-Mailer: git-send-email 1.7.6.3 In-Reply-To: <1319977792.2126.30.camel@koala> References: <1319977792.2126.30.camel@koala> X-SA-Exim-Connect-IP: 2001:6f8:1178:4:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20111030_122903_205948_F9A718EE X-CRM114-Status: GOOD ( 12.08 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain Cc: Wolfram Sang , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The tests may erase mtd devices, so annotate them as suggested per coding style and add a paragraph to the help text as well. Signed-off-by: Wolfram Sang --- Thanks to Artem for letting me know of this coding style suggestion. drivers/mtd/Kconfig | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 4be8373..cb1821b 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -26,13 +26,16 @@ config MTD_DEBUG_VERBOSE Determines the verbosity level of the MTD debugging messages. config MTD_TESTS - tristate "MTD tests support" + tristate "MTD tests support (DANGEROUS)" depends on m help This option includes various MTD tests into compilation. The tests should normally be compiled as kernel modules. The modules perform various checks and verifications when loaded. + WARNING: Some of the tests will ERASE THE CONTENT of mtd devices! + Do not use these tests unless you are sure you really need to. + config MTD_REDBOOT_PARTS tristate "RedBoot partition table parsing" ---help---