From patchwork Wed Aug 17 05:25:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 110277 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BE063B6F7F for ; Wed, 17 Aug 2011 15:23:55 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QtYbH-0001T6-6S; Wed, 17 Aug 2011 05:23:35 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QtYbG-0005Y1-Lt; Wed, 17 Aug 2011 05:23:34 +0000 Received: from mail-iy0-f171.google.com ([209.85.210.171]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QtYbE-0005Xi-7Z for linux-mtd@lists.infradead.org; Wed, 17 Aug 2011 05:23:33 +0000 Received: by iyf13 with SMTP id 13so1198451iyf.16 for ; Tue, 16 Aug 2011 22:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:message-id :mime-version; bh=xQKF1TNU0AK9TKGe5eQN2pVbsG4+QSM3FNz9+7ygsUU=; b=KSoYOiNa8aOQ1iCBXbPSUYgV8Ff4Dtvs3GzhgDOVOUB3KV0NvB0RNTEVHfkbuK4C90 ImXOFAoh0I9qa1QkIzqMpE5I/04APSlPYtY0ZP8VWTc9cOF46g4TdwZoAibJe2jA/2q2 /J4CiyA+CL+wVmKplTg8dwHYCKE2m9pJZi/0M= Received: by 10.231.3.207 with SMTP id 15mr1303665ibo.0.1313558607929; Tue, 16 Aug 2011 22:23:27 -0700 (PDT) Received: from [127.0.0.1] (jfdmzpr02-ext.jf.intel.com [134.134.137.71]) by mx.google.com with ESMTPS id v5sm267297ibk.44.2011.08.16.22.23.23 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 16 Aug 2011 22:23:26 -0700 (PDT) Subject: Re: [PATCH] mtd/physmap: Fix set_vpp signature in physmap_configure From: Artem Bityutskiy To: Grant Likely Date: Wed, 17 Aug 2011 08:25:08 +0300 In-Reply-To: <1312498433-17950-1-git-send-email-grant.likely@secretlab.ca> References: <1312498433-17950-1-git-send-email-grant.likely@secretlab.ca> X-Mailer: Evolution 3.0.2 (3.0.2-3.fc15) Message-ID: <1313558713.2679.7.camel@sauron> Mime-Version: 1.0 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110817_012332_557203_D3CC5ECA X-CRM114-Status: GOOD ( 18.76 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.171 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dedekind1[at]gmail.com) 0.1 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (dedekind1[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Artem Bityutskiy , David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Russell King X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Thu, 2011-08-04 at 23:53 +0100, Grant Likely wrote: > physmap_configure() has the wrong signature for the set_vpp callback. > struct physmap_flash_data expects it to accpet a platform_device > pointer. > > However, I can't find any users of physmap_configure(), so maybe the > hook should simply be removed. > > Signed-off-by: Grant Likely We have the following patch in l2-mtd-2.6.git waiting for being merged: commit a0b50813e689760de9ccd85e1b29906c2540a7e0 Author: Dmitry Eremin-Solenikov Date: Thu Jun 2 18:51:14 2011 +0400 mtd: drop physmap_configure physmap_configure() and physmap_set_partitions() have no users in kernel. Out of kernel users should have been converted to regular platform device long ago. Drop support for this obsolete API. Signed-off-by: Dmitry Eremin-Solenikov Signed-off-by: Artem Bityutskiy diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c index f64cee4..2174d10 100644 --- a/drivers/mtd/maps/physmap.c +++ b/drivers/mtd/maps/physmap.c @@ -245,21 +245,6 @@ static struct platform_device physmap_flash = { .num_resources = 1, .resource = &physmap_flash_resource, }; - -void physmap_configure(unsigned long addr, unsigned long size, - int bankwidth, void (*set_vpp)(struct map_info *, int)) -{ - physmap_flash_resource.start = addr; - physmap_flash_resource.end = addr + size - 1; - physmap_flash_data.width = bankwidth; - physmap_flash_data.set_vpp = set_vpp; -} - -void physmap_set_partitions(struct mtd_partition *parts, int num_parts) -{ - physmap_flash_data.nr_parts = num_parts; - physmap_flash_data.parts = parts; -} #endif static int __init physmap_init(void)