| Message ID | 1309178086-10604-1-git-send-email-dbaryshkov@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2011-06-27 at 16:34 +0400, Dmitry Eremin-Solenikov wrote: > ofpart.ko also provides ofoldpart MTD parser. Add respective > MODULE_ALIAS("ofoldpart"); declaration. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > --- > drivers/mtd/ofpart.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index aa33b8a..77f0640 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -176,3 +176,6 @@ module_init(ofpart_parser_init); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Parser for MTD partitioning information in device tree"); > MODULE_AUTHOR("Vitaly Wool, David Gibson"); > +/* Required so that this module will be picked up ofoldpart > + * MTD partition information parser */ > +MODULE_ALIAS("ofoldpart"); Well, the codyng style documents how multi-line comments should look like... And this comment is less readable than your previous explanation... But I've fixed this myself and pushed to my tree, thanks!
On 6/28/11, Artem Bityutskiy <dedekind1@gmail.com> wrote: > On Mon, 2011-06-27 at 16:34 +0400, Dmitry Eremin-Solenikov wrote: >> ofpart.ko also provides ofoldpart MTD parser. Add respective >> MODULE_ALIAS("ofoldpart"); declaration. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> >> --- >> drivers/mtd/ofpart.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c >> index aa33b8a..77f0640 100644 >> --- a/drivers/mtd/ofpart.c >> +++ b/drivers/mtd/ofpart.c >> @@ -176,3 +176,6 @@ module_init(ofpart_parser_init); >> MODULE_LICENSE("GPL"); >> MODULE_DESCRIPTION("Parser for MTD partitioning information in device >> tree"); >> MODULE_AUTHOR("Vitaly Wool, David Gibson"); >> +/* Required so that this module will be picked up ofoldpart >> + * MTD partition information parser */ >> +MODULE_ALIAS("ofoldpart"); > > Well, the codyng style documents how multi-line comments should look > like... And this comment is less readable than your previous > explanation... But I've fixed this myself and pushed to my tree, thanks! It seems I've got "All work and no play makes Jack a dull boy" sindrom...
diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c index aa33b8a..77f0640 100644 --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -176,3 +176,6 @@ module_init(ofpart_parser_init); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Parser for MTD partitioning information in device tree"); MODULE_AUTHOR("Vitaly Wool, David Gibson"); +/* Required so that this module will be picked up ofoldpart + * MTD partition information parser */ +MODULE_ALIAS("ofoldpart");
ofpart.ko also provides ofoldpart MTD parser. Add respective MODULE_ALIAS("ofoldpart"); declaration. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- drivers/mtd/ofpart.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)