diff mbox

[2/6] nanddump: change default to --bb=skipbad

Message ID 1308938594-20486-3-git-send-email-computersforpeace@gmail.com
State Accepted
Commit 2521d4f1b6b9866a9c89f3c11a4f6a3d763ff1d7
Headers show

Commit Message

Brian Norris June 24, 2011, 6:03 p.m. UTC 
As promised, we change the default bad block handling method to
--bb=skipbad. This works as a better inverse to nandwrite, since
nandwrite skips bad blocks when writing data.

And of course, we remove the warning messages.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 nanddump.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
diff mbox

Patch

diff --git a/nanddump.c b/nanddump.c
index 55c5586..9edfbfd 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -60,9 +60,9 @@  static void display_help(void)
 "-s addr    --startaddress=addr  Start address\n"
 "\n"
 "--bb=METHOD, where METHOD can be `padbad', `dumpbad', or `skipbad':\n"
-"    padbad:  dump flash data, substituting 0xFF for any bad blocks (default)\n"
+"    padbad:  dump flash data, substituting 0xFF for any bad blocks\n"
 "    dumpbad: dump flash data, including any bad blocks\n"
-"    skipbad: dump good data, completely skipping any bad blocks\n"
+"    skipbad: dump good data, completely skipping any bad blocks (default)\n"
 "\n"
 "Note on --oob, --omitoob:\n"
 "  To make nanddump act more like an inverse to nandwrite, we are changing\n"
@@ -105,7 +105,7 @@  static enum {
 	padbad,   // dump flash data, substituting 0xFF for any bad blocks
 	dumpbad,  // dump flash data, including any bad blocks
 	skipbad,  // dump good data, completely skipping any bad blocks
-} bb_method = padbad;
+} bb_method = skipbad;
 
 static void process_options(int argc, char * const argv[])
 {
@@ -229,11 +229,6 @@  static void process_options(int argc, char * const argv[])
 		exit(EXIT_FAILURE);
 	}
 
-	if (bb_default)
-		warnmsg("you did not specify a default bad-block handling\n"
-			"  method. In future versions, the default will change to\n"
-			"  --bb=skipbad. Use \"nanddump --help\" for more information.");
-
 	if (oob_default)
 		warnmsg("in next release, nanddump will not dump OOB\n"
 			"  by default. Use `nanddump --oob' explicitly to ensure\n"