diff mbox

[V2,1/2] mtd: nand: Allow NAND chip ids to be included standalone.

Message ID 1299542935-20291-1-git-send-email-mnalajal@codeaurora.org
State Rejected
Headers show

Commit Message

Murali Nalajala March 8, 2011, 12:08 a.m. UTC 
Lets non-standard NAND drivers take advantage of known NAND
chip information.

The initial development of msm nand driver, driver uses the supported
NAND devices information as a hardcoded table. Remove the existing
hardcoded supported flash device table and read the flash device
information from the flash id table which are part of the mtd subsystem.

Signed-off-by: Dima Zavin <dima@android.com>
Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
---
Changes in V2
* Add more description to the commit text.

 drivers/mtd/nand/Kconfig |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

Comments

Artem Bityutskiy March 8, 2011, 7:50 a.m. UTC | #1 
On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
> 
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it
"standard" first?
Murali Nalajala March 8, 2011, 5:41 p.m. UTC | #2 
On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>> Lets non-standard NAND drivers take advantage of known NAND
>> chip information.
>>
>> The initial development of msm nand driver, driver uses the supported
>> NAND devices information as a hardcoded table. Remove the existing
>> hardcoded supported flash device table and read the flash device
>> information from the flash id table which are part of the mtd subsystem.
>
> Why this initial version should be upstream? Why wouldn't you make it
> "standard" first?
>

Currently we are not fully using the MTD nand subsystem. That's the 
intention author has introduced "non-standard" here!!!

Thanks,
Murali N
Murali Nalajala March 21, 2011, 6:39 a.m. UTC | #3 
On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>> Lets non-standard NAND drivers take advantage of known NAND
>>> chip information.
>>>
>>> The initial development of msm nand driver, driver uses the supported
>>> NAND devices information as a hardcoded table. Remove the existing
>>> hardcoded supported flash device table and read the flash device
>>> information from the flash id table which are part of the mtd subsystem.
>>
>> Why this initial version should be upstream? Why wouldn't you make it
>> "standard" first?
>>
>
> Currently we are not fully using the MTD nand subsystem. That's the
> intention author has introduced "non-standard" here!!!
>
> Thanks,
> Murali N
>

Any reviews comments on this change?

Thanks,
Murali N
Artem Bityutskiy March 21, 2011, 7:12 a.m. UTC | #4 
On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> >>> Lets non-standard NAND drivers take advantage of known NAND
> >>> chip information.
> >>>
> >>> The initial development of msm nand driver, driver uses the supported
> >>> NAND devices information as a hardcoded table. Remove the existing
> >>> hardcoded supported flash device table and read the flash device
> >>> information from the flash id table which are part of the mtd subsystem.
> >>
> >> Why this initial version should be upstream? Why wouldn't you make it
> >> "standard" first?
> >>
> >
> > Currently we are not fully using the MTD nand subsystem. That's the
> > intention author has introduced "non-standard" here!!!
> >
> > Thanks,
> > Murali N
> >
> 
> Any reviews comments on this change?

No, I think you should "sell" your driver better than that. Indeed,

Q: "Why this initial version should be upstream? Why wouldn't you make
it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the
intention author has introduced "non-standard" here!!!
Murali Nalajala March 21, 2011, 7:58 a.m. UTC | #5 
On 3/21/2011 12:42 PM, Artem Bityutskiy wrote:
> On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
>> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
>>> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>>>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>>>> Lets non-standard NAND drivers take advantage of known NAND
>>>>> chip information.
>>>>>
>>>>> The initial development of msm nand driver, driver uses the supported
>>>>> NAND devices information as a hardcoded table. Remove the existing
>>>>> hardcoded supported flash device table and read the flash device
>>>>> information from the flash id table which are part of the mtd subsystem.
>>>>
>>>> Why this initial version should be upstream? Why wouldn't you make it
>>>> "standard" first?
>>>>
>>>
>>> Currently we are not fully using the MTD nand subsystem. That's the
>>> intention author has introduced "non-standard" here!!!
>>>
>>> Thanks,
>>> Murali N
>>>
>>
>> Any reviews comments on this change?
>
> No, I think you should "sell" your driver better than that. Indeed,
>
> Q: "Why this initial version should be upstream? Why wouldn't you make
> it "standard" first?"
> A: Currently we are not fully using the MTD nand subsystem. That's the
> intention author has introduced "non-standard" here!!!
>

The driver (msm_nand.c) is in align to MTD specification.
But this commit text is bit misleading, initially the driver
didn't make use of nand flash devices information from the
flash id table which are part of the MTD subsystem. Hence
we have enabled this config option to make use of it.

Thanks,
Murali N
Murali Nalajala March 22, 2011, 6:41 a.m. UTC | #6 
On 3/21/2011 1:28 PM, Murali Nalajala wrote:
> On 3/21/2011 12:42 PM, Artem Bityutskiy wrote:
>> On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
>>> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
>>>> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>>>>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>>>>> Lets non-standard NAND drivers take advantage of known NAND
>>>>>> chip information.
>>>>>>
>>>>>> The initial development of msm nand driver, driver uses the supported
>>>>>> NAND devices information as a hardcoded table. Remove the existing
>>>>>> hardcoded supported flash device table and read the flash device
>>>>>> information from the flash id table which are part of the mtd
>>>>>> subsystem.
>>>>>
>>>>> Why this initial version should be upstream? Why wouldn't you make it
>>>>> "standard" first?
>>>>>
>>>>
>>>> Currently we are not fully using the MTD nand subsystem. That's the
>>>> intention author has introduced "non-standard" here!!!
>>>>
>>>> Thanks,
>>>> Murali N
>>>>
>>>
>>> Any reviews comments on this change?
>>
>> No, I think you should "sell" your driver better than that. Indeed,
>>
>> Q: "Why this initial version should be upstream? Why wouldn't you make
>> it "standard" first?"
>> A: Currently we are not fully using the MTD nand subsystem. That's the
>> intention author has introduced "non-standard" here!!!
>>
>
> The driver (msm_nand.c) is in align to MTD specification.
> But this commit text is bit misleading, initially the driver
> didn't make use of nand flash devices information from the
> flash id table which are part of the MTD subsystem. Hence
> we have enabled this config option to make use of it.
>
> Thanks,
> Murali N
>

Hi,
Still you have any issues/comments?

Thanks,
Murali N
Artem Bityutskiy March 22, 2011, 8:11 a.m. UTC | #7 
On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
> Still you have any issues/comments?

No, not so far, just have not time now to look closer.
Murali Nalajala April 6, 2011, 4:38 a.m. UTC | #8 
On 3/22/2011 1:41 PM, Artem Bityutskiy wrote:
> On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
>> Still you have any issues/comments?
>
> No, not so far, just have not time now to look closer.
>
>
Did anybody got a chance to go through the patch?

Thanks,
Murali N
Artem Bityutskiy April 6, 2011, 7:21 a.m. UTC | #9 
On Wed, 2011-04-06 at 10:08 +0530, Murali Nalajala wrote:
> On 3/22/2011 1:41 PM, Artem Bityutskiy wrote:
> > On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
> >> Still you have any issues/comments?
> >
> > No, not so far, just have not time now to look closer.
> >
> >
> Did anybody got a chance to go through the patch?

Could you start with trying to get an ack or reviewed-by from some
maintainer form Codeaurora, e.g., David Brown? Unfortunately, MTD
community does not have enough people who'd actively review other's
work.
Dima Zavin April 7, 2011, 6:28 a.m. UTC | #10 
Acked-by: Dima Zavin <dima@android.com>

On Mon, Mar 7, 2011 at 4:08 PM, Murali Nalajala <mnalajal@codeaurora.org> wrote:
> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
>
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.
>
> Signed-off-by: Dima Zavin <dima@android.com>
> Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
> ---
> Changes in V2
> * Add more description to the commit text.
>
>  drivers/mtd/nand/Kconfig |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index c895922..782275e 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -1,3 +1,10 @@
> +config MTD_NAND_IDS
> +       tristate "Include chip ids for known NAND devices."
> +       depends on MTD
> +       help
> +         Useful for NAND drivers that do not use the NAND subsystem but
> +         still like to take advantage of the known chip information.
> +
>  config MTD_NAND_ECC
>        tristate
>
> @@ -123,9 +130,6 @@ config MTD_NAND_OMAP_PREFETCH_DMA
>         or in DMA interrupt mode.
>         Say y for DMA mode or MPU mode will be used
>
> -config MTD_NAND_IDS
> -       tristate
> -
>  config MTD_NAND_RICOH
>        tristate "Ricoh xD card reader"
>        default n
> --
> 1.7.1.1
>
> --
> Sent by a consultant of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
>
David Brown April 14, 2011, 11:33 p.m. UTC | #11 
On Mon, Mar 07 2011, Murali Nalajala wrote:

> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
>
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.
>
> Signed-off-by: Dima Zavin <dima@android.com>
> Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>

Acked-by: David Brown <davidb@codeaurora.org>
diff mbox

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index c895922..782275e 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -1,3 +1,10 @@ 
+config MTD_NAND_IDS
+	tristate "Include chip ids for known NAND devices."
+	depends on MTD
+	help
+	  Useful for NAND drivers that do not use the NAND subsystem but
+	  still like to take advantage of the known chip information.
+
 config MTD_NAND_ECC
 	tristate
 
@@ -123,9 +130,6 @@  config MTD_NAND_OMAP_PREFETCH_DMA
 	 or in DMA interrupt mode.
 	 Say y for DMA mode or MPU mode will be used
 
-config MTD_NAND_IDS
-	tristate
-
 config MTD_NAND_RICOH
 	tristate "Ricoh xD card reader"
 	default n