Message ID | 1299019251-19518-1-git-send-email-s-paulraj@ti.com |
---|---|
State | Accepted |
Commit | f43272c482661bc88347bba237976eecfc1dbf5b |
Headers | show |
On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote: > From: Sandeep Paulraj <s-paulraj@ti.com> > > The DaVinci NAND driver was including the mach-types.h header > file. > This prevented the DaVinci NAND driver from getting used > in a DSP only device. The linux port on c6x devices can make > use of the same driver and does not define a corresponding > header file; so removing it. > > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com> Hi, you explain why this include is bad for DSP. Buy you do not explain why this include is there and why removing it is harmless for Linux.
> > On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote: > > From: Sandeep Paulraj <s-paulraj@ti.com> > > > > The DaVinci NAND driver was including the mach-types.h header > > file. > > This prevented the DaVinci NAND driver from getting used > > in a DSP only device. The linux port on c6x devices can make > > use of the same driver and does not define a corresponding > > header file; so removing it. > > > > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com> > > Hi, > > you explain why this include is bad for DSP. Buy you do not explain why > this include is there and why removing it is harmless for Linux. > Hi, This header file was required in the driver because earlier there was code dependent on a machine_* check. This piece of code has now been factored out and is in /arch/arm/mach-davinci/aemif.c. Thus removing it is harmless. Please do let me know if you need an updated patch. Regards, Sandeep
On Mon, 2011-03-07 at 08:57 -0600, Paulraj, Sandeep wrote: > > > > On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote: > > > From: Sandeep Paulraj <s-paulraj@ti.com> > > > > > > The DaVinci NAND driver was including the mach-types.h header > > > file. > > > This prevented the DaVinci NAND driver from getting used > > > in a DSP only device. The linux port on c6x devices can make > > > use of the same driver and does not define a corresponding > > > header file; so removing it. > > > > > > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com> > > > > Hi, > > > > you explain why this include is bad for DSP. Buy you do not explain > why > > this include is there and why removing it is harmless for Linux. > > > > Hi, > > This header file was required in the driver because earlier there was > code dependent on a machine_* check. This piece of code has now been > factored out and is in /arch/arm/mach-davinci/aemif.c. > > Thus removing it is harmless. > > Please do let me know if you need an updated patch. Yes, please, patch description should contain this important information.
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c index a90fde3..aff3468 100644 --- a/drivers/mtd/nand/davinci_nand.c +++ b/drivers/mtd/nand/davinci_nand.c @@ -37,9 +37,6 @@ #include <mach/nand.h> #include <mach/aemif.h> -#include <asm/mach-types.h> - - /* * This is a device driver for the NAND flash controller found on the * various DaVinci family chips. It handles up to four SoC chipselects,