Message ID | 1288033416.1865.2.camel@brekeke |
---|---|
State | New, archived |
Headers | show |
On Mon, Oct 25, 2010 at 15:03, Artem Bityutskiy wrote: > Commit 96a4f76f2e9dad7fdbd6fd7740de44bc90d5769e broke 'make install'. > Before that commit, $DESTDIR was undefined, so ${DESTDIR}/${SBINDIR} > was /usr/sbin, and after the commit $DESTDIR became /usr/local, so > ${DESTDIR}/${SBINDIR} became /usr/local//usr/sbin, which is wrong. that isnt really true. DESTDIR had value in makefiles before my changes. > Fix this by making $DESTDIR become the distination directory of installing, > i.e. 'DESTDIR ?= /usr' and making SBINDIR become just 'sbin'. i'd rather we change DESTDIR to match the standard -- it's a "root" prefix only. so the default should be: DESTDIR ?= -mike
diff --git a/common.mk b/common.mk index a55c548..2e4452f 100644 --- a/common.mk +++ b/common.mk @@ -20,12 +20,9 @@ ifneq ($(WITHOUT_LARGEFILE), 1) CPPFLAGS += -D_FILE_OFFSET_BITS=64 endif -DESTDIR ?= /usr/local -PREFIX=/usr -EXEC_PREFIX=$(PREFIX) -SBINDIR=$(EXEC_PREFIX)/sbin -MANDIR=$(PREFIX)/share/man -INCLUDEDIR=$(PREFIX)/include +DESTDIR ?= /usr +SBINDIR=sbin +MANDIR=share/man ifndef BUILDDIR ifeq ($(origin CROSS),undefined)