From patchwork Sat Oct 23 13:43:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enric Balletbo Serra X-Patchwork-Id: 69003 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from canuck.infradead.org (canuck.infradead.org [134.117.69.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 36A16B70A5 for ; Sun, 24 Oct 2010 00:46:18 +1100 (EST) Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P9eOT-0007pA-L3; Sat, 23 Oct 2010 13:44:21 +0000 Received: from mail-wy0-f177.google.com ([74.125.82.177]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P9eOL-0007oO-FP for linux-mtd@lists.infradead.org; Sat, 23 Oct 2010 13:44:14 +0000 Received: by wyf22 with SMTP id 22so1948483wyf.36 for ; Sat, 23 Oct 2010 06:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=kQVuBu5RtJWSa9ZvucDitQoU6YyM1kKnP9lzE1lKiuM=; b=PWXE5DmIrD6r59Z6XL5uytdcgxOMUzAO8sjXEEj/QOuHLjJpj+6m4TfFEmeb67L4jy 7Fe9Xcsuo7Mvhvce3YUx0IxkeadD99Gbj1xvNjExhciVNEwpbCdUBTv77SZXT6lHM3Yz 8gesh75nIJkLbaUrLBfeeRq8lPP5nS554ZQC8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=uchtx+fE7iUpipwAoylIv+eysCk4zu0a+mZrHxzDiBSYnssTPPIS5pqNpCKwMWSPtH myMaxsFNE5k6g+1Xv6sH5ZZICqTg+TNWBPrSbNtK446lVd/9ItvLIuGUeZm2JVorK0dz 0vVPFIJ2JQl7UUscZEMZxU0dqKqKJM/WbuXBU= Received: by 10.216.66.146 with SMTP id h18mr26622wed.106.1287841452710; Sat, 23 Oct 2010 06:44:12 -0700 (PDT) Received: from localhost.localdomain ([83.52.77.213]) by mx.google.com with ESMTPS id y15sm2718929weq.30.2010.10.23.06.44.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 23 Oct 2010 06:44:12 -0700 (PDT) From: Enric Balletbo i Serra To: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, kyungmin.park@samsung.com, dwmw2@infradead.org, Artem.Bityutskiy@nokia.com, adrian.hunter@nokia.com, m.szyprowski@samsung.com Subject: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes. Date: Sat, 23 Oct 2010 15:43:54 +0200 Message-Id: <1287841434-3349-2-git-send-email-eballetbo@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287841434-3349-1-git-send-email-eballetbo@gmail.com> References: <1287841434-3349-1-git-send-email-eballetbo@gmail.com> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20101023_094413_683497_D6383EBF X-CRM114-Status: GOOD ( 17.38 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is freemail (eballetbo[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL Cc: Enric Balletbo i Serra X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch adds code that I think was lost when it was applied the commit 5988af2319781bc8e0ce418affec4e09cfa77907 - mtd: Flex-OneNAND support Test case: 1. Stress a jffs2 filesystem using bonnie++ -u 0:0 -s 32 -m 16 -r 16 2. dmesg shows various 'Header CRC failed' errors like: Header CRC failed on REF_PRISTINE node at 0x1e81315c: Read 0x000000e0, calculated 0x564fc9e8 Tested on IGEP v2 board with a Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58) with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y Signed-off-by: Enric Balletbo i Serra --- drivers/mtd/onenand/onenand_base.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index a2bb520..53aa13e 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -1964,6 +1964,10 @@ static int onenand_write_ops_nolock(struct mtd_info *mtd, loff_t to, /* In partial page write we don't update bufferram */ onenand_update_bufferram(mtd, to, !ret && !subpage); + ONENAND_SET_BUFFERRAM1(this); + onenand_update_bufferram(mtd, to + this->writesize, + !ret && !subpage); + if (ret) { printk(KERN_ERR "%s: write failed %d\n", __func__, ret);