diff mbox

[1/2] nanddump: drop unused --ignoreerrors option

Message ID 1284263427-31342-1-git-send-email-vapier@gentoo.org
State Accepted, archived
Commit e5a8bd7061921a9a787ffbb2c47a5af8f439d342
Headers show

Commit Message

Mike Frysinger Sept. 12, 2010, 3:50 a.m. UTC 
Nowhere in the nanddump code is the "ignoreerrors" variable used.  So
drop the option completely.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 nanddump.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

Comments

Artem Bityutskiy Sept. 12, 2010, 8:09 a.m. UTC | #1 
On Sat, 2010-09-11 at 23:50 -0400, Mike Frysinger wrote:
> Nowhere in the nanddump code is the "ignoreerrors" variable used.  So
> drop the option completely.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Pushed, thanks.
diff mbox

Patch

diff --git a/nanddump.c b/nanddump.c
index 22fec5f..70b78f0 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -48,7 +48,6 @@  static void display_help (void)
 "-a         --forcebinary        Force printing of binary data to tty\n"
 "-c         --canonicalprint     Print canonical Hex+ASCII dump\n"
 "-f file    --file=file          Dump to file\n"
-"-i         --ignoreerrors       Ignore errors\n"
 "-l length  --length=length      Length\n"
 "-n         --noecc              Read without error correction\n"
 "-o         --omitoob            Omit oob data\n"
@@ -75,7 +74,6 @@  static void display_version (void)
 
 // Option variables
 
-static bool		ignoreerrors = false;	// ignore errors
 static bool		pretty_print = false;	// print nice
 static bool		noecc = false;		// don't error correct
 static bool		omitoob = false;	// omit oob data
@@ -94,14 +92,13 @@  static void process_options (int argc, char * const argv[])
 
 	for (;;) {
 		int option_index = 0;
-		static const char *short_options = "bs:f:il:opqnca";
+		static const char *short_options = "bs:f:l:opqnca";
 		static const struct option long_options[] = {
 			{"help", no_argument, 0, 0},
 			{"version", no_argument, 0, 0},
 			{"forcebinary", no_argument, 0, 'a'},
 			{"canonicalprint", no_argument, 0, 'c'},
 			{"file", required_argument, 0, 'f'},
-			{"ignoreerrors", no_argument, 0, 'i'},
 			{"prettyprint", no_argument, 0, 'p'},
 			{"omitoob", no_argument, 0, 'o'},
 			{"omitbad", no_argument, 0, 'b'},
@@ -141,9 +138,6 @@  static void process_options (int argc, char * const argv[])
 					exit(EXIT_FAILURE);
 				}
 				break;
-			case 'i':
-				ignoreerrors = true;
-				break;
 			case 'l':
 				length = strtol(optarg, NULL, 0);
 				break;