From patchwork Wed Jan 21 00:38:39 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaswinder Singh Rajput X-Patchwork-Id: 19560 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 53991DDF06 for ; Wed, 21 Jan 2009 11:41:53 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LPR8F-0003N4-8E; Wed, 21 Jan 2009 00:39:47 +0000 Received: from hera.kernel.org ([140.211.167.34]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1LPR8D-0003Mx-G2 for linux-mtd@lists.infradead.org; Wed, 21 Jan 2009 00:39:45 +0000 Received: from [192.168.1.3] (triband-del-59.180.61.40.bol.net.in [59.180.61.40] (may be forged)) (authenticated bits=0) by hera.kernel.org (8.14.2/8.13.8) with ESMTP id n0L0cjsc019726 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 21 Jan 2009 00:38:49 GMT Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings From: Jaswinder Singh Rajput To: "H. Peter Anvin" In-Reply-To: <49725B1E.604@kernel.org> References: <1232223441.3966.22.camel@localhost.localdomain> <1232228261.27094.0.camel@macbook.infradead.org> <20090117221932.GA4956@uranus.ravnborg.org> <49725B1E.604@kernel.org> Date: Wed, 21 Jan 2009 06:08:39 +0530 Message-Id: <1232498319.3123.34.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-3.fc10) X-Virus-Scanned: ClamAV 0.93.3/8881/Tue Jan 20 14:48:51 2009 on hera.kernel.org X-Virus-Status: Clean Cc: urs.thuermann@volkswagen.de, neilb@suse.de, greg@kroah.com, bfields@fieldses.org, linux-mtd@lists.infradead.org, Sam Ravnborg , dbrownell@users.sourceforge.net, x86 maintainers , tiwai@suse.de, Ingo Molnar , linux-media@vger.kernel.org, mchehab@infradead.org, linux-raid@vger.kernel.org, netfilter@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, LKML , netfilter-devel@vger.kernel.org, oliver.hartkopp@volkswagen.de, spi-devel-general@lists.sourceforge.net, Andrew Morton , David Woodhouse X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > >>> > >> That patch looks wrong, and unnecessary. It was fine before. > > Nope - include/linux/dvb/audio.h failed to include linux/types.h > > despite the fact that is uses __u32 etc. > > > > But why the _kernel_ should include a userspace header is > > much more questionable. > > > > is one of a handful of headers provided by gcc itself. > Should I reintroduce my patch to solve this warning of 'make headers_check': usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include Or you guys have some better plan. Thanks, --- JSR diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h index 89412e1..758a48c 100644 --- a/include/linux/dvb/audio.h +++ b/include/linux/dvb/audio.h @@ -24,9 +24,8 @@ #ifndef _DVBAUDIO_H_ #define _DVBAUDIO_H_ -#ifdef __KERNEL__ #include -#else +#ifndef __KERNEL__ #include #endif