| Message ID | 1224591951-30369-1-git-send-email-steve.glendinning@smsc.com |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 21, 2008 at 3:25 PM, Steve Glendinning <steve.glendinning@smsc.com> wrote: > Build failure introduced by 5bf1723723487ddb0b9c9641b6559da96b27cc93 > [JFFS2] Write buffer offset adjustment for NOR-ECC (Sibley) flash > > Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> Steve, Thank you for finding this. Alexander
Alexander, This build failure still exists in linus's tree (2.6.28-rc3). Can you please push this fix upstream, as it's a build regression for many embedded platforms? Regards, -- Steve Glendinning SMSC GmbH m: +44 777 933 9124 e: steve.glendinning@smsc.com "Alexander Belyakov" <abelyako@googlemail.com> wrote on 27/10/2008 09:29:34: > On Tue, Oct 21, 2008 at 3:25 PM, Steve Glendinning > <steve.glendinning@smsc.com> wrote: > > Build failure introduced by 5bf1723723487ddb0b9c9641b6559da96b27cc93 > > [JFFS2] Write buffer offset adjustment for NOR-ECC (Sibley) flash > > > > Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> > > Steve, > > Thank you for finding this. > > Alexander
diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c index 0875b60..21a0529 100644 --- a/fs/jffs2/nodemgmt.c +++ b/fs/jffs2/nodemgmt.c @@ -261,9 +261,11 @@ static int jffs2_find_nextblock(struct jffs2_sb_info *c) jffs2_sum_reset_collected(c->summary); /* reset collected summary */ +#ifdef CONFIG_JFFS2_FS_WRITEBUFFER /* adjust write buffer offset, else we get a non contiguous write bug */ if (!(c->wbuf_ofs % c->sector_size) && !c->wbuf_len) c->wbuf_ofs = 0xffffffff; +#endif D1(printk(KERN_DEBUG "jffs2_find_nextblock(): new nextblock = 0x%08x\n", c->nextblock->offset));
Build failure introduced by 5bf1723723487ddb0b9c9641b6559da96b27cc93 [JFFS2] Write buffer offset adjustment for NOR-ECC (Sibley) flash Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> --- fs/jffs2/nodemgmt.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)