From patchwork Thu Dec 26 03:18:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 305180 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5977A2C009F for ; Thu, 26 Dec 2013 14:19:31 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1Tn-0000B6-1H; Thu, 26 Dec 2013 03:19:23 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1Tl-0003YU-F4; Thu, 26 Dec 2013 03:19:21 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1Ti-0003Xe-SE for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 03:19:19 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MYE0077J97LMX40@mailout1.samsung.com> for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 12:18:57 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id C6.D3.10364.020ABB25; Thu, 26 Dec 2013 12:18:57 +0900 (KST) X-AuditID: cbfee690-b7f266d00000287c-55-52bba02054b7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 4E.2B.29263.020ABB25; Thu, 26 Dec 2013 12:18:56 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MYE00L1M97KQ060@mmp2.samsung.com>; Thu, 26 Dec 2013 12:18:56 +0900 (KST) From: Jingoo Han To: 'Brian Norris' References: <008201cf01e6$6b894da0$429be8e0$%han@samsung.com> In-reply-to: <008201cf01e6$6b894da0$429be8e0$%han@samsung.com> Subject: [PATCH 19/23] mtd: lpc32xx_slc: Remove unnecessary OOM messages Date: Thu, 26 Dec 2013 12:18:56 +0900 Message-id: <009601cf01e9$365bb020$a3131060$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8B5mtzkTdrU9xBTMqwYMW1EKs9jgAAri0g Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zA13FBbuDDHalWRy5sJbZYuLKycwW lxdeYrXY3bSM3WLykrOsDqwec6buZvTYOesuu8fmFVoem5fUe/RtWcUYwBrFZZOSmpNZllqk b5fAldE+8RpLwTOeil9fj7M0MJ7i6mLk5JAQMJHYt+4fI4QtJnHh3no2EFtIYBmjxJIXzDA1 B6a0ANVwAcWnM0pcPtTACuH8YpTY+fMsWDebgJrEly+H2bsYOThEBAwkfrzJBKlhFpjCKLHh 2iJ2iKm2EocO7wSr5xSwA+pdxgJiCwt4SOya2AdmswioSsy+/heshheofuWWacwQtqDEj8n3 wGqYBbQk1u88zgRhy0tsXvOWGWSvhIC6xKO/uiBhEQEjiRNbZkOViEjse/EO7AEJgXvsEo+2 NbJD7BKQ+Db5EAtEr6zEpgNQD0tKHFxxg2UCo8QsJJtnIdk8C8nmWUhWLGBkWcUomlqQXFCc lF5kolecmFtcmpeul5yfu4kREqUTdjDeO2B9iDEZaP1EZinR5HxglOeVxBsamxlZmJqYGhuZ W5qRJqwkzqv2KClISCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2Oz2owHPvfWX150sOyRgGUN yyKZzKVpzI/b62dP7Yu0ernqdg+nQbbolY0PXj/WmhLneavqE8vFZy8zDx+Rm5OosElRmS2L X/qtn/6nTRIH7xle00tbKVjDHTmzPkcmrCDwXNkc+fDfF1o8Yqt4zYvaWa1Ld7ru+Hphqc4i Gb0FpyxWTgrdyKHEUpyRaKjFXFScCADvO/Hc6AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV2FBbuDDNZPsrI4cmEts8XElZOZ LS4vvMRqsbtpGbvF5CVnWR1YPeZM3c3osXPWXXaPzSu0PDYvqffo27KKMYA1qoHRJiM1MSW1 SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdouZJCWWJOKVAoILG4 WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4xo33iNZaCZzwVv74eZ2lgPMXVxcjJISFgInFg SgsjhC0mceHeerYuRi4OIYHpjBKXDzWwQji/GCV2/jwLVsUmoCbx5cth9i5GDg4RAQOJH28y QWqYBaYwSmy4togdpEZIwFbi0OGdYPWcAnZAvctYQGxhAQ+JXRP7wGwWAVWJ2df/gtXwAtWv 3DKNGcIWlPgx+R5YDbOAlsT6nceZIGx5ic1r3jKD7JUQUJd49FcXJCwiYCRxYstsqBIRiX0v 3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYwWngmdQO xpUNFocYBTgYlXh4O3R3BwmxJpYVV+YeYpTgYFYS4d3VDRTiTUmsrEotyo8vKs1JLT7EmAz0 6ERmKdHkfGCKyiuJNzQ2MTOyNDKzMDIxNydNWEmc90CrdaCQQHpiSWp2ampBahHMFiYOTqkG Rpdb/nsnJlTG3Nkowd7udExb4kATh3HZ1IWdzmaP1hhcnfbRwm6hmUIxs/utHWs3MG3PvztF Tcv7seZEuffvOmM+zfQ31Ws8eaZzTu2rWO843edx1nySM9Z/i059ar962zWvRxuMBD1fehw9 s/B39K9fl1+FBIUd7Xz3b3qh0M5vrx7+zZdTYFZiKc5INNRiLipOBABTCEgWRwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131225_221919_168421_75C5E2B0 X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.24 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: 'Roland Stigge' , linux-mtd@lists.infradead.org, 'Jingoo Han' , 'David Woodhouse' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han Acked-by: Roland Stigge --- drivers/mtd/nand/lpc32xx_slc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c index 5f20394..53a6742 100644 --- a/drivers/mtd/nand/lpc32xx_slc.c +++ b/drivers/mtd/nand/lpc32xx_slc.c @@ -725,10 +725,8 @@ static struct lpc32xx_nand_cfg_slc *lpc32xx_parse_dt(struct device *dev) struct device_node *np = dev->of_node; ncfg = devm_kzalloc(dev, sizeof(*ncfg), GFP_KERNEL); - if (!ncfg) { - dev_err(dev, "could not allocate memory for NAND config\n"); + if (!ncfg) return NULL; - } of_property_read_u32(np, "nxp,wdr-clks", &ncfg->wdr_clks); of_property_read_u32(np, "nxp,wwidth", &ncfg->wwidth); @@ -772,10 +770,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) /* Allocate memory for the device structure (and zero it) */ host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_err(&pdev->dev, "failed to allocate device structure\n"); + if (!host) return -ENOMEM; - } host->io_base_dma = rc->start; host->io_base = devm_ioremap_resource(&pdev->dev, rc); @@ -858,7 +854,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) host->data_buf = devm_kzalloc(&pdev->dev, host->dma_buf_len, GFP_KERNEL); if (host->data_buf == NULL) { - dev_err(&pdev->dev, "Error allocating memory\n"); res = -ENOMEM; goto err_exit2; }