| Message ID | 004f01ce4aec$c841b610$58c52230$@samsung.com |
|---|---|
| State | Accepted |
| Commit | 91e859211af012555672e090106183a691ed71e2 |
| Headers | show |
On 5/7/2013 2:33 PM, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Josh Wu <josh.wu@atmel.com> Best Regards, Josh Wu > --- > drivers/mtd/nand/atmel_nand.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > index 2d23d29..36c52f5 100644 > --- a/drivers/mtd/nand/atmel_nand.c > +++ b/drivers/mtd/nand/atmel_nand.c > @@ -1665,7 +1665,6 @@ err_hw_ecc: > err_scan_ident: > err_no_card: > atmel_nand_disable(host); > - platform_set_drvdata(pdev, NULL); > if (host->dma_chan) > dma_release_channel(host->dma_chan); > err_ecc_ioremap:
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 2d23d29..36c52f5 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1665,7 +1665,6 @@ err_hw_ecc: err_scan_ident: err_no_card: atmel_nand_disable(host); - platform_set_drvdata(pdev, NULL); if (host->dma_chan) dma_release_channel(host->dma_chan); err_ecc_ioremap:
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/mtd/nand/atmel_nand.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)