diff mbox

[2/8] mtd: spear_smi: Remove unnecessary OOM messages

Message ID 000401cf2302$1768bac0$463a3040$%han@samsung.com
State Accepted
Commit bb339decb33684fcd9a88b62d2abe8bc95f68269
Headers show

Commit Message

Jingoo Han Feb. 6, 2014, 6:10 a.m. UTC
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mtd/devices/spear_smi.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Viresh Kumar Feb. 7, 2014, 5:44 a.m. UTC | #1
On 6 February 2014 11:40, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/mtd/devices/spear_smi.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
> index 4238214..363da96 100644
> --- a/drivers/mtd/devices/spear_smi.c
> +++ b/drivers/mtd/devices/spear_smi.c
> @@ -913,7 +913,6 @@ static int spear_smi_probe(struct platform_device *pdev)
>         if (np) {
>                 pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
>                 if (!pdata) {
> -                       pr_err("%s: ERROR: no memory", __func__);
>                         ret = -ENOMEM;
>                         goto err;
>                 }
> @@ -943,7 +942,6 @@ static int spear_smi_probe(struct platform_device *pdev)
>         dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_ATOMIC);
>         if (!dev) {
>                 ret = -ENOMEM;
> -               dev_err(&pdev->dev, "mem alloc fail\n");
>                 goto err;
>         }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff mbox

Patch

diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 4238214..363da96 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -913,7 +913,6 @@  static int spear_smi_probe(struct platform_device *pdev)
 	if (np) {
 		pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
 		if (!pdata) {
-			pr_err("%s: ERROR: no memory", __func__);
 			ret = -ENOMEM;
 			goto err;
 		}
@@ -943,7 +942,6 @@  static int spear_smi_probe(struct platform_device *pdev)
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_ATOMIC);
 	if (!dev) {
 		ret = -ENOMEM;
-		dev_err(&pdev->dev, "mem alloc fail\n");
 		goto err;
 	}