mbox series

[0/2] mtd: ubi: Fix some initialisation failure cases

Message ID cover.1712788087.git.ben.hutchings@mind.be
Headers show
Series mtd: ubi: Fix some initialisation failure cases | expand

Message

Ben Hutchings April 10, 2024, 10:42 p.m. UTC 
ubi currently fails to initialise if debugfs is enabled at build time
but disabled at boot time (CONFIG_DEBUG_FS is enabled and debugfs=off
is set on the kernel command line).  Errors from debugfs should always
be ignored but this wasn't done everywhere.

While fixing this I also noticed that a recent change to ubi removed
some cleanup from the ubi_init() failure path that I think is still
needed.

This series should fix both problems.

Ben.

Ben Hutchings (2):
  mtd: ubi: Restore missing cleanup on ubi_init() failure path
  mtd: ubi: Ignore all debugfs initialisation failures

 drivers/mtd/ubi/build.c | 15 ++++++---------
 drivers/mtd/ubi/debug.c | 33 +++++++--------------------------
 drivers/mtd/ubi/debug.h |  4 ++--
 3 files changed, 15 insertions(+), 37 deletions(-)

Comments

Zhihao Cheng April 11, 2024, 3:30 a.m. UTC | #1 
在 2024/4/11 6:42, Ben Hutchings 写道:
> ubi currently fails to initialise if debugfs is enabled at build time
> but disabled at boot time (CONFIG_DEBUG_FS is enabled and debugfs=off
> is set on the kernel command line).  Errors from debugfs should always
> be ignored but this wasn't done everywhere.
> 
> While fixing this I also noticed that a recent change to ubi removed
> some cleanup from the ubi_init() failure path that I think is still
> needed.
> 
> This series should fix both problems.
> 
> Ben.

Hi, Ben. I have a same patch with your first one, I have merge our 
patchset into a new series [1]
[1] 
https://lore.kernel.org/linux-mtd/20240411031903.3050278-1-chengzhihao1@huawei.com/
> 
> Ben Hutchings (2):
>    mtd: ubi: Restore missing cleanup on ubi_init() failure path
>    mtd: ubi: Ignore all debugfs initialisation failures
> 
>   drivers/mtd/ubi/build.c | 15 ++++++---------
>   drivers/mtd/ubi/debug.c | 33 +++++++--------------------------
>   drivers/mtd/ubi/debug.h |  4 ++--
>   3 files changed, 15 insertions(+), 37 deletions(-)
>
Ben Hutchings April 11, 2024, 3:09 p.m. UTC | #2 
On Thu, Apr 11, 2024 at 11:30:41AM +0800, Zhihao Cheng wrote:
> 在 2024/4/11 6:42, Ben Hutchings 写道:
> > ubi currently fails to initialise if debugfs is enabled at build time
> > but disabled at boot time (CONFIG_DEBUG_FS is enabled and debugfs=off
> > is set on the kernel command line).  Errors from debugfs should always
> > be ignored but this wasn't done everywhere.
> > 
> > While fixing this I also noticed that a recent change to ubi removed
> > some cleanup from the ubi_init() failure path that I think is still
> > needed.
> > 
> > This series should fix both problems.
> > 
> > Ben.
> 
> Hi, Ben. I have a same patch with your first one, I have merge our patchset
> into a new series [1]
> [1] https://lore.kernel.org/linux-mtd/20240411031903.3050278-1-chengzhihao1@huawei.com/
[...]

Thank you!

Ben.