| Message ID | 20211203142256.47370-1-tudor.ambarus@microchip.com |
|---|---|
| Headers | show |
| Series | mtd: spi-nor: Clean params init | expand |
Hi Tudor, On 03/12/21 04:22PM, Tudor Ambarus wrote: > Clean spi_nor_scan() and the flash parameters initialization code. > Reworked how the flags are handled for the flash_info entries. > Tested all the flashes from patch set. > > Changes in v5: > - new patch 0001-mtd-spi-nor-Fix-mtd-size-for-s3an-flashes.patch > - update comment from > '[PATCH v4 02/13] mtd: spi-nor: Introduce spi_nor_set_mtd_info()', > s/'No mtd_info fields are used up to this point.'/ > 'No mtd_info fields should be used up to this point.' > - collect R-b tags I only have a small nitpick with patch 9. The rest of the series looks good to me. Let's apply this soon so it can get a chance to cook in next for a few rc cycles.
On 12/6/21 2:25 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Tudor, > > On 03/12/21 04:22PM, Tudor Ambarus wrote: >> Clean spi_nor_scan() and the flash parameters initialization code. >> Reworked how the flags are handled for the flash_info entries. >> Tested all the flashes from patch set. >> >> Changes in v5: >> - new patch 0001-mtd-spi-nor-Fix-mtd-size-for-s3an-flashes.patch >> - update comment from >> '[PATCH v4 02/13] mtd: spi-nor: Introduce spi_nor_set_mtd_info()', >> s/'No mtd_info fields are used up to this point.'/ >> 'No mtd_info fields should be used up to this point.' >> - collect R-b tags > > I only have a small nitpick with patch 9. The rest of the series looks > good to me. Let's apply this soon so it can get a chance to cook in next > for a few rc cycles. > Will update patch 9. Thanks Pratyush!
Clean spi_nor_scan() and the flash parameters initialization code. Reworked how the flags are handled for the flash_info entries. Tested all the flashes from patch set. Changes in v5: - new patch 0001-mtd-spi-nor-Fix-mtd-size-for-s3an-flashes.patch - update comment from '[PATCH v4 02/13] mtd: spi-nor: Introduce spi_nor_set_mtd_info()', s/'No mtd_info fields are used up to this point.'/ 'No mtd_info fields should be used up to this point.' - collect R-b tags Changes in v4: - new patch: "mtd: spi-nor: core: Don't use mtd_info in the NOR's probe sequence of calls" - move spi_nor_post_sfdp_fixups() in drivers/mtd/spi-nor/sfdp.c - Reworked flash_info flags. nor->info->flags are split in new flash_info members: parse_sfdp, flags, no_sfdp_flags, fixup_flags and mfr_flags. - remove roll-back mechanism for flashes that use PARSE_SFDP. - dropped R-b tags where the new version of the patch modified how things are handled - v4 changes log in each commit after --- Changes in v3: - move late_init() in struct spi_nor_fixups and update patches accordingly. R-b tags were dropped. - new patch "mtd: spi-nor: sst: Get rid of SST_WRITE flash_info flag" moves manufacturer specific flag out of the core. - update methods description to make it clear who sets when - introduce flash_info flag masks to make it clear when one should be set. - rework "parse SFDP first idea". Tudor Ambarus (14): mtd: spi-nor: Fix mtd size for s3an flashes mtd: spi-nor: core: Don't use mtd_info in the NOR's probe sequence of calls mtd: spi-nor: Introduce spi_nor_set_mtd_info() mtd: spi-nor: core: Call spi_nor_post_sfdp_fixups() only when SFDP is defined mtd: spi-nor: core: Introduce flash_info mfr_flags mtd: spi-nor: Rework the flash_info flags mtd: spi-nor: Introduce spi_nor_init_flags() mtd: spi-nor: Introduce spi_nor_init_fixup_flags() mtd: spi-nor: core: Init all flash parameters based on SFDP where possible mtd: spi-nor: core: Move spi_nor_set_addr_width() in spi_nor_setup() mtd: spi-nor: winbond: w25q256jvm: Init flash based on SFDP mtd: spi-nor: spansion: s25fl256s0: Skip SFDP parsing mtd: spi-nor: gigadevice: gd25q256: Init flash based on SFDP mtd: spi-nor: issi: is25lp256: Init flash based on SFDP drivers/mtd/spi-nor/atmel.c | 71 +++-- drivers/mtd/spi-nor/catalyst.c | 15 +- drivers/mtd/spi-nor/core.c | 500 +++++++++++++++++-------------- drivers/mtd/spi-nor/core.h | 206 ++++++++----- drivers/mtd/spi-nor/eon.c | 33 +- drivers/mtd/spi-nor/esmt.c | 15 +- drivers/mtd/spi-nor/everspin.c | 12 +- drivers/mtd/spi-nor/fujitsu.c | 3 +- drivers/mtd/spi-nor/gigadevice.c | 57 ++-- drivers/mtd/spi-nor/intel.c | 12 +- drivers/mtd/spi-nor/issi.c | 60 ++-- drivers/mtd/spi-nor/macronix.c | 105 ++++--- drivers/mtd/spi-nor/micron-st.c | 211 +++++++------ drivers/mtd/spi-nor/otp.c | 2 +- drivers/mtd/spi-nor/sfdp.c | 20 ++ drivers/mtd/spi-nor/spansion.c | 160 +++++----- drivers/mtd/spi-nor/sst.c | 88 ++++-- drivers/mtd/spi-nor/swp.c | 2 +- drivers/mtd/spi-nor/winbond.c | 161 +++++----- drivers/mtd/spi-nor/xilinx.c | 2 +- drivers/mtd/spi-nor/xmc.c | 10 +- 21 files changed, 985 insertions(+), 760 deletions(-)