mbox series

[0/4] meson-nand: small code improvements

Message ID 20190411220056.19109-1-martin.blumenstingl@googlemail.com
Headers show
Series meson-nand: small code improvements | expand

Message

Martin Blumenstingl April 11, 2019, 10 p.m. UTC 
This series comes with four small improvements for the meson-nand
driver:
* the first patches are replacing open-coded logic with existing
  utilities / helpers
* the third patch drops some unnecessary casting after changing
  the type of the info buffer parameter from "u8 *" to "void *"
* the fourth patch adjusts the usage of init_completion with what the
  documentation suggests

I have tested these patches as best as I could on my Meson8m2 board
using experimental patches on top of this series which add support for
this older SoC to the meson-nand driver.

Liang, can you please test this series on GXL and/or AXG so I don't
break the NFC driver on these newer SoCs? All of my GXL/GXM boards
have eMMC instead of raw NAND, so I cannot test it on these newer SoCs
myself.

This series is meant to be applied to the nand/next tree.


Martin Blumenstingl (4):
  mtd: rawnand: meson: use struct_size macro
  mtd: rawnand: meson: use of_property_count_elems_of_size helper
  mtd: rawnand: meson: use a void pointer for meson_nfc_dma_buffer_setup
  mtd: rawnand: meson: only initialize the RB completion once

 drivers/mtd/nand/raw/meson_nand.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

Comments

Miquel Raynal April 18, 2019, 4:22 p.m. UTC | #1 
Hi Martin,

Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote on Fri,
12 Apr 2019 00:00:52 +0200:

> This series comes with four small improvements for the meson-nand
> driver:
> * the first patches are replacing open-coded logic with existing
>   utilities / helpers
> * the third patch drops some unnecessary casting after changing
>   the type of the info buffer parameter from "u8 *" to "void *"
> * the fourth patch adjusts the usage of init_completion with what the
>   documentation suggests
> 
> I have tested these patches as best as I could on my Meson8m2 board
> using experimental patches on top of this series which add support for
> this older SoC to the meson-nand driver.
> 
> Liang, can you please test this series on GXL and/or AXG so I don't
> break the NFC driver on these newer SoCs? All of my GXL/GXM boards
> have eMMC instead of raw NAND, so I cannot test it on these newer SoCs
> myself.
> 
> This series is meant to be applied to the nand/next tree.
> 
> 
> Martin Blumenstingl (4):
>   mtd: rawnand: meson: use struct_size macro
>   mtd: rawnand: meson: use of_property_count_elems_of_size helper
>   mtd: rawnand: meson: use a void pointer for meson_nfc_dma_buffer_setup
>   mtd: rawnand: meson: only initialize the RB completion once
> 
>  drivers/mtd/nand/raw/meson_nand.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
> 

Series applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git 
branch nand/next.

Thanks,
Miquèl