From patchwork Sun Nov 11 07:55:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Brezillon X-Patchwork-Id: 996065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CCv3Yf2R"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="dws2JTYZ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42t5mj5FyRz9s3q for ; Sun, 11 Nov 2018 18:56:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Y8LaVlXd/IdXeFMbMJU131L+xBdtAV/9/k9apOHc7kI=; b=CCv 3Yf2R6g+RGjB2h4p9iaqL0/Mu0dTvjxaH8pdK2tKEfuh+PVqAowcMuJYtA3cVmpQUr433KyXZdvct REOL3SKjcZraDR13jrMglvwqaz0Ld4zwW5a4oM6Bg+TLRbyEXbFaumTwWXqKA5EN2VTaIHI6fXG8E MLrFMpA+c5NUwLJQ6K66FShUSZECMrHDJgIpdkv9HXIuvGrw2CXqaX3VD39XgIpM5s3UaMAhTdNph vHDLoMTMJCRT8gtmThQdzff6Y0Lvlbxuc2oC1RbCexH+4F5Cpc2mAf/EHvHYsWX5R4NyDLRjcIOL/ aw4PEK8t7P7D64+SQ6Bh0ONzRsbYTYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLkbA-0006eA-FM; Sun, 11 Nov 2018 07:56:00 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLkat-0006He-CC for linux-mtd@bombadil.infradead.org; Sun, 11 Nov 2018 07:55:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8FoGSc9toAY59NYC0g3cffL+3dtCwxGz9Max/J7Wrj0=; b=dws2JTYZkqp2jbYa2uZcuQHfU GUYEwtC7hWctqMiZSpGxlhhCvX/X7v/qc2tx7ZtpCTOj6LigakcHY6JluRS5jdGjuGqp7megeK96q j7/xYd0cdu4CVXnlmCENfGc1RCi3oDadsUS1kecwMVIuFM9z6hbR3Qg3cohlUUTBPHnk1jHjltA60 urGcQukDb/WcdUjT3ExNy/a21M+DDtWUSMDdid4J2Y6msRFsxj4JSFiwrfe8T6Ae2k0hJCeM6MQlO Maf2dRyYaxF+EwfA7pajrSY9i4J+nrg3Vf7eSpcIUf6OErSbnSLsSCqVgA7OkjGTRl6lVJPl6r6q0 GW2ujaPJw==; Received: from mail.bootlin.com ([62.4.15.54]) by merlin.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLkao-0004Y7-QT for linux-mtd@lists.infradead.org; Sun, 11 Nov 2018 07:55:40 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id D9AC6206A7; Sun, 11 Nov 2018 08:55:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost.localdomain (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 68F76206A7; Sun, 11 Nov 2018 08:55:26 +0100 (CET) From: Boris Brezillon To: Boris Brezillon , Richard Weinberger , Miquel Raynal , linux-mtd@lists.infradead.org Subject: [PATCH v3 00/22] mtd: rawnand: 3rd batch of cleanup Date: Sun, 11 Nov 2018 08:55:02 +0100 Message-Id: <20181111075524.13123-1-boris.brezillon@bootlin.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181111_025539_622593_6A61F3A4 X-CRM114-Status: GOOD ( 14.68 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on merlin.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Levitsky , Marek Vasut , Tudor Ambarus , Janusz Krzysztofik , Stefan Agner , Masahiro Yamada , Harvey Hunt , Marc Gonzalez , Han Xu , Xiaolei Li , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hello, After the sanitization of the raw NAND API, here is a smaller patchset continuing in this direction. Patch 1 is just a follow-up on the "stop passing mtd_info objects around" patches, except this times it takes care of internal functions. There's still a lot of sanitization to do in drivers in order to get rid of those mtd params, but I'll leave that to driver maintainers. Patch 2 is trying to get rid of 3 forward declarations that are not really needed. Patch 3 is getting rid of useless test in nand_legacy_set_defaults(). Patch 4 is making nand_exec_op() private, so that NAND controller drivers are not tempted to use it. Patch 5 is getting rid of an unused flag that has been around for quite some time. Patches 6 to 11 are doing various cleanups/fixes/improvements in the ams-delta driver. Patches 12 to 20 are deprecating the ->select_chip() hook which should now be replaced by internal target/die selection logic directly called from the ->exec_op() and ecc.read/write_xxx() implementations. The rational behind this change is that modern controller now take care of asserting/deasserting the CS pin on a per-operation basis, and if we ever want to implement advanced queuing logic (instead of the basic serialization we currently have) we'll have to attach a CS line to the operation we want to execute. Finally, patches 21 and 22 are moving the controller specific methods to nand_controller_ops. As usual, let me know what you think of those changes. Regards, Boris Main changes between v1 and v2: - Patch the ams-delta driver Main changes between v2 and v3: - Fix the bug reported by Janusz - Fix a bug reported by kbuild bots Boris Brezillon (22): mtd: rawnand: Stop passing mtd_info objects to internal functions mtd: rawnand: Reorganize code to avoid forward declarations mtd: rawnand: legacy: Drop useless test in nand_legacy_set_defaults() mtd: rawnand: Move nand_exec_op() to internal.h mtd: rawnand: Remove unused NAND_CONTROLLER_ALLOC flag mtd: rawnand: ams-delta: Allow this driver to be compiled when COMPILE_TEST=y mtd: rawnand: ams-delta: Add an SPDX tag to replace the license text mtd: rawnand: ams-delta: Fix various coding style issues mtd: rawnand: ams-delta: cleanup ams_delta_init() error path mtd: rawnand: ams-delta: Check mtd_device_register() return code mtd: rawnand: ams-delta: Explicitly inherit from nand_controller mtd: rawnand: Add nand_[de]select_target() helpers mtd: rawnand: Pass the CS line to be selected in struct nand_operation mtd: rawnand: Make ->select_chip() optional when ->exec_op() is implemented mtd: rawnand: fsmc: Stop implementing ->select_chip() mtd: rawnand: marvell: Stop implementing ->select_chip() mtd: rawnand: tegra: Stop implementing ->select_chip() mtd: rawnand: vf610: Stop implementing ->select_chip() mtd: rawnand: ams-delta: Stop implementing ->select_chip() mtd: rawnand: Deprecate the ->select_chip() hook mtd: rawnand: Move the ->exec_op() method to nand_controller_ops mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops drivers/mtd/nand/raw/Kconfig | 2 +- drivers/mtd/nand/raw/ams-delta.c | 95 ++- drivers/mtd/nand/raw/atmel/nand-controller.c | 9 +- drivers/mtd/nand/raw/au1550nd.c | 2 +- .../mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 2 +- drivers/mtd/nand/raw/cafe_nand.c | 2 +- drivers/mtd/nand/raw/davinci_nand.c | 2 +- drivers/mtd/nand/raw/denali.c | 5 +- drivers/mtd/nand/raw/diskonchip.c | 4 +- drivers/mtd/nand/raw/fsl_elbc_nand.c | 2 +- drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +- drivers/mtd/nand/raw/fsl_upm.c | 2 +- drivers/mtd/nand/raw/fsmc_nand.c | 32 +- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 27 +- drivers/mtd/nand/raw/hisi504_nand.c | 2 +- drivers/mtd/nand/raw/internals.h | 33 + drivers/mtd/nand/raw/jz4740_nand.c | 6 +- drivers/mtd/nand/raw/jz4780_nand.c | 2 +- drivers/mtd/nand/raw/marvell_nand.c | 32 +- drivers/mtd/nand/raw/mpc5121_nfc.c | 4 +- drivers/mtd/nand/raw/mtk_nand.c | 4 +- drivers/mtd/nand/raw/mxc_nand.c | 14 +- drivers/mtd/nand/raw/nand_base.c | 743 +++++++++--------- drivers/mtd/nand/raw/nand_bbt.c | 285 +++---- drivers/mtd/nand/raw/nand_hynix.c | 8 +- drivers/mtd/nand/raw/nand_legacy.c | 35 +- drivers/mtd/nand/raw/ndfc.c | 2 +- drivers/mtd/nand/raw/plat_nand.c | 2 +- drivers/mtd/nand/raw/qcom_nandc.c | 2 +- drivers/mtd/nand/raw/r852.c | 4 +- drivers/mtd/nand/raw/s3c2410.c | 7 +- drivers/mtd/nand/raw/sh_flctl.c | 2 +- drivers/mtd/nand/raw/sunxi_nand.c | 4 +- drivers/mtd/nand/raw/tango_nand.c | 4 +- drivers/mtd/nand/raw/tegra_nand.c | 32 +- drivers/mtd/nand/raw/vf610_nfc.c | 38 +- drivers/mtd/nand/raw/xway_nand.c | 2 +- include/linux/mtd/rawnand.h | 150 ++-- 38 files changed, 853 insertions(+), 752 deletions(-)