From patchwork Wed Jul 25 13:31:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 949182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cH2GP65U"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41bGPN1X6pz9s3x for ; Wed, 25 Jul 2018 23:32:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EJTvU78T41LRb5L9L0rO6naOG2PqnWluVSkAl326NHI=; b=cH2GP65Unvj7t4 D7+YT1XWJWZroVbo2j3yMWz/snII8QEEWVS4bMG1pH1gDHbZYakR7Oxj9URy+QKnhD0O3Y55dq5ia +u7cWFE1QrOOvcimOQ3uzopYzqS92vHnetFeOIswTYZ6i7sxfzsro1NJv1ieu+xcFw5KhKvKstuxa ndj37aE3iJ2FOQHuXhOwZhg0EOknlAf5a+sWOWTPW85TRMhMvUw0VlBaX/ZeMearBXCtl7sSPNEGx wShR+v0Ti/8sAs5yDor4E+YGMWK7U0y12aNk0ZYV591PsDxvaKXmiLl3bLyIkUtjcdJ7a7r5sXa9b sdzl14qA1tw9kX6LcgyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiJu3-0000TZ-Hz; Wed, 25 Jul 2018 13:32:31 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiJtr-0000Iv-Df for linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:22 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id DACA42097A; Wed, 25 Jul 2018 15:32:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 86C38203EC; Wed, 25 Jul 2018 15:31:56 +0200 (CEST) From: Miquel Raynal To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut Subject: [PATCH v5 00/17] Allow dynamic allocations during NAND chip identification phase Date: Wed, 25 Jul 2018 15:31:35 +0200 Message-Id: <20180725133152.30898-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180725_063219_758127_F15D04E7 X-CRM114-Status: GOOD ( 19.46 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [62.4.15.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas Stach , Wenyou Yang , Josh Wu , Stefan Agner , linux-mtd@lists.infradead.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hello, This series make a quite deep change in the NAND framework. Until now, the NAND chip identification phase could be done in two manners from the controller driver perspective: 1/ Call nand_scan() or 1/ Call nand_scan_ident() 2/ Do some controller-dependent configuration 3/ Call nand_scan_tail(). The fact that the identifaction could be split in two operations involved that in the NAND framework, it was not possible to do any dynamic allocation without risking a memory leak. What if the core allocates a structure, then the driver between nand_scan_ident() and nand_scan_tail() decides it cannot handle the chip and errors out? The structure allocated by the core is lost: it is a memory leak. One solution could have been to add a nand_scan_ident_cleanup() function, but that would mean patching all the drivers anyway to make them call this function when something fails between nand_scan_ident() and nand_scan_tail(). To avoid this situation, we migrate all drivers to use nand_scan() in conjuction with the recently added hooks ->attach_chip() and ->detach_chip() that are part of the nand_controller structure operations. Drivers that need to tweak their configuration after nand_scan_ident() should implement it. Any dynamically allocated space in ->attach_chip() must be freed in the second hook: ->detach_chip(). The ->detach_chip() does not have to be called upon error in the controller driver probe function. The nand_cleanup() helper already exists for that and will do the call if needed. Of course, this helper must be called on error after a successful nand_scan(), just like before. Once all drivers not using nand_scan() are migrated, nand_scan_ident() and nand_scan_tail() are unexported and only available internally. A previous work [1] removed the ONFI/JEDEC parameter pages and instead allocated a nand_parameters structure in nand_chip, embedding both generic entries and ONFI-related ones. The deal was, once dynamic allocation possible, allocate in nand_scan_ident() the ONFI strcuture only if actually needed. This is done in the last patches. This series applies on top of nand/next. Thank you, Miquèl [1] http://lists.infradead.org/pipermail/linux-mtd/2018-March/079456.html Changes since v4: ================= * Applied patches have been trimmed out of the series. * Commit logs have been reworded a bit as suggested by Boris (done as well with applied commits). * Always assigned the controller operations where the controller structure was initialized. * brcmnand: moved the whole chunk between _ident() and _tail() in brcmnand_attach_chip(). * cafe: fixed the use of the useddma module parameter. * denali: removed kfree(denali->buf) from denali_remove() as it is already done in ->detach_chip(). * lpc32xx_mlc: moved the IRQ handling out of the ->attach_chip() callback. * txx9ndfmc: moved the block about ecc.size/bytes in txx9ndfmc_nand_scan() for more clarity. * atmel: moved all the code in atmel_nand_register() directly in atmel_nand_controller_add_nand() + renamed atmel_nand_unregister() into atmel_nand_controller_remove_nand(). * nand_scan_ident: move the check on maxchips in nand_scan_with_ids() and the comment about it in the kernel doc (will no run nand_scan_ident() if zero). * docg4: added a ->detach_chip() to fee the allocated BCH context. * jz4740: fixed the error path and added a patch to clarify the transition to nand_scan(). Also removed unneeded curly braces and removed useless pdev parameters from the driver private structure (added in this series). * core: moved the definition of nand_release() close to nand_cleanup() in rawnand.h while updating the comments. * micron: only check for the ->onfi pointer to be present, not the vendor revision which is redundant. Changes since v3: ================= * Constified all the nand_controller_ops structure definitions. * Fixed a build issue in fsl_elbc. * Added a patch in the core to prevent executing nand_scan_ident if maxchips is NULL. * Fixed the regression around the model name. * Used kstrdup to allocate the model. * The migration from char model[] to const char *model is done in a separate patch. Changes since v2: ================= * Rebased on top of nand/next. * Adapted all drivers to declare statically a nand_controller_ops structure and assign it in the probe(). * Added the migration of the tegra_nand.c driver. * Moved brcmnand controller ops affectation in the probe(). Changes since v1: ================= * Rebased on top of nand/next. * Light rewording of the cover letter about the possibility to have a nand_scan_ident_cleanup() function (just as example of how this series could have been done differently). * Changed the hooks to reside in the nand_hw_ctrl structure instead of being part of nand_ecc_ctrl as these hooks are more controller-related. Miquel Raynal (17): mtd: rawnand: brcmnand: convert driver to nand_scan() mtd: rawnand: cafe: convert driver to nand_scan() mtd: rawnand: lpc32xx_mlc: convert driver to nand_scan() mtd: rawnand: omap2: convert driver to nand_scan() mtd: rawnand: atmel: clarify NAND addition/removal paths mtd: rawnand: atmel: convert driver to nand_scan() mtd: rawnand: do not execute nand_scan_ident() if maxchips is zero mtd: rawnand: docg4: convert driver to nand_scan() mtd: rawnand: jz4740: fix probe function error path mtd: rawnand: jz4740: group nand_scan_{ident,tail} calls mtd: rawnand: jz4740: convert driver to nand_scan() mtd: rawnand: tegra: convert driver to nand_scan() mtd: rawnand: txx9ndfmc: clarify ECC parameters assignation mtd: rawnand: txx9ndfmc: convert driver to nand_scan() mtd: rawnand: do not export nand_scan_[ident|tail]() anymore mtd: rawnand: allocate model parameter dynamically mtd: rawnand: allocate dynamically ONFI parameters during detection drivers/mtd/nand/raw/atmel/nand-controller.c | 149 ++++---- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 63 ++-- drivers/mtd/nand/raw/cafe_nand.c | 135 ++++--- drivers/mtd/nand/raw/docg4.c | 70 ++-- drivers/mtd/nand/raw/jz4740_nand.c | 40 +- drivers/mtd/nand/raw/lpc32xx_mlc.c | 61 +-- drivers/mtd/nand/raw/nand_base.c | 134 ++++--- drivers/mtd/nand/raw/nand_micron.c | 6 +- drivers/mtd/nand/raw/nand_timings.c | 12 +- drivers/mtd/nand/raw/omap2.c | 533 +++++++++++++-------------- drivers/mtd/nand/raw/tegra_nand.c | 162 ++++---- drivers/mtd/nand/raw/txx9ndfmc.c | 32 +- include/linux/mtd/rawnand.h | 26 +- 13 files changed, 762 insertions(+), 661 deletions(-)