From patchwork Fri Jul 20 15:14:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 947036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VzZWNqca"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41XDyW317hz9s55 for ; Sat, 21 Jul 2018 01:17:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+vIXEN0uHuiPQ5jZo5lI+QeCIzmaBBXI5uKppLCngdI=; b=VzZWNqcajq/FJp QTuzy6naQwr1PHMe1uMw4f85Qx/hA9/Q5dLduLcEdHZBhPyq88HBQhMcrBa65eR0kf2mjYnZVf3WK oXn5VFNOTqGvpbXSiHxobdVyPYSv+XeqPq0Uvw0TBkXxmO0YAJlBit7Im6/MX0POBigSSWOi8eN5z IbEwCr/RPt1+8x8NM+Zj5Jzm/F4z5QB0JVsZARy0OYfsM2Q0VQUFDlMjKNgLbupLBBzXdt0Z0KNfc 71lrtF060K/Dl+SLfQckM+oL3fKtUHez5jE+ItG2QPg4uHn5vRvPuelBSJU7t7+jzQJEm1wGI4ZMD Q7Iint/cbwpbg1soDhdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgX9h-0007lx-GU; Fri, 20 Jul 2018 15:17:17 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgX8I-0006Bu-Mo; Fri, 20 Jul 2018 15:15:58 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 2F53A20993; Fri, 20 Jul 2018 17:15:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 7EA98203EC; Fri, 20 Jul 2018 17:15:28 +0200 (CEST) From: Miquel Raynal To: Wenyou Yang , Josh Wu , Tudor Ambarus , Boris Brezillon , Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner Subject: [PATCH v4 00/35] Allow dynamic allocations during NAND chip identification phase Date: Fri, 20 Jul 2018 17:14:52 +0200 Message-Id: <20180720151527.16038-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180720_081551_621329_32ACBD6B X-CRM114-Status: GOOD ( 18.12 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [62.4.15.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hello, This series make a quite deep change in the NAND framework. Until now, the NAND chip identification phase could be done in two manners from the controller driver perspective: 1/ Call nand_scan() or 1/ Call nand_scan_ident() 2/ Do some controller-dependent configuration 3/ Call nand_scan_tail(). The fact that the identifaction could be split in two operations involved that in the NAND framework, it was not possible to do any dynamic allocation without risking a memory leak. What if the core allocates a structure, then the driver between nand_scan_ident() and nand_scan_tail() decides it cannot handle the chip and errors out? The structure allocated by the core is lost: it is a memory leak. One solution could have been to add a nand_scan_ident_cleanup() function, but that would mean patching all the drivers anyway to make them call this function when something fails between nand_scan_ident() and nand_scan_tail(). To avoid this situation, we migrate all drivers to use nand_scan() in conjuction with the recently added hooks ->attach_chip() and ->detach_chip() that are part of the nand_controller structure operations. Drivers that need to tweak their configuration after nand_scan_ident() should implement it. Any dynamically allocated space in ->attach_chip() must be freed in the second hook: ->detach_chip(). The ->detach_chip() does not have to be called upon error in the controller driver probe function. The nand_cleanup() helper already exists for that and will do the call if needed. Of course, this helper must be called on error after a successful nand_scan(), just like before. Once all drivers not using nand_scan() are migrated, nand_scan_ident() and nand_scan_tail() are unexported and only available internally. A previous work [1] removed the ONFI/JEDEC parameter pages and instead allocated a nand_parameters structure in nand_chip, embedding both generic entries and ONFI-related ones. The deal was, once dynamic allocation possible, allocate in nand_scan_ident() the ONFI strcuture only if actually needed. This is done in the last patches. This series applies on top of nand/next. Thank you, Miquèl [1] http://lists.infradead.org/pipermail/linux-mtd/2018-March/079456.html Changes since v3: ================= * Constified all the nand_controller_ops structure definitions. * Fixed a build issue in fsl_elbc. * Added a patch in the core to prevent executing nand_scan_ident if maxchips is NULL. * Fixed the regression around the model name. * Used kstrdup to allocate the model. * The migration from char model[] to const char *model is done in a separate patch. Changes since v2: ================= * Rebased on top of nand/next. * Adapted all drivers to declare statically a nand_controller_ops structure and assign it in the probe(). * Added the migration of the tegra_nand.c driver. * Moved brcmnand controller ops affectation in the probe(). Changes since v1: ================= * Rebased on top of nand/next. * Light rewording of the cover letter about the possibility to have a nand_scan_ident_cleanup() function (just as example of how this series could have been done differently). * Changed the hooks to reside in the nand_hw_ctrl structure instead of being part of nand_ecc_ctrl as these hooks are more controller-related. Miquel Raynal (35): mtd: rawnand: brcmnand: convert driver to nand_scan() mtd: rawnand: cafe: convert driver to nand_scan() mtd: rawnand: davinci: convert driver to nand_scan() mtd: rawnand: denali: convert to nand_scan() mtd: rawnand: fsl_elbc: convert driver to nand_scan() mtd: rawnand: fsl_ifc: convert driver to nand_scan() mtd: rawnand: fsmc: convert driver to nand_scan() mtd: rawnand: gpmi: convert driver to nand_scan() mtd: rawnand: hisi504: convert driver to nand_scan() mtd: rawnand: jz4780: convert driver to nand_scan() mtd: rawnand: lpc32xx_mlc: convert driver to nand_scan() mtd: rawnand: lpc32xx_slc: convert driver to nand_scan() mtd: rawnand: marvell: convert driver to nand_scan() mtd: rawnand: mtk: convert driver to nand_scan() mtd: rawnand: mxc: convert driver to nand_scan() mtd: rawnand: nandsim: convert driver to nand_scan() mtd: rawnand: omap2: convert driver to nand_scan() mtd: rawnand: s3c2410: convert driver to nand_scan() mtd: rawnand: sh_flctl: move all NAND chip related setup in one function mtd: rawnand: sh_flctl: convert driver to nand_scan() mtd: rawnand: sunxi: convert driver to nand_scan() mtd: rawnand: tango: convert driver to nand_scan() mtd: rawnand: txx9ndfmc: rename nand controller internal structure mtd: rawnand: txx9ndfmc: convert driver to nand_scan() mtd: rawnand: vf610: convert driver to nand_scan() mtd: rawnand: atmel: convert driver to nand_scan() mtd: rawnand: sm_common: convert driver to nand_scan_with_ids() mtd: rawnand: allow exiting immediately nand_scan_ident() mtd: rawnand: docg4: convert driver to nand_scan() mtd: rawnand: qcom: convert driver to nand_scan() mtd: rawnand: jz4740: convert driver to nand_scan() mtd: rawnand: tegra: convert driver to nand_scan() mtd: rawnand: do not export nand_scan_[ident|tail]() anymore mtd: rawnand: allocate model parameter dynamically mtd: rawnand: allocate dynamically ONFI parameters during detection drivers/mtd/nand/raw/atmel/nand-controller.c | 83 ++--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 47 ++- drivers/mtd/nand/raw/cafe_nand.c | 130 ++++--- drivers/mtd/nand/raw/davinci_nand.c | 195 +++++----- drivers/mtd/nand/raw/denali.c | 138 +++---- drivers/mtd/nand/raw/docg4.c | 55 +-- drivers/mtd/nand/raw/fsl_elbc_nand.c | 19 +- drivers/mtd/nand/raw/fsl_ifc_nand.c | 19 +- drivers/mtd/nand/raw/fsmc_nand.c | 148 ++++---- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 56 +-- drivers/mtd/nand/raw/hisi504_nand.c | 78 ++-- drivers/mtd/nand/raw/jz4740_nand.c | 46 ++- drivers/mtd/nand/raw/jz4780_nand.c | 34 +- drivers/mtd/nand/raw/lpc32xx_mlc.c | 109 +++--- drivers/mtd/nand/raw/lpc32xx_slc.c | 77 ++-- drivers/mtd/nand/raw/marvell_nand.c | 205 ++++++----- drivers/mtd/nand/raw/mtk_nand.c | 75 ++-- drivers/mtd/nand/raw/mxc_nand.c | 136 +++---- drivers/mtd/nand/raw/nand_base.c | 132 +++++-- drivers/mtd/nand/raw/nand_micron.c | 6 +- drivers/mtd/nand/raw/nand_timings.c | 12 +- drivers/mtd/nand/raw/nandsim.c | 82 +++-- drivers/mtd/nand/raw/omap2.c | 521 +++++++++++++-------------- drivers/mtd/nand/raw/qcom_nandc.c | 71 ++-- drivers/mtd/nand/raw/s3c2410.c | 30 +- drivers/mtd/nand/raw/sh_flctl.c | 57 ++- drivers/mtd/nand/raw/sm_common.c | 39 +- drivers/mtd/nand/raw/sunxi_nand.c | 43 +-- drivers/mtd/nand/raw/tango_nand.c | 40 +- drivers/mtd/nand/raw/tegra_nand.c | 162 +++++---- drivers/mtd/nand/raw/txx9ndfmc.c | 35 +- drivers/mtd/nand/raw/vf610_nfc.c | 127 +++---- include/linux/mtd/rawnand.h | 17 +- include/linux/mtd/sh_flctl.h | 1 + 34 files changed, 1612 insertions(+), 1413 deletions(-)