| Message ID | 20180515171120.5629-1-smtpuser@allied-telesis.co.jp |
|---|---|
| Headers | show |
| Series | mtd: cfi_cmdset_0002: Change write and erase functions | expand |
I think the patches look good but I think they should go to stable as well. Jocke On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote: > > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > The changes are to make sure to check the operation status. > Actually the flash write and erase error behavior is caused on our products. > The flash is Macronix flash device MX29GL512FHT2I-11G used by our products. > The patch series was separated for changes of flash write and erase. > Since those were not depended each other at the time. > But by additional changes the changes are related more as same way currently. > So combine patch series for the flash write and erase changes as v6. > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Cc: Brian Norris <computersforpeace@gmail.com> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > Cc: Marek Vasut <marek.vasut@gmail.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> > Cc: linux-mtd@lists.infradead.org > > Tokunori Ikegami (5): > mtd: cfi_cmdset_0002: Change write buffer to check correct value > mtd: cfi_cmdset_0002: Change definition naming to retry write > operation > mtd: cfi_cmdset_0002: Change erase functions to retry for error > mtd: cfi_cmdset_0002: Change erase functions to check chip good only > mtd: cfi_cmdset_0002: Change erase one block to enable XIP once > > drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++------------- > 1 file changed, 23 insertions(+), 13 deletions(-) > > -- > 2.16.1 >
Hi Boris-san, Could you please apply the patches if no problem? Or still should we wait if any other comment? Let me confirm these things since we are waiting to apply them for our product problem as resolution. By the way I think that the commit message of patches can be changed to Jocke-san as "Reviewed-by" from "Cc" as below. - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> Since actually the changes have been reviewed by him as the mail below. Also our company mail system has been changed so now I can send the patches with my email address as sender instead of the smtpuser address. If needed I will resend patches or send them as new version patches again to change the commit message and send address. Regards, Ikegami > -----Original Message----- > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com] > Sent: Thursday, May 17, 2018 10:12 PM > To: boris.brezillon@bootlin.com > Cc: IKEGAMI Tokunori; PACKHAM Chris; linux-mtd@lists.infradead.org; > cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org; > computersforpeace@gmail.com; boris.brezillon@free-electrons.com; > richard@nod.at; marek.vasut@gmail.com > Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase > functions > > I think the patches look good but I think they should go > to stable as well. > > Jocke > > On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote: > > > > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > > > The changes are to make sure to check the operation status. > > Actually the flash write and erase error behavior is caused on our > products. > > The flash is Macronix flash device MX29GL512FHT2I-11G used by our > products. > > The patch series was separated for changes of flash write and erase. > > Since those were not depended each other at the time. > > But by additional changes the changes are related more as same way > currently. > > So combine patch series for the flash write and erase changes as v6. > > > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > > Cc: Brian Norris <computersforpeace@gmail.com> > > Cc: David Woodhouse <dwmw2@infradead.org> > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > > Cc: Marek Vasut <marek.vasut@gmail.com> > > Cc: Richard Weinberger <richard@nod.at> > > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> > > Cc: linux-mtd@lists.infradead.org > > > > Tokunori Ikegami (5): > > mtd: cfi_cmdset_0002: Change write buffer to check correct value > > mtd: cfi_cmdset_0002: Change definition naming to retry write > > operation > > mtd: cfi_cmdset_0002: Change erase functions to retry for error > > mtd: cfi_cmdset_0002: Change erase functions to check chip good only > > mtd: cfi_cmdset_0002: Change erase one block to enable XIP once > > > > drivers/mtd/chips/cfi_cmdset_0002.c | 36 > +++++++++++++++++++++++------------- > > 1 file changed, 23 insertions(+), 13 deletions(-) > > > > -- > > 2.16.1 > >
Hi Ikgegami-san, On 25/05/18 15:03, IKEGAMI Tokunori wrote: > Hi Boris-san, > > Could you please apply the patches if no problem? > Or still should we wait if any other comment? Probably best to let the world turn for a bit longer. I imagine most of the Linux subsystem maintainers are busy with the last stage of the merge window for 4.17. > Let me confirm these things since we are waiting to apply them for > our product problem as resolution. I think things are far enough along now that we can apply these to our kernel fork. If there are any new changes we can always revert and apply updated versions. > By the way I think that the commit message of patches can be changed > to Jocke-san as "Reviewed-by" from "Cc" as below. > - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > Since actually the changes have been reviewed by him as the mail > below. > Also our company mail system has been changed so now I can send the > patches with my email address as sender instead of the smtpuser address. > If needed I will resend patches or send them as new version patches > again to change the commit message and send address. > > Regards, > Ikegami > >> -----Original Message----- >> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com] >> Sent: Thursday, May 17, 2018 10:12 PM >> To: boris.brezillon@bootlin.com >> Cc: IKEGAMI Tokunori; PACKHAM Chris; linux-mtd@lists.infradead.org; >> cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org; >> computersforpeace@gmail.com; boris.brezillon@free-electrons.com; >> richard@nod.at; marek.vasut@gmail.com >> Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase >> functions >> >> I think the patches look good but I think they should go >> to stable as well. >> >> Jocke >> >> On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote: >>> >>> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp> >>> >>> The changes are to make sure to check the operation status. >>> Actually the flash write and erase error behavior is caused on our >> products. >>> The flash is Macronix flash device MX29GL512FHT2I-11G used by our >> products. >>> The patch series was separated for changes of flash write and erase. >>> Since those were not depended each other at the time. >>> But by additional changes the changes are related more as same way >> currently. >>> So combine patch series for the flash write and erase changes as v6. >>> >>> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> >>> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> >>> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> >>> Cc: Brian Norris <computersforpeace@gmail.com> >>> Cc: David Woodhouse <dwmw2@infradead.org> >>> Cc: Boris Brezillon <boris.brezillon@free-electrons.com> >>> Cc: Marek Vasut <marek.vasut@gmail.com> >>> Cc: Richard Weinberger <richard@nod.at> >>> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> >>> Cc: linux-mtd@lists.infradead.org >>> >>> Tokunori Ikegami (5): >>> mtd: cfi_cmdset_0002: Change write buffer to check correct value >>> mtd: cfi_cmdset_0002: Change definition naming to retry write >>> operation >>> mtd: cfi_cmdset_0002: Change erase functions to retry for error >>> mtd: cfi_cmdset_0002: Change erase functions to check chip good only >>> mtd: cfi_cmdset_0002: Change erase one block to enable XIP once >>> >>> drivers/mtd/chips/cfi_cmdset_0002.c | 36 >> +++++++++++++++++++++++------------- >>> 1 file changed, 23 insertions(+), 13 deletions(-) >>> >>> -- >>> 2.16.1 >>> >
Hi Chris-san, Thank you so much for your advice. > Probably best to let the world turn for a bit longer. I imagine most of > the Linux subsystem maintainers are busy with the last stage of the > merge window for 4.17. I see so I will wait more. > I think things are far enough along now that we can apply these to our > kernel fork. If there are any new changes we can always revert and apply > updated versions. Okay I will send the patches to you separately to apply to our kernel fork. Regards, Ikegami
Hi Joakim, On Thu, 17 May 2018 13:12:26 +0000 Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote: > I think the patches look good Should I add your Reviewed-by tag (maybe Tested-by as well)? > but I think they should go to stable as well. Then I'll need a v7 with the "Cc: stable@vger.kernel.org" tag. Also, some patches are clearly not fixes (patch 2 and 5 at least). Regards, Boris > > Jocke > > On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote: > > > > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > > > The changes are to make sure to check the operation status. > > Actually the flash write and erase error behavior is caused on our products. > > The flash is Macronix flash device MX29GL512FHT2I-11G used by our products. > > The patch series was separated for changes of flash write and erase. > > Since those were not depended each other at the time. > > But by additional changes the changes are related more as same way currently. > > So combine patch series for the flash write and erase changes as v6. > > > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > > Cc: Brian Norris <computersforpeace@gmail.com> > > Cc: David Woodhouse <dwmw2@infradead.org> > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > > Cc: Marek Vasut <marek.vasut@gmail.com> > > Cc: Richard Weinberger <richard@nod.at> > > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> > > Cc: linux-mtd@lists.infradead.org > > > > Tokunori Ikegami (5): > > mtd: cfi_cmdset_0002: Change write buffer to check correct value > > mtd: cfi_cmdset_0002: Change definition naming to retry write > > operation > > mtd: cfi_cmdset_0002: Change erase functions to retry for error > > mtd: cfi_cmdset_0002: Change erase functions to check chip good only > > mtd: cfi_cmdset_0002: Change erase one block to enable XIP once > > > > drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++------------- > > 1 file changed, 23 insertions(+), 13 deletions(-) > > > > -- > > 2.16.1 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Fri, 25 May 2018 03:03:28 +0000 IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote: > Hi Boris-san, > > Could you please apply the patches if no problem? Actually I never received your v6, and I can't find it in linux-mtd either. Interestingly, it's in patchwork, so maybe a problem on my side. > Or still should we wait if any other comment? Not really, maybe add the Cc:stable tag if you think this is needed. > Let me confirm these things since we are waiting to apply them for our product problem as resolution. > > By the way I think that the commit message of patches can be changed to Jocke-san as "Reviewed-by" from "Cc" as below. > - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > Since actually the changes have been reviewed by him as the mail below. Normally you should wait for an official "Reviewed-by" tag. I just asked Joakim. > Also our company mail system has been changed so now I can send the patches with my email address as sender instead of the smtpuser address. That's appreciated. > If needed I will resend patches or send them as new version patches again to change the commit message and send address. Yes please, send a new version. Thanks, Boris
On Sun, 2018-05-27 at 17:33 +0200, Boris Brezillon wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > Hi Joakim, > > On Thu, 17 May 2018 13:12:26 +0000 > Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote: > > > I think the patches look good > > Should I add your Reviewed-by tag (maybe Tested-by as well)? I have only reviewed them so add a: Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > but I think they should go to stable as well. > > Then I'll need a v7 with the "Cc: stable@vger.kernel.org" tag. Also, > some patches are clearly not fixes (patch 2 and 5 at least). But they are all needed as the fixes builds upon them? So all go to stable I think. > > Regards, > > Boris > > > > > Jocke > > > > On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote: > > > > > > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > > > > > The changes are to make sure to check the operation status. > > > Actually the flash write and erase error behavior is caused on our products. > > > The flash is Macronix flash device MX29GL512FHT2I-11G used by our products. > > > The patch series was separated for changes of flash write and erase. > > > Since those were not depended each other at the time. > > > But by additional changes the changes are related more as same way currently. > > > So combine patch series for the flash write and erase changes as v6. > > > > > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > > > Cc: Brian Norris <computersforpeace@gmail.com> > > > Cc: David Woodhouse <dwmw2@infradead.org> > > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > > > Cc: Marek Vasut <marek.vasut@gmail.com> > > > Cc: Richard Weinberger <richard@nod.at> > > > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> > > > Cc: linux-mtd@lists.infradead.org > > > > > > Tokunori Ikegami (5): > > > mtd: cfi_cmdset_0002: Change write buffer to check correct value > > > mtd: cfi_cmdset_0002: Change definition naming to retry write > > > operation > > > mtd: cfi_cmdset_0002: Change erase functions to retry for error > > > mtd: cfi_cmdset_0002: Change erase functions to check chip good only > > > mtd: cfi_cmdset_0002: Change erase one block to enable XIP once > > > > > > drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++------------- > > > 1 file changed, 23 insertions(+), 13 deletions(-) > > > > > > -- > > > 2.16.1 > > > > > > > ______________________________________________________ > > Linux MTD discussion mailing list > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > >
Hi Boris-san, Yes I have just sent v7 version patches so please review them. Regards, Ikegami > -----Original Message----- > From: Boris Brezillon [mailto:boris.brezillon@bootlin.com] > Sent: Monday, May 28, 2018 12:39 AM > To: IKEGAMI Tokunori > Cc: Joakim Tjernlund; PACKHAM Chris; linux-mtd@lists.infradead.org; > cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org; > computersforpeace@gmail.com; boris.brezillon@free-electrons.com; > richard@nod.at; marek.vasut@gmail.com > Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase > functions > > On Fri, 25 May 2018 03:03:28 +0000 > IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote: > > > Hi Boris-san, > > > > Could you please apply the patches if no problem? > > Actually I never received your v6, and I can't find it in linux-mtd > either. Interestingly, it's in patchwork, so maybe a problem on my side. > > > Or still should we wait if any other comment? > > Not really, maybe add the Cc:stable tag if you think this is needed. > > > Let me confirm these things since we are waiting to apply them for our > product problem as resolution. > > > > By the way I think that the commit message of patches can be changed to > Jocke-san as "Reviewed-by" from "Cc" as below. > > - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > Since actually the changes have been reviewed by him as the mail below. > > Normally you should wait for an official "Reviewed-by" tag. I just > asked Joakim. > > > Also our company mail system has been changed so now I can send the patches > with my email address as sender instead of the smtpuser address. > > That's appreciated. > > > If needed I will resend patches or send them as new version patches again > to change the commit message and send address. > > Yes please, send a new version. > > Thanks, > > Boris