From patchwork Fri Jan 12 14:40:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 859976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q1y8pO+S"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="O0Hx34TE"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zJ55z5YFGz9sNw for ; Sat, 13 Jan 2018 01:41:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1l4/6AlFlMPtAdnX6EJ9Xy0nYJmeIUnF/b/FGyLr+yc=; b=q1y8pO+SXbaOaP UPX7+wsoUXeUVXiTqaNSl3uGkASemhy2TARgPOxA4ORycd0cI7MA49vga/sZdDO5PIOqepXrRr42y b5p2CQOO1nl4nDD1hhKf7Wpj+l2Sm5TmdE4IwAo6svwpOCvZHoa19BZ4ITcM6uSfssus3UuN3wiZY oyEUFLvd0xAbQGlu5cl5WQQbhh+Pfurf5AD8sxd0TFyunUk1msEu16X7VqDSwl7wEzSR4bHkpbUe6 ZDavJVToVtU2Fmui2WPu79Vk+0gH6zxSRriZbsVHZZnl+1Ymxb1bU1cb3lc1DbzEqGRfAcW6PlFkU chLcnt1wlwuUbvKdrLmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ea0W3-0006rB-C0; Fri, 12 Jan 2018 14:41:07 +0000 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ea0Vz-0006YQ-Cj for linux-mtd@lists.infradead.org; Fri, 12 Jan 2018 14:41:05 +0000 Received: by mail-lf0-x242.google.com with SMTP id h137so6174271lfe.8 for ; Fri, 12 Jan 2018 06:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=caeOSL9Urj0zBm5wy9YikMK7lvKatvaNWdRSuixgDNg=; b=O0Hx34TEI0woFP4SUHDKyCuR1uHu4rSAWrsputZN0OGX7+zm3X11D/8aw522jWi5GW yjOVW4++vsqB0SpvLv0OUYizHvl2X14T+8wwYLFXY5dJH8Ft02Z2bJOC5NkaPpzbnaUB nMJLvWm8fheoGuCG6sQVEfXP0EOpRkyAqFVly9VI0IyHMKOum7pg2kM7u/i6BdMO1U6H EX8NBfU61xeQELp/JEZ3CGjzGftuCFl27xMDzGtONr1R9rYcEjifWn30ih3+V2ykGU0y mbm/cxDlJSEYSEWvvluMyNf31l/Jj2h5cDn9ofwCEdDnaNLjsa6TQLKU8ZwwomrWKwkP +dWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=caeOSL9Urj0zBm5wy9YikMK7lvKatvaNWdRSuixgDNg=; b=eteGEs7e8PP2wnll2Bafdgt7ef7JnmB361q+0BKBfgDv9c4CF2Afvl5SImGWrDVhgG JUoVHD6qxXbtL/L4Q4YjVq6crhQLTR4fQkwTF4HhFxW4w/pyRNzIZZ81DH1nw805jxPK GZhjR7npYL5cU4dlsBczn/ULaj57JEBGQtXKuMttbJTjvtPh0jinp7HPlxSvD58kYekz m/3qfSVwVs+27r1FJmxqYlhfjXlFr5nF0lXTrrLAdx5cdL2a3xs9WbbGmk2lL8Yaa/I/ e1AWITmZ+gjDOGuirC7hyA0XW9xG4Sf3uSJR8zcs6PlVXl89VocZTQplrtkL03EHIAw6 cHPg== X-Gm-Message-State: AKwxyte/DDaVdy+WgVQ4zHFUQmfI4Ppw/GL8m5fYtuRt7LNhQCBbWtB0 sv5XCsaJBQw8oy9rv7wXBuo= X-Google-Smtp-Source: ACJfBovDezCUVTa2e1CsBS2cgfgY2jUs2LncpsawvXLcHNsB+V81UJXUDNuWlV1r/RX+0/ogYl3flQ== X-Received: by 10.46.44.20 with SMTP id s20mr2173767ljs.72.1515768049776; Fri, 12 Jan 2018 06:40:49 -0800 (PST) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id e72sm4400469lji.63.2018.01.12.06.40.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2018 06:40:49 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Brian Norris , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen Subject: [PATCH 0/2] mtd: simplify mtd_device_parse_register code Date: Fri, 12 Jan 2018 15:40:32 +0100 Message-Id: <20180112144034.6655-1-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180112_064103_464757_47661748 X-CRM114-Status: GOOD ( 12.84 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:4010:c07:0:0:0:242 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , linux-mtd@lists.infradead.org, Jonas Gorski Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Rafał Miłecki Even though I have some experience with MTD subsystem every time I was starting working on it I had to do some quick research on the code flow. I think there is some place for cleanup and optimization that would simplify overall code and allow new developers to start working on it more easily. In these patches I meant to slightly simplify mtd_device_parse_register function. I think we could reduce amount of add/register/del functions and this is the first step for that. Ideally I think mtdcore.c shouldn't handle parsing but just use a single function from mtdpart.c. Patch 1/2 modifies code to make sure parsing code is not mixed with MTD master code. This should allow moving parsing parts to the mtdpart.c in the future. Patch 2/2 simplifies code and makes sure parsing is handled at 1 place only. Even though this cleanup isn't complete I think it already has some value and could be accepted (if there won't be objections) on its own. It's also quite small which should allow reviewing it easily. Rafał Miłecki (2): mtd: move code adding master MTD out of mtd_add_device_partitions mtd: get rid of the mtd_add_device_partitions function drivers/mtd/mtdcore.c | 45 +++++++++++++++------------------------------ 1 file changed, 15 insertions(+), 30 deletions(-)