From patchwork Tue Aug 29 10:17:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Lothar_Wa=C3=9Fmann?= X-Patchwork-Id: 807024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s5c9JjDJ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xhPjw1Vhcz9t16 for ; Tue, 29 Aug 2017 20:18:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wgxQ05cA7BSdTpdLnCUwe63540tV9UYyjrxMAWDVOE4=; b=s5c9JjDJJC4v+9 s9VJPs0bzkoC4Ctbyc1+0h8LHEyaA818Nkv/cWywD1UapAg04vDcH8Xad08ywIz5n1iV9em1qQv+m rTqRYcOpZRZzCj55KYqX2yIGZNn8ae9MCk72mig/YYdzxJhR02nH5BYsFnx8CHuK0O3epwTYgYR/Y ltYALZ/6KYtO48fS0kNYSX4FvxScaomycrxpdx9rlU1eb9D5ZNBg7UbOGPf3NdJjBoWuOvFY+eABh JnF1CAZQ3OIKrJUWRKDi3DZG/P+LE6nDHMxGkPmv8ktYJ2CmYS/gvWDgVNvi4BQ6k80sV3N+9u6Xm 9vbONDjlEowbL4ScYJmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dmdbN-0002SV-87; Tue, 29 Aug 2017 10:18:33 +0000 Received: from smtprelay01.ispgateway.de ([80.67.18.13]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dmdas-000257-Hy for linux-mtd@lists.infradead.org; Tue, 29 Aug 2017 10:18:07 +0000 Received: from [89.1.81.74] (helo=ipc1.ka-ro) by smtprelay01.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1dmdaR-0005nn-Ef; Tue, 29 Aug 2017 12:17:35 +0200 Received: from lothar by ipc1.ka-ro with local (Exim 4.84_2 #2 (Debian)) id 1dmdaR-0004id-20; Tue, 29 Aug 2017 12:17:35 +0200 From: =?utf-8?q?Lothar_Wa=C3=9Fmann?= To: Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code Date: Tue, 29 Aug 2017 12:17:11 +0200 Message-Id: <1504001833-18097-1-git-send-email-LW@KARO-electronics.de> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170829_031803_504595_0F1DA623 X-CRM114-Status: UNSURE ( 5.41 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [80.67.18.13 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [80.67.18.13 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection logic in nand_samsung.c") introduced a regression for Samsung SLC NAND chips by skipping the initialization of chip->bits_per_cell that is done in nand_decode_ext_id() from which the manufacturer dependent code was extracted. The regression should also affect Hynix and Macronix chips whose code was separated out in further commits but which I cannot test. AMD/Spansion and Toshiba NAND are not affected, since they are calling nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their .detect function. Fix the regression and add a warning to nand_is_slc() to prevent further regressions of this kind.