mbox

[GIT,PULL,2/3] omap gpmc changes for v3.19

Message ID pull-1415814409-868361-2
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/gpmc-timings

Message

Tony Lindgren Nov. 12, 2014, 6:05 p.m. UTC
The following changes since commit 24f284af1a64a1a073b064428cafb447aff19a21:

  ARM: dts: Fix missing GPMC NAND device width for omap3 boards (2014-11-03 17:42:16 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/gpmc-timings

for you to fetch changes up to 6f8782a7a1c826e1c013d6b7d5504af6bcc079e6:

  ARM: OMAP2+: Remove unnecesary include in GPMC driver (2014-11-06 10:51:06 -0800)

----------------------------------------------------------------
GPMC (General Purpose Memory Controller) changes for omaps. These
changes allow us to drop dependencies to bootloader timings now
that the known device tree entries have been fixed. So we can now
require proper timings to be configured and get rid of the legacy
smsc91x code.

Note that this branch has a dependency to the related device tree
branch sent in a separate pull request as timings are now required.

----------------------------------------------------------------
Javier Martinez Canillas (1):
      ARM: OMAP2+: Remove unnecesary include in GPMC driver

Roger Quadros (5):
      ARM: OMAP2+: gpmc: Print error message in set_gpmc_timing_reg()
      ARM: OMAP2+: gpmc: Error out if timings fail in gpmc_probe_generic_child()
      ARM: OMAP2+: gpmc: Always enable A26-A11 for non NAND devices
      ARM: OMAP2+: gpmc: Keep Chip Select disabled while configuring it
      ARM: OMAP2+: gpmc: Sanity check GPMC fck on probe

Tony Lindgren (5):
      ARM: OMAP2+: Fix support for multiple devices on a GPMC chip select
      ARM: OMAP2+: Show bootloader GPMC timings to allow configuring the .dts file
      ARM: OMAP2+: Require proper GPMC timings for devices
      ARM: OMAP2+: Drop legacy code for gpmc-smc91x.c
      Merge branch 'for-v3.19/gpmc-omap' of github.com:rogerq/linux into omap-for-v3.19/gpmc

 arch/arm/mach-omap2/Makefile                 |   3 -
 arch/arm/mach-omap2/board-3430sdp.c          |  28 ---
 arch/arm/mach-omap2/board-rx51-peripherals.c |  29 ---
 arch/arm/mach-omap2/gpmc-smc91x.c            | 186 -----------------
 arch/arm/mach-omap2/gpmc-smc91x.h            |  42 ----
 arch/arm/mach-omap2/gpmc.c                   | 295 +++++++++++++++++++++------
 6 files changed, 237 insertions(+), 346 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/gpmc-smc91x.c
 delete mode 100644 arch/arm/mach-omap2/gpmc-smc91x.h

Comments

Arnd Bergmann Nov. 20, 2014, 11:02 a.m. UTC | #1
On Wednesday 12 November 2014, Tony Lindgren wrote:
> GPMC (General Purpose Memory Controller) changes for omaps. These
> changes allow us to drop dependencies to bootloader timings now
> that the known device tree entries have been fixed. So we can now
> require proper timings to be configured and get rid of the legacy
> smsc91x code.
> 
> Note that this branch has a dependency to the related device tree
> branch sent in a separate pull request as timings are now required.

Does this mean you are breaking compatibility with old dtb files?

Can you be more specific which machines are affected?

	Arnd
Tony Lindgren Nov. 20, 2014, 4:08 p.m. UTC | #2
* Arnd Bergmann <arnd@arndb.de> [141120 03:04]:
> On Wednesday 12 November 2014, Tony Lindgren wrote:
> > GPMC (General Purpose Memory Controller) changes for omaps. These
> > changes allow us to drop dependencies to bootloader timings now
> > that the known device tree entries have been fixed. So we can now
> > require proper timings to be configured and get rid of the legacy
> > smsc91x code.
> > 
> > Note that this branch has a dependency to the related device tree
> > branch sent in a separate pull request as timings are now required.
> 
> Does this mean you are breaking compatibility with old dtb files?
> 
> Can you be more specific which machines are affected?

Not breaking compability. We had timings missing in the .dts files
for a few devices that caused all kinds of hacks in the GPMC code.

Now those are all fixed up and we are actually using the bindings.

Regards,

Tony
Tony Lindgren Nov. 20, 2014, 4:25 p.m. UTC | #3
* Tony Lindgren <tony@atomide.com> [141120 08:11]:
> * Arnd Bergmann <arnd@arndb.de> [141120 03:04]:
> > On Wednesday 12 November 2014, Tony Lindgren wrote:
> > > GPMC (General Purpose Memory Controller) changes for omaps. These
> > > changes allow us to drop dependencies to bootloader timings now
> > > that the known device tree entries have been fixed. So we can now
> > > require proper timings to be configured and get rid of the legacy
> > > smsc91x code.
> > > 
> > > Note that this branch has a dependency to the related device tree
> > > branch sent in a separate pull request as timings are now required.
> > 
> > Does this mean you are breaking compatibility with old dtb files?
> > 
> > Can you be more specific which machines are affected?
> 
> Not breaking compability. We had timings missing in the .dts files
> for a few devices that caused all kinds of hacks in the GPMC code.

Hmm actually I take it back, this is breaking compability for booting
with old .dtb for smc91x on 2430sdp and 8250 on zoom3. In those cases
these devices would now refuse to probe because of the missing
timings because of the extra checks in the GPMC code.

However, these two boards are only used in three automated build and
boot test systems AFAIK. And almost certainly they are using appended
dtb anyways because of the lack of support for them in current
u-boot.
 
> Now those are all fixed up and we are actually using the bindings.

For reference, the .dts files with missing timings were smc91x on
omap2430-sdp.dts 8250 in omap-zoom-common.dtsi. So the dependencies
are:

b5399ea8453a ("ARM: dts: Add GPMC timings for omap zoom serial port")
1bb37404397d ("ARM: dts: Add smc91x GPMC configuration for 2430sdp")

Regards,

Tony