| Message ID | m3sfxen0yw.fsf@t19.piap.pl |
|---|---|
| State | New |
| Headers | show |
| Series | CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo | expand |
Hello Krzysztof, On 06.10.21 08:04, Krzysztof Hałasa wrote: > Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite" > for SOC_IMX6Q. If you think enumerating all variants is worthwhile, you should probably be adding normal Dual (Quad, but with only 2 cores) as well. > Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index b407b024dde3..b6f2f2ea8e65 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -143,7 +143,7 @@ config SOC_IMX6 > select PL310_ERRATA_769419 if CACHE_L2X0 > > config SOC_IMX6Q > - bool "i.MX6 Quad/DualLite support" > + bool "i.MX6 Quad/DualLite/Solo support" > select ARM_ERRATA_764369 if SMP > select ARM_ERRATA_754322 > select ARM_ERRATA_775420 > @@ -153,7 +153,7 @@ config SOC_IMX6Q > select SOC_IMX6 > > help > - This enables support for Freescale i.MX6 Quad processor. > + This enables support for Freescale i.MX6 Quad/DualLite/Solo processors. > > config SOC_IMX6SL > bool "i.MX6 SoloLite support" > diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c > index 11dcc369ec14..8cc8a2ed1d12 100644 > --- a/arch/arm/mach-imx/mach-imx6q.c > +++ b/arch/arm/mach-imx/mach-imx6q.c > @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = { > NULL, > }; > > -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)") > +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)") > .l2c_aux_val = 0, > .l2c_aux_mask = ~0, > .smp = smp_ops(imx_smp_ops), >
Am Mittwoch, dem 06.10.2021 um 08:04 +0200 schrieb Krzysztof Hałasa: > Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite" > for SOC_IMX6Q. > I don't think that's helpful, you would need to at least also print "Dual" to make it correct. The Solo is just a fused down version of the DualLite, just as the Dual is a fused down version of the Quad. Quad/DualLite refers to the two different die versions of the chip. Regards, Lucas > Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index b407b024dde3..b6f2f2ea8e65 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -143,7 +143,7 @@ config SOC_IMX6 > select PL310_ERRATA_769419 if CACHE_L2X0 > > config SOC_IMX6Q > - bool "i.MX6 Quad/DualLite support" > + bool "i.MX6 Quad/DualLite/Solo support" > select ARM_ERRATA_764369 if SMP > select ARM_ERRATA_754322 > select ARM_ERRATA_775420 > @@ -153,7 +153,7 @@ config SOC_IMX6Q > select SOC_IMX6 > > help > - This enables support for Freescale i.MX6 Quad processor. > + This enables support for Freescale i.MX6 Quad/DualLite/Solo processors. > > config SOC_IMX6SL > bool "i.MX6 SoloLite support" > diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c > index 11dcc369ec14..8cc8a2ed1d12 100644 > --- a/arch/arm/mach-imx/mach-imx6q.c > +++ b/arch/arm/mach-imx/mach-imx6q.c > @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = { > NULL, > }; > > -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)") > +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)") > .l2c_aux_val = 0, > .l2c_aux_mask = ~0, > .smp = smp_ops(imx_smp_ops), >
Lucas Stach <l.stach@pengutronix.de> writes: >> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite" >> for SOC_IMX6Q. >> > I don't think that's helpful, you would need to at least also print > "Dual" to make it correct. The Solo is just a fused down version of the > DualLite, just as the Dual is a fused down version of the Quad. > > Quad/DualLite refers to the two different die versions of the chip. Perhaps we need to print Dual as well. ATM "cat /proc/cpuinfo" (and everything using it) prints "Freescale i.MX6 Quad/DualLite (Device Tree)" on Solo and this is, at best, misleading: making people wonder what CPU do they really have.
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index b407b024dde3..b6f2f2ea8e65 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -143,7 +143,7 @@ config SOC_IMX6 select PL310_ERRATA_769419 if CACHE_L2X0 config SOC_IMX6Q - bool "i.MX6 Quad/DualLite support" + bool "i.MX6 Quad/DualLite/Solo support" select ARM_ERRATA_764369 if SMP select ARM_ERRATA_754322 select ARM_ERRATA_775420 @@ -153,7 +153,7 @@ config SOC_IMX6Q select SOC_IMX6 help - This enables support for Freescale i.MX6 Quad processor. + This enables support for Freescale i.MX6 Quad/DualLite/Solo processors. config SOC_IMX6SL bool "i.MX6 SoloLite support" diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c index 11dcc369ec14..8cc8a2ed1d12 100644 --- a/arch/arm/mach-imx/mach-imx6q.c +++ b/arch/arm/mach-imx/mach-imx6q.c @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = { NULL, }; -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)") +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)") .l2c_aux_val = 0, .l2c_aux_mask = ~0, .smp = smp_ops(imx_smp_ops),
Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite" for SOC_IMX6Q. Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>