| Message ID | cover.1438911559.git.horms+renesas@verge.net.au |
|---|---|
| State | New |
| Headers | show |
On Fri, Aug 07, 2015 at 11:12:03AM +0900, Simon Horman wrote: > Hi Olof, Hi Kevin, Hi Arnd, > > Please consider these Renesas ARM based SoC CPG MSTP clock domain updates > for v4.3. > > This pull request is based on "Third Round of Renesas ARM Based SoC DT > Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a > pull-request for. > > The reason for that base is that the DT changes in this series update nodes > added in that tag. > > This series begins with driver changes and follows up with DT changes. > The latter depend on the former. I see the acked-by tags on the clk patches, but it took some searching to find the ack email from Stephen. Can you please make our homework a bit easier when providing that in the future? Thanks, -Olof
On Fri, Aug 07, 2015 at 11:12:03AM +0900, Simon Horman wrote: > Hi Olof, Hi Kevin, Hi Arnd, > > Please consider these Renesas ARM based SoC CPG MSTP clock domain updates > for v4.3. > > This pull request is based on "Third Round of Renesas ARM Based SoC DT > Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a > pull-request for. > > The reason for that base is that the DT changes in this series update nodes > added in that tag. > > This series begins with driver changes and follows up with DT changes. > The latter depend on the former. > > > The following changes since commit 94bdc48d55ca10f90b4a625f0e443197e0013557: > > ARM: shmobile: sh73a0 dtsi: Add missing "gpio-ranges" to gpio node (2015-08-05 06:39:28 +0900) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-cpg-mstp-clock-domain-for-v4.3 > > for you to fetch changes up to 2daa8a5a8c0994893c2ca456303f0bf53e881cb9: > > ARM: shmobile: r8a7794 dtsi: Add CPG/MSTP Clock Domain (2015-08-05 06:42:51 +0900) We normally prefer to see drivers separately from DT. If you've looked at how we organize arm-soc, you've maybe seen that we have a separate topic for next/driver and one for next/dt. In other words, we try to keep them apart where it makes sense. In this case, that would mean having the clk changes in a drivers branch, and include that in this dt4 branch. If you want a reminder for when you might have looked at the branch sorting wrong: If you're naming the branch after a feature instead of the type of patches in it (when you send it to us), then chances are that we would ideally like to see the contents sorted differently -- at least in the cases where they cross the category boundaries that we organize our tree in. So, while it's not a huge deal I think it makes sense to revisit this and do that sorting for consistency's sake. Can I please ask that you respin this pull request with that in mind? I'd cherry-pick them apart but I know you tend to base branches on each other so that might mess you up and I don't want to do that. Thanks, -Olof
Hi Olof, On Tue, Aug 11, 2015 at 03:42:49PM +0200, Olof Johansson wrote: > On Fri, Aug 07, 2015 at 11:12:03AM +0900, Simon Horman wrote: > > Hi Olof, Hi Kevin, Hi Arnd, > > > > Please consider these Renesas ARM based SoC CPG MSTP clock domain updates > > for v4.3. > > > > This pull request is based on "Third Round of Renesas ARM Based SoC DT > > Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a > > pull-request for. > > > > The reason for that base is that the DT changes in this series update nodes > > added in that tag. > > > > This series begins with driver changes and follows up with DT changes. > > The latter depend on the former. > > > > > > The following changes since commit 94bdc48d55ca10f90b4a625f0e443197e0013557: > > > > ARM: shmobile: sh73a0 dtsi: Add missing "gpio-ranges" to gpio node (2015-08-05 06:39:28 +0900) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-cpg-mstp-clock-domain-for-v4.3 > > > > for you to fetch changes up to 2daa8a5a8c0994893c2ca456303f0bf53e881cb9: > > > > ARM: shmobile: r8a7794 dtsi: Add CPG/MSTP Clock Domain (2015-08-05 06:42:51 +0900) > > We normally prefer to see drivers separately from DT. If you've looked at how > we organize arm-soc, you've maybe seen that we have a separate topic for > next/driver and one for next/dt. In other words, we try to keep them apart > where it makes sense. > > In this case, that would mean having the clk changes in a drivers branch, and > include that in this dt4 branch. > > If you want a reminder for when you might have looked at the branch sorting > wrong: If you're naming the branch after a feature instead of the type of > patches in it (when you send it to us), then chances are that we would ideally > like to see the contents sorted differently -- at least in the cases where they > cross the category boundaries that we organize our tree in. > > So, while it's not a huge deal I think it makes sense to revisit this > and do that sorting for consistency's sake. Can I please ask that you > respin this pull request with that in mind? I'd cherry-pick them apart > but I know you tend to base branches on each other so that might mess > you up and I don't want to do that. Thanks for the detailed feedback. I have split the pull-request and reposted as you suggest above. And I'll try to keep your 'reminder' in mind in future.
On Tue, Aug 11, 2015 at 03:38:43PM +0200, Olof Johansson wrote: > On Fri, Aug 07, 2015 at 11:12:03AM +0900, Simon Horman wrote: > > Hi Olof, Hi Kevin, Hi Arnd, > > > > Please consider these Renesas ARM based SoC CPG MSTP clock domain updates > > for v4.3. > > > > This pull request is based on "Third Round of Renesas ARM Based SoC DT > > Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a > > pull-request for. > > > > The reason for that base is that the DT changes in this series update nodes > > added in that tag. > > > > This series begins with driver changes and follows up with DT changes. > > The latter depend on the former. > > I see the acked-by tags on the clk patches, but it took some searching to find > the ack email from Stephen. > > Can you please make our homework a bit easier when providing that in > the future? Sure, I hadn't realised that you liked to track down Acks to that extent. As practice for myself I've included some notes in the repost of the patches in question. Please let me know if you need something different.
On Wed, Aug 12, 2015 at 05:48:22PM +0900, Simon Horman wrote: > On Tue, Aug 11, 2015 at 03:38:43PM +0200, Olof Johansson wrote: > > On Fri, Aug 07, 2015 at 11:12:03AM +0900, Simon Horman wrote: > > > Hi Olof, Hi Kevin, Hi Arnd, > > > > > > Please consider these Renesas ARM based SoC CPG MSTP clock domain updates > > > for v4.3. > > > > > > This pull request is based on "Third Round of Renesas ARM Based SoC DT > > > Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a > > > pull-request for. > > > > > > The reason for that base is that the DT changes in this series update nodes > > > added in that tag. > > > > > > This series begins with driver changes and follows up with DT changes. > > > The latter depend on the former. > > > > I see the acked-by tags on the clk patches, but it took some searching to find > > the ack email from Stephen. > > > > Can you please make our homework a bit easier when providing that in > > the future? > > Sure, I hadn't realised that you liked to track down Acks to that extent. > > As practice for myself I've included some notes in the repost of the > patches in question. Please let me know if you need something different. It's one of those things that we check in on every now and then, just to make sure that there weren't comments from the other maintainer that were missed. We're more likely to do it on pull requests that didn't have the other maintainer on Cc, FWIW. :) -Olof
Hi Olof, Hi Kevin, Hi Arnd, Please consider these Renesas ARM based SoC CPG MSTP clock domain updates for v4.3. This pull request is based on "Third Round of Renesas ARM Based SoC DT Updates for v4.3", tagged as renesas-dt3-for-v4.3, which I have also sent a pull-request for. The reason for that base is that the DT changes in this series update nodes added in that tag. This series begins with driver changes and follows up with DT changes. The latter depend on the former. The following changes since commit 94bdc48d55ca10f90b4a625f0e443197e0013557: ARM: shmobile: sh73a0 dtsi: Add missing "gpio-ranges" to gpio node (2015-08-05 06:39:28 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-cpg-mstp-clock-domain-for-v4.3 for you to fetch changes up to 2daa8a5a8c0994893c2ca456303f0bf53e881cb9: ARM: shmobile: r8a7794 dtsi: Add CPG/MSTP Clock Domain (2015-08-05 06:42:51 +0900) ---------------------------------------------------------------- Renesas ARM Based SoC CPG MSTP Clock Domain Updates for v4.3 * Add Clock Domain support to the Clock Pulse Generator (CPG) Module Stop (MSTP) Clocks driver using the generic PM Domain. ---------------------------------------------------------------- Geert Uytterhoeven (12): clk: shmobile: Add CPG/MSTP Clock Domain support clk: shmobile: r8a7778: Add CPG/MSTP Clock Domain support clk: shmobile: r8a7779: Add CPG/MSTP Clock Domain support clk: shmobile: rcar-gen2: Add CPG/MSTP Clock Domain support clk: shmobile: rz: Add CPG/MSTP Clock Domain support ARM: shmobile: r7s72100 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7778 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7779 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7791 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7793 dtsi: Add CPG/MSTP Clock Domain ARM: shmobile: r8a7794 dtsi: Add CPG/MSTP Clock Domain .../bindings/clock/renesas,r8a7778-cpg-clocks.txt | 29 ++++++- .../bindings/clock/renesas,r8a7779-cpg-clocks.txt | 30 +++++++- .../clock/renesas,rcar-gen2-cpg-clocks.txt | 26 ++++++- .../bindings/clock/renesas,rz-cpg-clocks.txt | 29 ++++++- arch/arm/boot/dts/r7s72100.dtsi | 19 +++++ arch/arm/boot/dts/r8a7778.dtsi | 22 ++++++ arch/arm/boot/dts/r8a7779.dtsi | 23 ++++++ arch/arm/boot/dts/r8a7790.dtsi | 86 ++++++++++++++++++--- arch/arm/boot/dts/r8a7791.dtsi | 88 ++++++++++++++++++++-- arch/arm/boot/dts/r8a7793.dtsi | 7 ++ arch/arm/boot/dts/r8a7794.dtsi | 29 +++++++ arch/arm/mach-shmobile/Kconfig | 2 + drivers/clk/shmobile/clk-mstp.c | 87 +++++++++++++++++++++ drivers/clk/shmobile/clk-r8a7778.c | 2 + drivers/clk/shmobile/clk-r8a7779.c | 2 + drivers/clk/shmobile/clk-rcar-gen2.c | 2 + drivers/clk/shmobile/clk-rz.c | 3 + include/linux/clk/shmobile.h | 12 +++ 18 files changed, 470 insertions(+), 28 deletions(-)