| Message ID | cover.1405398515.git.horms+renesas@verge.net.au |
|---|---|
| State | New |
| Headers | show |
On Tue, Jul 15, 2014 at 06:16:36PM +0900, Simon Horman wrote: > Hi Olof, Hi Kevin, Hi Arnd, > > Please consider these third round of Renesas ARM based SoC DT updates for v3.17. > > This pull request is based on a merge of: > > * The previous round of such requests, tagged as renesas-dt2-for-v3.17, > which you have already pulled into next/dt and; > * The second round of Renesas ARM Based SoC Clock Updates for v3.17, > tagged as renesas-clock2-for-v3.17, which I have send a pull request for. > > The reason for the clock update is to provide run-time dependencies > to allow SCI to be initialised on DT on SoCs that do not yet have > CCF support. The key word being yet, it is being worked on. > > which I have already sent a pull-request for. > > > The following changes since commit 963b0c359bf5d284fc597bed07a668cb7396bfd2: > > Merge branch 'clock-for-v3.17' into dt-for-v3.17 (2014-07-12 15:16:37 +0200) > > are available in the git repository at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-dt3-for-v3.17 > > for you to fetch changes up to 700ce7c2bb2a4963472d95eba1436d6b0945918e: > > ARM: shmobile: kzm9g-reference: Initialise SCIF device using DT (2014-07-12 15:16:58 +0200) Hi, The diffstat I got were not the same as you, I get more diffs, and more patches. It seems that you specified your merge commit as the base, while you had new patches applied before the merge too. Anyway, merged since the contents looked generally OK. -Olof
Hi! On Tue, Jul 15, 2014 at 11:16 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > This describes all of the SCIF hardware of the r8a73a4. > Each node is disabled and may be enabled as necessary > by board DTS files. [...] > + scifb2: serial@e6c20000 { > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > + reg = <0 0xe6c20000 0 0x100>; > + interrupts = <0 148 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + scifb3: serial@e6c30000 { > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > + reg = <0 0xe6c30000 0 0x100>; > + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + scifb4: serial@e6ce0000 { > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > + reg = <0 0xe6ce0000 0 0x100>; > + interrupts = <0 150 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + scifb5: serial@e6cf0000 { > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > + reg = <0 0xe6cf0000 0 0x100>; > + interrupts = <0 151 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + I was just about to add clocks to these devices when I noticed that these ports are labeled scifb0 to scifb3 in the datasheet. Is there any deeper reasoning behind this, or did you just forget to reset the counter after scifa1? :) CU Uli
On Thu, Oct 30, 2014 at 06:43:12PM +0100, Ulrich Hecht wrote: > Hi! > > On Tue, Jul 15, 2014 at 11:16 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > This describes all of the SCIF hardware of the r8a73a4. > > Each node is disabled and may be enabled as necessary > > by board DTS files. > [...] > > + scifb2: serial@e6c20000 { > > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > > + reg = <0 0xe6c20000 0 0x100>; > > + interrupts = <0 148 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > + scifb3: serial@e6c30000 { > > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > > + reg = <0 0xe6c30000 0 0x100>; > > + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > + scifb4: serial@e6ce0000 { > > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > > + reg = <0 0xe6ce0000 0 0x100>; > > + interrupts = <0 150 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > + scifb5: serial@e6cf0000 { > > + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; > > + reg = <0 0xe6cf0000 0 0x100>; > > + interrupts = <0 151 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > I was just about to add clocks to these devices when I noticed that > these ports are labeled scifb0 to scifb3 in the datasheet. Is there > any deeper reasoning behind this, or did you just forget to reset the > counter after scifa1? :) Its a while since I wrote this patch. I think the reason is that I was blindly following the numbering-scheme used in r8a73a4. In any case, I think it would be good to name them according to the datasheet. Could you cook up a patch?
Hi Olof, Hi Kevin, Hi Arnd, Please consider these third round of Renesas ARM based SoC DT updates for v3.17. This pull request is based on a merge of: * The previous round of such requests, tagged as renesas-dt2-for-v3.17, which you have already pulled into next/dt and; * The second round of Renesas ARM Based SoC Clock Updates for v3.17, tagged as renesas-clock2-for-v3.17, which I have send a pull request for. The reason for the clock update is to provide run-time dependencies to allow SCI to be initialised on DT on SoCs that do not yet have CCF support. The key word being yet, it is being worked on. which I have already sent a pull-request for. The following changes since commit 963b0c359bf5d284fc597bed07a668cb7396bfd2: Merge branch 'clock-for-v3.17' into dt-for-v3.17 (2014-07-12 15:16:37 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-dt3-for-v3.17 for you to fetch changes up to 700ce7c2bb2a4963472d95eba1436d6b0945918e: ARM: shmobile: kzm9g-reference: Initialise SCIF device using DT (2014-07-12 15:16:58 +0200) ---------------------------------------------------------------- Third Round of Renesas ARM Based SoC DT Updates for v3.17 * Initialise SCI using DT when booting the kzm9g, armadillo800eva, ape6evm and bockw boards without legacy-C code. ---------------------------------------------------------------- Simon Horman (8): ARM: shmobile: r8a7778: Add SCIF nodes ARM: shmobile: bockw-reference: Initialise SCIF device using DT ARM: shmobile: r8a73a4: Add SCIF nodes ARM: shmobile: ape6evm-reference: Initialise SCIF device using DT ARM: shmobile: r8a7740: Add SCIF nodes ARM: shmobile: armadillo800eva-reference: Initialise SCIF device using DT ARM: shmobile: sh73a0: Add SCIF nodes ARM: shmobile: kzm9g-reference: Initialise SCIF device using DT arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts | 14 ++++- arch/arm/boot/dts/r8a73a4.dtsi | 42 +++++++++++++ .../boot/dts/r8a7740-armadillo800eva-reference.dts | 14 ++++- arch/arm/boot/dts/r8a7740.dtsi | 63 +++++++++++++++++++ arch/arm/boot/dts/r8a7778-bockw-reference.dts | 14 ++++- arch/arm/boot/dts/r8a7778.dtsi | 42 +++++++++++++ arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 14 ++++- arch/arm/boot/dts/sh73a0.dtsi | 72 ++++++++++++++++++++++ arch/arm/mach-shmobile/setup-r8a73a4.c | 12 ++-- arch/arm/mach-shmobile/setup-r8a7740.c | 8 +-- arch/arm/mach-shmobile/setup-r8a7778.c | 12 ++-- arch/arm/mach-shmobile/setup-sh73a0.c | 8 +-- 12 files changed, 283 insertions(+), 32 deletions(-)