| Message ID | cover.1387764079.git.horms+renesas@verge.net.au |
|---|---|
| State | New |
| Headers | show |
Hello. On 23-12-2013 6:08, Simon Horman wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > This patch support FSI-AK4648 with simple audio card > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33 ++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > index 5bb593d..eb8886b 100644 > --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts [...] > @@ -226,6 +240,12 @@ > }; > }; > }; > + > + ak4648: ak4648@0x12 { Perhaps "sound-codec" or "audio-codec" would be a better name; hardware specific names are not recommended by ePAPR. And drop "0x" from the address part please. > + #sound-dai-cells = <0>; > + compatible = "asahi-kasei,ak4648"; > + reg = <0x12>; > + }; > }; > > &i2c3 { WBR, Sergei
Hello. On 23-12-2013 17:21, Sergei Shtylyov wrote: >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> This patch support FSI-AK4648 with simple audio card >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> --- >> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33 >> ++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> index 5bb593d..eb8886b 100644 >> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > [...] >> @@ -226,6 +240,12 @@ >> }; >> }; >> }; >> + >> + ak4648: ak4648@0x12 { > Perhaps "sound-codec" or "audio-codec" would be a better name; hardware > specific names are not recommended by ePAPR. And drop "0x" from the address > part please. Sorry, I didn't notice the patch is posted as a part of pull request; I've probably missed the original posting (though I've already told to Morimoto-san that names like "ak4648" shouldn't be used). WBR, Sergei
[ Corrected subject: s/3.13.3.14 ] On Mon, Dec 23, 2013 at 11:08:12AM +0900, Simon Horman wrote: > Hi Kevin, Hi Olof, Hi Arnd, > > Please consider this second round of Renesas ARM Based SoC DT Updates for > v3.13. It is based on the first round, tagged as renesas-dt-for-v3.14, > which you have already pulled. > > > The following changes since commit 1fd219561a4afc51b5f257692f3581546434db5b: > > ARM: shmobile: marzen: enable HSPI0 in DTS (2013-12-10 17:27:25 +0900) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-dt2-for-v3.14 > > for you to fetch changes up to bd0609896eabe2e64b75d7955ae5ecec528cf860: > > ARM: shmobile: koelsch: dts: Add gpio-keys device (2013-12-12 22:22:04 +0900) > > ---------------------------------------------------------------- > Second Round of Renesas ARM Based SoC DT Updates for v3.13 > > * r8a7791 (R-Car M2) based Koelsch board > - Add GPIO keys > > * sh73a0 (SH-Mobile AG5) based kzm9g board > - Add FSI support > > ---------------------------------------------------------------- > Kuninori Morimoto (2): > ARM: shmobile: sh73a0: add FSI support via DTSI > ARM: shmobile: kzm9g: add FSI support for DTS > > Laurent Pinchart (1): > ARM: shmobile: koelsch: dts: Add gpio-keys device > > arch/arm/boot/dts/r8a7791-koelsch-reference.dts | 54 +++++++++++++++++++++++++ > arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33 +++++++++++++++ > arch/arm/boot/dts/sh73a0.dtsi | 9 +++++ > 3 files changed, 96 insertions(+) >
On Mon, Dec 23, 2013 at 06:10:09PM +0400, Sergei Shtylyov wrote: > Hello. > > On 23-12-2013 17:21, Sergei Shtylyov wrote: > > >>From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > >>This patch support FSI-AK4648 with simple audio card > > >>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >>--- > >> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33 > >>++++++++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > > >>diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > >>b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > >>index 5bb593d..eb8886b 100644 > >>--- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > >>+++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > >[...] > >>@@ -226,6 +240,12 @@ > >> }; > >> }; > >> }; > >>+ > >>+ ak4648: ak4648@0x12 { > > > Perhaps "sound-codec" or "audio-codec" would be a better name; hardware > >specific names are not recommended by ePAPR. And drop "0x" from the address > >part please. > > Sorry, I didn't notice the patch is posted as a part of pull > request; I've probably missed the original posting (though I've > already told to Morimoto-san that names like "ak4648" shouldn't be > used). Indeed, I think that you have commended on node naming on more than one occasion. Feel free to make some cleanup patches if you have the inclination.
On Tue, Dec 24, 2013 at 12:45:41PM +0900, Simon Horman wrote: > [ Corrected subject: s/3.13.3.14 ] > > On Mon, Dec 23, 2013 at 11:08:12AM +0900, Simon Horman wrote: > > Hi Kevin, Hi Olof, Hi Arnd, > > > > Please consider this second round of Renesas ARM Based SoC DT Updates for > > v3.13. It is based on the first round, tagged as renesas-dt-for-v3.14, > > which you have already pulled. > > > > > > The following changes since commit 1fd219561a4afc51b5f257692f3581546434db5b: > > > > ARM: shmobile: marzen: enable HSPI0 in DTS (2013-12-10 17:27:25 +0900) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-dt2-for-v3.14 Pulled, thanks. -Olof
Hi Kevin, Hi Olof, Hi Arnd, Please consider this second round of Renesas ARM Based SoC DT Updates for v3.13. It is based on the first round, tagged as renesas-dt-for-v3.14, which you have already pulled. The following changes since commit 1fd219561a4afc51b5f257692f3581546434db5b: ARM: shmobile: marzen: enable HSPI0 in DTS (2013-12-10 17:27:25 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-dt2-for-v3.14 for you to fetch changes up to bd0609896eabe2e64b75d7955ae5ecec528cf860: ARM: shmobile: koelsch: dts: Add gpio-keys device (2013-12-12 22:22:04 +0900) ---------------------------------------------------------------- Second Round of Renesas ARM Based SoC DT Updates for v3.13 * r8a7791 (R-Car M2) based Koelsch board - Add GPIO keys * sh73a0 (SH-Mobile AG5) based kzm9g board - Add FSI support ---------------------------------------------------------------- Kuninori Morimoto (2): ARM: shmobile: sh73a0: add FSI support via DTSI ARM: shmobile: kzm9g: add FSI support for DTS Laurent Pinchart (1): ARM: shmobile: koelsch: dts: Add gpio-keys device arch/arm/boot/dts/r8a7791-koelsch-reference.dts | 54 +++++++++++++++++++++++++ arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33 +++++++++++++++ arch/arm/boot/dts/sh73a0.dtsi | 9 +++++ 3 files changed, 96 insertions(+)