mbox series

[GIT,PULL] memblock, arm: fix crashes caused by holes in the memory map

Message ID YOHO05xJAVItsYsg@kernel.org
State New
Headers show
Series [GIT,PULL] memblock, arm: fix crashes caused by holes in the memory map | expand

Pull-request

ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git tags/memblock-v5.14-rc1

Message

Mike Rapoport July 4, 2021, 3:08 p.m. UTC 
Hi Linus,

The following changes since commit c4681547bcce777daf576925a966ffa824edd09d:

  Linux 5.13-rc3 (2021-05-23 11:42:48 -1000)

are available in the Git repository at:

  ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git tags/memblock-v5.14-rc1

for you to fetch changes up to a4d5613c4dc6d413e0733e37db9d116a2a36b9f3:

  arm: extend pfn_valid to take into account freed memory map alignment (2021-06-30 11:39:00 +0300)

----------------------------------------------------------------
memblock, arm: fix crashes caused by holes in the memory map

The coordination between freeing of unused memory map, pfn_valid() and core
mm assumptions about validity of the memory map in various ranges was not
designed for complex layouts of the physical memory with a lot of holes all
over the place.

Kefen Wang reported crashes in move_freepages() on a system with the
following memory layout [1]:

  node   0: [mem 0x0000000080a00000-0x00000000855fffff]
  node   0: [mem 0x0000000086a00000-0x0000000087dfffff]
  node   0: [mem 0x000000008bd00000-0x000000008c4fffff]
  node   0: [mem 0x000000008e300000-0x000000008ecfffff]
  node   0: [mem 0x0000000090d00000-0x00000000bfffffff]
  node   0: [mem 0x00000000cc000000-0x00000000dc9fffff]
  node   0: [mem 0x00000000de700000-0x00000000de9fffff]
  node   0: [mem 0x00000000e0800000-0x00000000e0bfffff]
  node   0: [mem 0x00000000f4b00000-0x00000000f6ffffff]
  node   0: [mem 0x00000000fda00000-0x00000000ffffefff]

These crashes can be mitigated by enabling CONFIG_HOLES_IN_ZONE on ARM and
essentially turning pfn_valid_within() to pfn_valid() instead of having it
hardwired to 1 on that architecture, but this would require to keep
CONFIG_HOLES_IN_ZONE solely for this purpose.

A cleaner approach is to update ARM's implementation of pfn_valid() to take
into accounting rounding of the freed memory map to pageblock boundaries
and make sure it returns true for PFNs that have memory map entries even if
there is no physical memory backing those PFNs.

[1] https://lore.kernel.org/lkml/2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com

----------------------------------------------------------------
Mike Rapoport (4):
      memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
      memblock: align freed memory map on pageblock boundaries with SPARSEMEM
      memblock: ensure there is no overflow in memblock_overlaps_region()
      arm: extend pfn_valid to take into account freed memory map alignment

 arch/arm/mm/init.c | 13 ++++++++++++-
 mm/memblock.c      | 26 ++++++++++++++------------
 2 files changed, 26 insertions(+), 13 deletions(-)

Comments

pr-tracker-bot@kernel.org July 4, 2021, 8:09 p.m. UTC | #1 
The pull request you sent on Sun, 4 Jul 2021 18:08:03 +0300:

> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git tags/memblock-v5.14-rc1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a412897fb546fbb291095be576165ce757eff70b

Thank you!