From patchwork Thu Sep 8 17:03:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Miao X-Patchwork-Id: 113926 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 73C14B6F99 for ; Fri, 9 Sep 2011 03:04:30 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R1i1V-00075f-Gh; Thu, 08 Sep 2011 17:04:21 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1R1i1S-0001BT-3F; Thu, 08 Sep 2011 17:04:18 +0000 Received: from mail-vx0-f177.google.com ([209.85.220.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R1i1P-0001BA-DM for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2011 17:04:16 +0000 Received: by vxj10 with SMTP id 10so239565vxj.36 for ; Thu, 08 Sep 2011 10:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=DEdK6y0dYXK7VUAYWyTJh0NbFqwKbHR4w+b53NsTruc=; b=s1TvcX+35R9DuHHcExhT2+6wKIRbjkheubJiuPZnEm8/M2v74EHSoKK5Bko0GTbK8c 8UKSoYlfeY8cDlHHaJow0Fn1r+CnDEdpiDBM/kEqowgAtjPVAyJ24FwzNpGtisUbryDk rprAwqaoR+gWoFE4Ro2t1alyFVSiMAFegCpyU= Received: by 10.52.93.164 with SMTP id cv4mr971015vdb.304.1315501452500; Thu, 08 Sep 2011 10:04:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.185.72 with HTTP; Thu, 8 Sep 2011 10:03:52 -0700 (PDT) In-Reply-To: <201109081845.58260.arnd@arndb.de> References: <1315497854-13311-1-git-send-email-dave.martin@linaro.org> <1315497854-13311-3-git-send-email-dave.martin@linaro.org> <201109081845.58260.arnd@arndb.de> From: Eric Miao Date: Thu, 8 Sep 2011 10:03:52 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2 To: Arnd Bergmann X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110908_130415_593938_111942BB X-CRM114-Status: GOOD ( 16.78 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eric.y.miao[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.177 listed in list.dnswl.org] Cc: Dave Martin , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Thu, Sep 8, 2011 at 9:45 AM, Arnd Bergmann wrote: > On Thursday 08 September 2011, Dave Martin wrote: >> The iwmmxt code contains some code to implement a pseudo-ISB, but >> this is not buildable for Thumb-2. >> >> This patch replaces the pseudo-ISB with a real one for Thumb-2 >> kernels. >> >> Signed-off-by: Dave Martin >> --- >>  arch/arm/kernel/iwmmxt.S |    9 +++++++++ >>  1 files changed, 9 insertions(+), 0 deletions(-) > > Acked-by: Arnd Bergmann > Maybe it'll be much simpler to have something like below: diff --git a/arch/arm/kernel/iwmmxt.S b/arch/arm/kernel/iwmmxt.S index a087838..5998f7d 100644 --- a/arch/arm/kernel/iwmmxt.S +++ b/arch/arm/kernel/iwmmxt.S @@ -319,8 +319,9 @@ ENTRY(iwmmxt_task_switch) PJ4(eor r1, r1, #0xf) PJ4(mcr p15, 0, r1, c1, c0, 2) - mrc p15, 0, r1, c2, c0, 0 - sub pc, lr, r1, lsr #32 @ cpwait and return + XSC(mrc p15, 0, r1, c2, c0, 0) + PJ4(isb) + mov pc, lr @ cpwait and return /* * Remove Concan ownership of given task