| Message ID | 8c7fe79d-ebd3-ee7c-f056-1d3aa225edee@st.com |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL] STM32 defconfig changes for v4.15 #1 | expand |
On Tue, Oct 17, 2017 at 12:16 PM, Alexandre Torgue <alexandre.torgue@st.com> wrote: > ---------------------------------------------------------------- > STM32 defconfig updates for v4.15, round 1 > > Highlights: > ---------- > -Regenerate default configuration > -Add DMAMUX support > -Add I2C F7 support > -Add MDMA support Pulled into next/soc. Splitting out the first patch is fine, but there really is no need to have one patch per new Kconfig option you enable, it's less work and more readable to have a combined patch that explains what the options are and why you need all of them. Arnd
Hi Arnd, On 10/19/2017 10:57 PM, Arnd Bergmann wrote: > On Tue, Oct 17, 2017 at 12:16 PM, Alexandre Torgue > <alexandre.torgue@st.com> wrote: >> ---------------------------------------------------------------- >> STM32 defconfig updates for v4.15, round 1 >> >> Highlights: >> ---------- >> -Regenerate default configuration >> -Add DMAMUX support >> -Add I2C F7 support >> -Add MDMA support > > Pulled into next/soc. > > Splitting out the first patch is fine, but there really is no need to have one > patch per new Kconfig option you enable, it's less work and more readable to > have a combined patch that explains what the options are and why you need > all of them. > > Arnd > ok. So you mean I would have to merge "Add DMAMUX support", "Add I2C F7 support", "Add MDMA support" in one patch before to submit the pull request ? If yes, it will be done for next PR. Thanks Alex
On Fri, Oct 20, 2017 at 9:33 AM, Alexandre Torgue <alexandre.torgue@st.com> wrote: > On 10/19/2017 10:57 PM, Arnd Bergmann wrote: >> On Tue, Oct 17, 2017 at 12:16 PM, Alexandre Torgue >> >> Pulled into next/soc. >> >> Splitting out the first patch is fine, but there really is no need to have >> one >> patch per new Kconfig option you enable, it's less work and more readable >> to >> have a combined patch that explains what the options are and why you need >> all of them. >> >> Arnd >> > > ok. So you mean I would have to merge "Add DMAMUX support", "Add I2C F7 > support", "Add MDMA support" in one patch before to submit the pull request > ? If yes, it will be done for next PR. Right, it's about finding the right balance. Most of the time, splitting up a patch into smaller independent units makes sense when you explain what each one does, but in cases like this (adding just one config option or one DT node), it becomes more readable if you do multiple related changes at once. The best test is usually what you put in the changelog. If you have multiple patches with almost-identical descriptions, merge them. If you have one patch with a description that talks about unrelated problems, split it up. Arnd
On 10/20/2017 09:40 AM, Arnd Bergmann wrote: > On Fri, Oct 20, 2017 at 9:33 AM, Alexandre Torgue > <alexandre.torgue@st.com> wrote: >> On 10/19/2017 10:57 PM, Arnd Bergmann wrote: >>> On Tue, Oct 17, 2017 at 12:16 PM, Alexandre Torgue >>> >>> Pulled into next/soc. >>> >>> Splitting out the first patch is fine, but there really is no need to have >>> one >>> patch per new Kconfig option you enable, it's less work and more readable >>> to >>> have a combined patch that explains what the options are and why you need >>> all of them. >>> >>> Arnd >>> >> >> ok. So you mean I would have to merge "Add DMAMUX support", "Add I2C F7 >> support", "Add MDMA support" in one patch before to submit the pull request >> ? If yes, it will be done for next PR. > > Right, it's about finding the right balance. Most of the time, splitting up a > patch into smaller independent units makes sense when you explain > what each one does, but in cases like this (adding just one config option > or one DT node), it becomes more readable if you do multiple related > changes at once. > > The best test is usually what you put in the changelog. If you have multiple > patches with almost-identical descriptions, merge them. If you have one > patch with a description that talks about unrelated problems, split it up. > > Arnd > Ok. Thanks for the tips ;) Regards Alex
Hi Olof, Arnd and Kevin, Please consider this first round of STM32 defconfig updates for v4.15: The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git tags/stm32-defconfig-for-v4.15-1 for you to fetch changes up to 4a95602b3edf656ff4540bd62057901d4bb33812: ARM: configs: stm32: Add MDMA support in STM32 defconfig (2017-10-16 18:25:20 +0200) ---------------------------------------------------------------- STM32 defconfig updates for v4.15, round 1 Highlights: ---------- -Regenerate default configuration -Add DMAMUX support -Add I2C F7 support -Add MDMA support ---------------------------------------------------------------- Alexandre Torgue (1): ARM: configs: stm32: Update default configuration for v4.14-rc1 Pierre-Yves MORDRET (3): ARM: configs: stm32: Add DMAMUX support in STM32 defconfig ARM: configs: stm32: Add I2C F7 support in STM32 defconfig ARM: configs: stm32: Add MDMA support in STM32 defconfig arch/arm/configs/stm32_defconfig | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)