| Message ID | 87egqpff9m.fsf@free.fr |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 20, 2015 at 08:01:09PM +0100, Robert Jarzmik wrote: > Hello Arnd, Kevin, Olof, > > Please consider this pxa code for next v3.20 cycle. It was a bit early, but I > think the upcoming changes around pxa clocks should go for 3.21, and no pending > patches are in review for v3.20. And yes, I messed up the previous git pull > email address ... > > The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: > > Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) > > are available in the git repository at: > > https://github.com/rjarzmik/linux.git tags/pxa-for-3.20 > > for you to fetch changes up to a52d209336f8fc7483a8c7f4a8a7d2a8e1692a6c: > > hx4700: regulator: declare full constraints (2014-12-26 18:05:32 +0100) > > ---------------------------------------------------------------- > arm: pxa: pxa for v3.20 > > This update deals mostly with regulator updates for fixing all the > cases where a default regulator is needed, with non device-tree > platforms. There's also a kconfig fix for device-tree pxa. > > It should be noticed that all interrupts numbers were shifted by > 16 (number of legacy interrupts). Hi Robert, Branch looks good, I'll merge this into next/fixes-non-critical. One nit below though: > ---------------------------------------------------------------- > Dmitry Eremin-Solenikov (3): > ARM: pxa: add regulator_has_full_constraints to corgi board file > ARM: pxa: add regulator_has_full_constraints to poodle board file > ARM: pxa: add regulator_has_full_constraints to spitz board file > > Martin Vajnar (1): > hx4700: regulator: declare full constraints Please use consistent patch subjects in the future. We've ended up using ARM: <platform>: <foo> across all platforms these days. I'm not going to ask you to respin just for this, but please remember to fix future patches when you apply them if they're not already correct. -Olof
Olof Johansson <olof@lixom.net> writes: > Hi Robert, > > Branch looks good, I'll merge this into next/fixes-non-critical. One nit below > though: > >> ---------------------------------------------------------------- >> Dmitry Eremin-Solenikov (3): >> ARM: pxa: add regulator_has_full_constraints to corgi board file >> ARM: pxa: add regulator_has_full_constraints to poodle board file >> ARM: pxa: add regulator_has_full_constraints to spitz board file >> >> Martin Vajnar (1): >> hx4700: regulator: declare full constraints > > Please use consistent patch subjects in the future. We've ended up using ARM: > <platform>: <foo> across all platforms these days. > > I'm not going to ask you to respin just for this, but please remember to fix > future patches when you apply them if they're not already correct. You're right, I missed that one. In case you've not already pulled, I created : https://github.com/rjarzmik/linux.git tags/pxa-for-3.20-bis I can resend a proper pull request if you wish, or we can leave it as is if you already pulled. In any case I'll be more carefull next time, maybe I can convince my bot to check that for me too. Or even better checkpatch could check that any patch with a diffstat fully in arch/arm/{mach,plat}-<XYZ> has a subject beginning with "ARM: XYZ: ", that would be cool, and put the burden on others as well :) Cheers.
On Sat, Jan 24, 2015 at 03:18:11PM +0100, Robert Jarzmik wrote: > Olof Johansson <olof@lixom.net> writes: > > > Hi Robert, > > > > Branch looks good, I'll merge this into next/fixes-non-critical. One nit below > > though: > > > >> ---------------------------------------------------------------- > >> Dmitry Eremin-Solenikov (3): > >> ARM: pxa: add regulator_has_full_constraints to corgi board file > >> ARM: pxa: add regulator_has_full_constraints to poodle board file > >> ARM: pxa: add regulator_has_full_constraints to spitz board file > >> > >> Martin Vajnar (1): > >> hx4700: regulator: declare full constraints > > > > Please use consistent patch subjects in the future. We've ended up using ARM: > > <platform>: <foo> across all platforms these days. > > > > I'm not going to ask you to respin just for this, but please remember to fix > > future patches when you apply them if they're not already correct. > You're right, I missed that one. > > In case you've not already pulled, I created : > https://github.com/rjarzmik/linux.git tags/pxa-for-3.20-bis > > I can resend a proper pull request if you wish, or we can leave it as is if you > already pulled. In any case I'll be more carefull next time, maybe I can > convince my bot to check that for me too. I had already merged, but it looks like you broke viper and zeus. Both of them still refer to PXA_ISA_IRQ(). Can you send an incremental patch for that? Or if you prefer that we drop this branch for now while you sort it out that's OK too -- your preference. > Or even better checkpatch could check that any patch with a diffstat fully in > arch/arm/{mach,plat}-<XYZ> has a subject beginning with "ARM: XYZ: ", that would > be cool, and put the burden on others as well :) Yeah we normally scale this by educating downstream maintainers. checkpatch is useful in many cases but making it do everything is hard. -Olof
Olof Johansson <olof@lixom.net> writes: > I had already merged, but it looks like you broke viper and zeus. Both of them > still refer to PXA_ISA_IRQ(). > > Can you send an incremental patch for that? Or if you prefer that we drop this > branch for now while you sort it out that's OK too -- your preference. I'll send an incremental patch. I'm really frustrated my bot didn't catch that, I suppose yours caught it by building viper_defconfig ... > Yeah we normally scale this by educating downstream maintainers. checkpatch is > useful in many cases but making it do everything is hard. Yeah, but humans do forget, even educated ... I'll be carefull as much as I can, but I knew the rule and yet this slipped through. Cheers.
On Mon, Jan 26, 2015 at 8:42 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: > Olof Johansson <olof@lixom.net> writes: > >> I had already merged, but it looks like you broke viper and zeus. Both of them >> still refer to PXA_ISA_IRQ(). >> >> Can you send an incremental patch for that? Or if you prefer that we drop this >> branch for now while you sort it out that's OK too -- your preference. > I'll send an incremental patch. > I'm really frustrated my bot didn't catch that, I suppose yours caught it by > building viper_defconfig ... Yeah, I build all defconfigs. >> Yeah we normally scale this by educating downstream maintainers. checkpatch is >> useful in many cases but making it do everything is hard. > Yeah, but humans do forget, even educated ... I'll be carefull as much as I can, > but I knew the rule and yet this slipped through. Oh, no worries. We're all human, which is why I pointed it out when I noticed it. Next time I might miss it too. It happens. -Olof
Hello Arnd, Kevin, Olof, Please consider this pxa code for next v3.20 cycle. It was a bit early, but I think the upcoming changes around pxa clocks should go for 3.21, and no pending patches are in review for v3.20. And yes, I messed up the previous git pull email address ... The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are available in the git repository at: https://github.com/rjarzmik/linux.git tags/pxa-for-3.20 for you to fetch changes up to a52d209336f8fc7483a8c7f4a8a7d2a8e1692a6c: hx4700: regulator: declare full constraints (2014-12-26 18:05:32 +0100) ---------------------------------------------------------------- arm: pxa: pxa for v3.20 This update deals mostly with regulator updates for fixing all the cases where a default regulator is needed, with non device-tree platforms. There's also a kconfig fix for device-tree pxa. It should be noticed that all interrupts numbers were shifted by 16 (number of legacy interrupts). ---------------------------------------------------------------- Dmitry Eremin-Solenikov (3): ARM: pxa: add regulator_has_full_constraints to corgi board file ARM: pxa: add regulator_has_full_constraints to poodle board file ARM: pxa: add regulator_has_full_constraints to spitz board file Martin Vajnar (1): hx4700: regulator: declare full constraints Robert Jarzmik (2): arm: pxa: fix pxa27x device-tree support kconfig ARM: pxa: arbitrarily set first interrupt number arch/arm/mach-pxa/Kconfig | 6 ------ arch/arm/mach-pxa/corgi.c | 3 +++ arch/arm/mach-pxa/hx4700.c | 2 ++ arch/arm/mach-pxa/include/mach/irqs.h | 9 ++------- arch/arm/mach-pxa/poodle.c | 2 ++ arch/arm/mach-pxa/spitz.c | 2 ++ 6 files changed, 11 insertions(+), 13 deletions(-) Cheers.