| Message ID | 84d4bc0b733cb9776f03ad54bb946fd1c4be4049.1475764778.git.paweljarosz3691@gmail.com |
|---|---|
| State | New |
| Headers | show |
Hi Paweł, Am Donnerstag, 6. Oktober 2016, 18:22:40 CEST schrieb =?UTF-8?q? Pawe=C5=82=20Jarosz?=: > MK808 is rockchip rk3066 based board made by Rickomagic. It has two usb > ports, sdmmc, wifi and uart onboard. > > Signed-off-by: Paweł Jarosz <paweljarosz3691@gmail.com> > --- > arch/arm/boot/dts/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index befcd26..f19cc1d 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -639,6 +639,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ > rk3036-kylin.dtb \ > rk3066a-bqcurie2.dtb \ > rk3066a-marsboard.dtb \ > + rk3066a-mk808.dtb \ > rk3066a-rayeager.dtb \ > rk3188-radxarock.dtb \ > rk3228-evb.dtb \ This patch breaks bisectability, as it adds a dtb to the makefile that you only add in patch3 which makes builds fail. Please fold your patches 1 and 3 into one patch and also add and entry to Documentation/devicetree/bindings/arm/ rockchip.txt for the board. Heiko
Hi Heiko > This patch breaks bisectability, as it adds a dtb to the makefile that you only > add in patch3 which makes builds fail. Please fold your patches 1 and 3 into > one patch and also add and entry to Documentation/devicetree/bindings/arm/ > rockchip.txt for the board. > > > Heiko Should i squash all patches in one? I saw now in logs that it's common practise. Paweł
Am Donnerstag, 6. Oktober 2016, 19:05:15 CEST schrieb Paweł Jarosz: > Hi Heiko > > > This patch breaks bisectability, as it adds a dtb to the makefile that you > > only add in patch3 which makes builds fail. Please fold your patches 1 > > and 3 into one patch and also add and entry to > > Documentation/devicetree/bindings/arm/ rockchip.txt for the board. > > > > > > Heiko > > Should i squash all patches in one? > > I saw now in logs that it's common practise. Nope ... vendor-prefix should stay separate, everything else can be in one patch.
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index befcd26..f19cc1d 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -639,6 +639,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ rk3036-kylin.dtb \ rk3066a-bqcurie2.dtb \ rk3066a-marsboard.dtb \ + rk3066a-mk808.dtb \ rk3066a-rayeager.dtb \ rk3188-radxarock.dtb \ rk3228-evb.dtb \
MK808 is rockchip rk3066 based board made by Rickomagic. It has two usb ports, sdmmc, wifi and uart onboard. Signed-off-by: Paweł Jarosz <paweljarosz3691@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+)