diff mbox series

[1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

Message ID 20230319234710.1749455-1-cphealy@gmail.com
State New
Headers show
Series [1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY | expand

Commit Message

Chris Healy March 19, 2023, 11:47 p.m. UTC 
From: Chris Healy <healych@amazon.com>

The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.

Signed-off-by: Chris Healy <healych@amazon.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam March 20, 2023, 3:07 a.m. UTC | #1 
Hi Chris,

On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <cphealy@gmail.com> wrote:
>
> From: Chris Healy <healych@amazon.com>
>
> The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.
>
> Signed-off-by: Chris Healy <healych@amazon.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 6dc6fed12af8..a12d45e99782 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
>  # CONFIG_NET_VENDOR_STMICRO is not set
>  CONFIG_MICREL_PHY=y
>  CONFIG_AT803X_PHY=y
> +CONFIG_SMSC_PHY=y

Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
selected by default
because USB_NET_SMSC95XX is already enabled.

It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
done in this patch.
Chris Healy March 20, 2023, 2 p.m. UTC | #2 
On Sun, Mar 19, 2023 at 8:07 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > From: Chris Healy <healych@amazon.com>
> >
> > The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.
> >
> > Signed-off-by: Chris Healy <healych@amazon.com>
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> > index 6dc6fed12af8..a12d45e99782 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
> >  # CONFIG_NET_VENDOR_STMICRO is not set
> >  CONFIG_MICREL_PHY=y
> >  CONFIG_AT803X_PHY=y
> > +CONFIG_SMSC_PHY=y
>
> Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
> selected by default
> because USB_NET_SMSC95XX is already enabled.
>
> It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
> done in this patch.

I see what you are saying.  I agree this patch is no longer necessary.  Tnx.
diff mbox series

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 6dc6fed12af8..a12d45e99782 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -135,6 +135,7 @@  CONFIG_SMSC911X=y
 # CONFIG_NET_VENDOR_STMICRO is not set
 CONFIG_MICREL_PHY=y
 CONFIG_AT803X_PHY=y
+CONFIG_SMSC_PHY=y
 CONFIG_CAN_FLEXCAN=y
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m