diff mbox series

ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc

Message ID 20201028091539.136026-1-miaoqinglang@huawei.com
State New
Headers show
Series ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc | expand

Commit Message

Qinglang Miao Oct. 28, 2020, 9:15 a.m. UTC 
Clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
 arch/arm/mach-imx/mmdc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo Nov. 1, 2020, 9:23 a.m. UTC | #1 
On Wed, Oct 28, 2020 at 05:15:39PM +0800, Qinglang Miao wrote:
> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
index 0dfd0ae7a..56375e8da 100644
--- a/arch/arm/mach-imx/mmdc.c
+++ b/arch/arm/mach-imx/mmdc.c
@@ -462,6 +462,7 @@  static int imx_mmdc_remove(struct platform_device *pdev)
 
 	cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node);
 	perf_pmu_unregister(&pmu_mmdc->pmu);
+	clk_disable_unprepare(mmdc_ipg_clk);
 	kfree(pmu_mmdc);
 	return 0;
 }