diff mbox series

[v2,1/5] arm64: allwinner: h6: orangepi: Add PIO regulators

Message ID 20190405122446.2101-1-peron.clem@gmail.com
State New
Headers show
Series [v2,1/5] arm64: allwinner: h6: orangepi: Add PIO regulators | expand

Commit Message

Clément Péron April 5, 2019, 12:24 p.m. UTC 
OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.

Add this in the common device tree.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Maxime Ripard April 5, 2019, 3:08 p.m. UTC | #1 
On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
>
> Add this in the common device tree.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> index b2526dac2fcf..fd2af5095425 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> @@ -72,6 +72,12 @@
>  	status = "okay";
>  };
>
> +&pio {
> +        vcc-pc-supply = <&reg_bldo2>;
> +        vcc-pd-supply = <&reg_cldo1>;
> +        vcc-pg-supply = <&reg_bldo3>;
> +};
> +
>  &r_i2c {
>  	status = "okay";
>
> @@ -191,6 +197,11 @@
>  	};
>  };
>
> +&r_pio {
> +        vcc-pl-supply = <&reg_aldo1>;
> +        vcc-pm-supply = <&reg_bldo3>;
> +};
> +

How was this tested?

Please run checkpatch on your patches as well.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Clément Péron April 5, 2019, 4:42 p.m. UTC | #2 
Hi,

On Fri, 5 Apr 2019 at 17:08, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> > OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
> >
> > Add this in the common device tree.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > index b2526dac2fcf..fd2af5095425 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > @@ -72,6 +72,12 @@
> >       status = "okay";
> >  };
> >
> > +&pio {
> > +        vcc-pc-supply = <&reg_bldo2>;
> > +        vcc-pd-supply = <&reg_cldo1>;
> > +        vcc-pg-supply = <&reg_bldo3>;
> > +};
> > +
> >  &r_i2c {
> >       status = "okay";
> >
> > @@ -191,6 +197,11 @@
> >       };
> >  };
> >
> > +&r_pio {
> > +        vcc-pl-supply = <&reg_aldo1>;
> > +        vcc-pm-supply = <&reg_bldo3>;
> > +};
> > +
>
> How was this tested?
Sorry maybe I should mention that but I don't own an OrangePi or a Pine H64.

But this should have the same issue than the Beelink GS1.

>
> Please run checkpatch on your patches as well.
Thanks for the advice,
Clement

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
index b2526dac2fcf..fd2af5095425 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
@@ -72,6 +72,12 @@ 
 	status = "okay";
 };
 
+&pio {
+        vcc-pc-supply = <&reg_bldo2>;
+        vcc-pd-supply = <&reg_cldo1>;
+        vcc-pg-supply = <&reg_bldo3>;
+};
+
 &r_i2c {
 	status = "okay";
 
@@ -191,6 +197,11 @@ 
 	};
 };
 
+&r_pio {
+        vcc-pl-supply = <&reg_aldo1>;
+        vcc-pm-supply = <&reg_bldo3>;
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_ph_pins>;