| Message ID | 20181229000829.16571-2-martin.blumenstingl@googlemail.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e/uhUQxN"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="TNPpcAis"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43RP8G3zy2z9sCQ for <incoming-imx@patchwork.ozlabs.org>; Sat, 29 Dec 2018 11:09:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nnaiwQpFY6QsILSpYomAoRKxLd8BhrBKLobIbs9WAWc=; b=e/uhUQxN5jA8eA ADOI8tSq+Yvjq1ZryEFKgKcFvVoH7b92bFTC6sr/jGh3y9/Duy9XixqWdP2BNGrW5sSU/ldbOupd5 k5efsz3AQOjDVGXT42BvsgbA442XcYJxU9LaDY7GLQWOIdano63Q6hnyeEuSlW+eM2cGTJeQCvQnI 2hiaGpdgB4/RLA6Ng39cfcVylS2gKX6diR42oAgn4lm/+aOfPpWzprfDnz8u6iiwNAXIKayMzbnph dKem/HJkHKD+XvW/7ZvMPaPJtSKe8i8Kj+Qs/wdilEVImatGbq2032eA4BTc+JNefYix7awsnRjgS nbDD7OkgTBSBtYKTbGYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gd2C0-0003tY-J3; Sat, 29 Dec 2018 00:09:28 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gd2Bc-0003dG-2i; Sat, 29 Dec 2018 00:09:05 +0000 Received: by mail-wm1-x344.google.com with SMTP id f81so20741219wmd.4; Fri, 28 Dec 2018 16:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eLt89RDPW1/c/GL7HWxtODqUof3fnCO1oT2ipHADAIw=; b=TNPpcAisljoaF4F3qlugllEk2WvgV5OGXGEeycxb1P+mrPVE3+AJAP/z7vm6obsfHQ ygMmvTnvuvfI8xKfBKZ0CLO09YDcUgjljxeaTULd1pJD3t0LdwGRs6v4Onp3Mh73qxe2 4B48YwAF8YJK76QA3Dn6uyC2mrA4OFwf164r0rOApHPVZ8vE2nrnDe9olLEoPbp99Dbd vFLK2u90zLxCzmnIMGDPWbhThgPVpypVjOMoZMmA17nG6AwqCw21M3+dkdYOFwRqscOW Ie1eIDicANMVpM616WxCMM/O/x3XkeFhTqUfUSNhYtWowITtFoeFP8Hbnpb6y6oBRF8x Szvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eLt89RDPW1/c/GL7HWxtODqUof3fnCO1oT2ipHADAIw=; b=ICf7xPu2DWMwQ2qaKPxpdGaOHjSCRY9n0Nn/NUucG/Su3lGMfZUbwZA0rn7PrhAQHo 3jvi9jreZNOHonXicHdYTHy8fxF9CqCSWsiwTLtj6KN48HWvjupkqGuiiQVFZ/UYrbOz hK4YCstx368c/fiPnFKqSkYrRyyiscOTI2OxRUPN7kyMfDQr+VEhlygZPi3wA4fcY5/T 1VNwBndH6HOvB/NDrxCBbiEF6/bEkapzsfyB0QOLhKtH7WG4l4SVw0vWV4Ra1Z0K/dYt 85Qg0tjjYXAIHA4KOEAY5q93gSgvXZNUBQOgIjq+67LsdqrizQB6EXR2ioPDiGiJjQ3I aowQ== X-Gm-Message-State: AJcUukeuyB8fgcJ3Pgpgk9fWWjT4vaJ2zczZbq5wAIPGzRKolgseWTTg PDrJBl085ZLfVPEuFqCQ2so= X-Google-Smtp-Source: AFSGD/WoLV9HCr3IygGKTJ8+o90JhSkAZyf8/dnlIUXNTLDTooEGBHAFcLjjO2CP34qaw+aLlJUIwQ== X-Received: by 2002:a1c:1741:: with SMTP id 62mr24307397wmx.25.1546042132222; Fri, 28 Dec 2018 16:08:52 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600658C35E37AF585B6.dip0.t-ipconnect.de. [2003:dc:d729:4600:658c:35e3:7af5:85b6]) by smtp.googlemail.com with ESMTPSA id f18sm24420570wrs.92.2018.12.28.16.08.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Dec 2018 16:08:51 -0800 (PST) From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: jianxin.pan@amlogic.com, linux-amlogic@lists.infradead.org, khilman@baylibre.com, ingrassia@epigenesys.com Subject: [PATCH v2 1/1] ARM: dts: meson8b: drop eth_txd0_1 and eth_txd1_1 from eth_rgmii_pins Date: Sat, 29 Dec 2018 01:08:29 +0100 Message-Id: <20181229000829.16571-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229000829.16571-1-martin.blumenstingl@googlemail.com> References: <20181229000829.16571-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181228_160904_116817_A58865E9 X-CRM114-Status: GOOD ( 13.38 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (martin.blumenstingl[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>, linus.luessing@c0d3.blue, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org |
| Series |
Meson8b RGMII Ethernet pin cleanup
|
expand
|
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi index 22d775460767..ecca36a8678d 100644 --- a/arch/arm/boot/dts/meson8b.dtsi +++ b/arch/arm/boot/dts/meson8b.dtsi @@ -270,9 +270,7 @@ groups = "eth_tx_clk", "eth_tx_en", "eth_txd1_0", - "eth_txd1_1", "eth_txd0_0", - "eth_txd0_1", "eth_rx_clk", "eth_rx_dv", "eth_rxd1",
According to the Odroid-C1+ schematics the Ethernet TXD1 signal is routed to GPIOH_5 and the TXD0 signal is routed to GPIOH_6. The public S805 datasheet shows that TXD0 can be routed to DIF_2_P and TXD1 can be routed to DIF_2_N instead. GPIO mux register 6 bit 4 configures DIF_2_P as ETH_TXD0, register 6 bit 5 configures DIF_2_N as ETH_TXD1. GPIO mux register 7 bit 21 configures GPIOH_5 as ETH_TXD1, register 7 bit 20 configures GPIOH_6 as ETH_TXD0. The pin groups eth_txd0_0 (GPIOH_6) and eth_txd0_1 (DIF_2_P) are both configured as Ethernet TXD0 data line in meson8b.dtsi. Also eth_txd1_0 (GPIOH_5) and eth_txd1_1 (DIF_2_N) are configured as TXD1 data line. The vendor u-boot sources for Odroid-C1 use the following Ethernet pinmux configuration: SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_6, 0x3f4f); SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_7, 0xf00000); This translates to the following pin groups in the mainline kernel: - register 6 bit 0: eth_rxd1 (DIF_0_P) - register 6 bit 1: eth_rxd0 (DIF_0_N) - register 6 bit 2: eth_rx_dv (DIF_1_P) - register 6 bit 3: eth_rx_clk (DIF_1_N) - register 6 bit 6: eth_tx_en (DIF_3_P) - register 6 bit 8: eth_ref_clk (DIF_3_N) - register 6 bit 9: eth_mdc (DIF_4_P) - register 6 bit 10: eth_mdio_en (DIF_4_N) - register 6 bit 11: eth_tx_clk (GPIOH_9) - register 6 bit 12: eth_txd2 (GPIOH_8) - register 6 bit 13: eth_txd3 (GPIOH_7) - register 7 bit 20: eth_txd0_0 (GPIOH_6) - register 7 bit 21: eth_txd1_0 (GPIOH_5) - register 7 bit 22: currently unknown, might be eth_rxd2 or eth_rxd3 - register 7 bit 23: currently unknown, might be eth_rxd2 or eth_rxd3 Dropping eth_txd0_1 and eth_txd1_1 improves the receive performance. This is probably due to the eth_txd0 and eth_txd1 signal being routed to the wrong pins, so data can only be transferred on eth_txd2 and eth_txd3. However, I have no scope to confirm this assumption. iperf3 statistics before this change: - transmitting from Odroid-C1: 741 Mbits/sec (0 retries) - receiving on Odroid-C1: 199 Mbits/sec (1713 retries) iperf3 statistics after this change: - transmitting from Odroid-C1: 667 Mbits/sec (0 retries) - receiving on Odroid-C1: 750 Mbits/sec (0 retries) Fixes: b96446541d8390 ("ARM: dts: meson8b: extend ethernet controller description") Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Emiliano Ingrassia <ingrassia@epigenesys.com> Cc: Linus Lüssing <linus.luessing@c0d3.blue> --- arch/arm/boot/dts/meson8b.dtsi | 2 -- 1 file changed, 2 deletions(-)