From patchwork Mon Jan 22 17:46:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Kamil_Trzci=C5=84ski?= X-Patchwork-Id: 864326 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N4bz9CCk"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ayufan-eu.20150623.gappssmtp.com header.i=@ayufan-eu.20150623.gappssmtp.com header.b="wrXU6zPJ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zQJlg1zCpz9t5Q for ; Tue, 23 Jan 2018 04:46:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dphQa/U6YoJqtcWz+BYns8OaCygtgx4vvIKILBtZCww=; b=N4bz9CCkI7yjwy 0mxjMI8VudH5tXuzKOd3r1SNU2YrhuPf7bAntBzmL2wYmGY/9pnudIP6fwGoI5vwl7K4FO9Ggy9Zb pDiaxaak8RGq/JWx6/V27G5uJV5rdR8IQdfoH+OoqvZh+12o8qpL9wODtL7gMYNFTjjxM84WO7tLD kB3B2sywtFZQjcmzHhpFILzZ+kl480bZCcEBf1ewOdXWLTjOvNUmuBfWD7dLA2JKzWng5QYalpc1C Yh0FxEm5JnSJqrTwoN8Lt66EKpsqbuB6IrwdvG74ePe6fnpBqgXeC0wxDdJJU/vtFDBtY+4MYUBHm 7px0U2cZRtoMAJmFpt1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1edgBI-0001qu-Cj; Mon, 22 Jan 2018 17:46:52 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1edgBE-0001pa-8h for linux-arm-kernel@lists.infradead.org; Mon, 22 Jan 2018 17:46:50 +0000 Received: by mail-wm0-x243.google.com with SMTP id v123so18492578wmd.5 for ; Mon, 22 Jan 2018 09:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ayufan-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xClyDNai+rFTl8fCZbaY0FPNW/Rpw46sHAInTtHqTfc=; b=wrXU6zPJQVAcTbB0ZoMkkphaDHkp9FPu6mZj2lswkEeLfwTWbPRFBaiyp1uLBHDCKI mFpxfDlGg0bFRmYMVa6z5OfZhHXW1ixNCmPoXPVaOOXVbrQRW5RUVmva9IX56xDNWH1k qLEhwgJ7uGdvzueLX5IdaF1qConBRqu4AdF5cVXfkW+w2afz1Ltj9v4zRNG0JPhIciVd 1YyCa0aONgddnS/A0dV3doMpQZ40JA10+lhgnmalPjrNX0lfSGiYnRg0XrniYFa8Agsu 3ZNZ71ewCgG0JhiwqpVQZwRYTC8lMTs0kE9ImsTpxVUW21slpkxsT/l/3QAoqL0pEYWF 9cVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xClyDNai+rFTl8fCZbaY0FPNW/Rpw46sHAInTtHqTfc=; b=ZImhm3C16/iuyPE2JMdby+zzUYWvYF08G/ov++eMI7Lt8y1BUeLxHmFbMNOhVXSqoJ s+ZbPMVdnAGmgCxNSsWrS6R9jUH193kauHx5LhpHq6drb8gN1inQLJ5/9VW9gYTJq2GW SOG16YQ45mXDsEoG+ODuW2D3jbSiUG6pNx75R96JHSwfYWPtPVsn4XCOngDCqfVxdW4+ blrLySjO9czvjteBBgZvm/gysIv00wB9wG1LkZjuj3OWy/xYcBW0k+eOH+0KImB68MPE PTnKg3Esh6yzN1fNCRLv8gLtOv/1Herp5+lmre3NpZJXJJqt35NkS513QIw30KgdPpbj 2xKg== X-Gm-Message-State: AKwxytcfUSWxedgaGzRvNvVhvzU5FA4gETt1K9zzwwpUGhuVQH1OM98F 3MEZYDA2YjQ7vijHptk9dyBYnA== X-Google-Smtp-Source: AH8x227etWhcfNXpDjCrL/dLV4hzCrxlRfmVRjquPg6ego7G7jaWR6t8YzGUqRdISFIeQb48JUfGCA== X-Received: by 10.80.220.70 with SMTP id y6mr14521995edk.236.1516643195844; Mon, 22 Jan 2018 09:46:35 -0800 (PST) Received: from ubuntu.home (89-76-148-210.dynamic.chello.pl. [89.76.148.210]) by smtp.gmail.com with ESMTPSA id w28sm11541541edl.43.2018.01.22.09.46.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 09:46:35 -0800 (PST) From: =?utf-8?q?Kamil_Trzci=C5=84ski?= To: Subject: [PATCH] rock64: dts: fix gmac2io stability issues Date: Mon, 22 Jan 2018 18:46:22 +0100 Message-Id: <20180122174628.15613-1-ayufan@ayufan.eu> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c09:0:0:0:243 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, David Wu , =?utf-8?q?Kamil_Trzci=C5=84ski?= , "David S. Miller" , Liang Chen , Joseph Chen Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org This commit enables thresh dma mode as this forces to disable checksuming, and chooses delay values which make the interface stable. These changes are needed, because ROCK64 is faced with two problems: 1. tx checksuming does not work with packets larger than 1498, 2. the default delays for tx/rx are not stable when using 1Gbps connection. Delays were found out with: https://github.com/ayufan-rock64/linux-build/tree/master/recipes/gmac-delays-test Change-Id: Ie894df4b52122988da683c02e3a05d635a5c7b84 Signed-off-by: Kamil Trzciński --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts index 5602ec01fed9..bcc0bb35d840 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts @@ -132,8 +132,6 @@ assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>; assigned-clock-parents = <&gmac_clkin>, <&gmac_clkin>; clock_in_out = "input"; - /* shows instability at 1GBit right now */ - max-speed = <100>; phy-supply = <&vcc_io>; phy-mode = "rgmii"; pinctrl-names = "default"; @@ -141,8 +139,9 @@ snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; - tx_delay = <0x26>; - rx_delay = <0x11>; + snps,force_thresh_dma_mode; + tx_delay = <0x24>; + rx_delay = <0x18>; status = "okay"; };