| Message ID | 20170215165528.10052-5-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
On Wednesday, February 15, 2017 5:55:21 PM CET Andreas Färber wrote: > > +config ARCH_OWL > + bool "Actions Semi S900 SoC Family" > + help > + This enables support for the Actions Semiconductor S900 SoC family. > + > There seem to be a couple of other SoCs in the same family, so maybe use a more generic name than S900 in the one-line Kconfig description. Arnd
Am 16.02.2017 um 14:43 schrieb Arnd Bergmann: > On Wednesday, February 15, 2017 5:55:21 PM CET Andreas Färber wrote: >> >> +config ARCH_OWL >> + bool "Actions Semi S900 SoC Family" >> + help >> + This enables support for the Actions Semiconductor S900 SoC family. >> + >> > > There seem to be a couple of other SoCs in the same family, so > maybe use a more generic name than S900 in the one-line > Kconfig description. Good point. I only tested with `make oldconfig`, so using "Owl" should tidy the sort order in `make menuconfig` while at it. (I believe there were more inconsistent examples, such as Armada 3700 vs. MVEBU...) Note that I have not come across any explanation for "OWL" as an acronym, so I'm guessing it's the bird and therefore capitalizing it. Apart from S900, actions-semi.com shows V series S900VR and S700 as well as GT series GT7 Cortex-A53 based SoCs. My guess[*] is these could all be handled as ARCH_OWL, adding further differentiation below if necessary; but Bubblegum-96 seemed the only available arm64 board for testing so far, so any comments from Actions will be appreciated. [*] The S500 vendor device tree was actually using ATM series models for various nodes, so I'm inferring that the product series are closely enough related. However, if you would prefer ARCH_ACTIONS I wouldn't mind either - we just need to keep it consistent across arm and arm64. Regards, Andreas
On Fri, Feb 17, 2017 at 1:34 AM, Andreas Färber <afaerber@suse.de> wrote: > Am 16.02.2017 um 14:43 schrieb Arnd Bergmann: >> On Wednesday, February 15, 2017 5:55:21 PM CET Andreas Färber wrote: >>> >>> +config ARCH_OWL >>> + bool "Actions Semi S900 SoC Family" >>> + help >>> + This enables support for the Actions Semiconductor S900 SoC family. >>> + >>> >> >> There seem to be a couple of other SoCs in the same family, so >> maybe use a more generic name than S900 in the one-line >> Kconfig description. > > Good point. I only tested with `make oldconfig`, so using "Owl" should > tidy the sort order in `make menuconfig` while at it. (I believe there > were more inconsistent examples, such as Armada 3700 vs. MVEBU...) > > Note that I have not come across any explanation for "OWL" as an > acronym, so I'm guessing it's the bird and therefore capitalizing it. > > Apart from S900, actions-semi.com shows V series S900VR and S700 as well > as GT series GT7 Cortex-A53 based SoCs. My guess[*] is these could all > be handled as ARCH_OWL, adding further differentiation below if > necessary; but Bubblegum-96 seemed the only available arm64 board for > testing so far, so any comments from Actions will be appreciated. > > [*] The S500 vendor device tree was actually using ATM series models for > various nodes, so I'm inferring that the product series are closely > enough related. > > However, if you would prefer ARCH_ACTIONS I wouldn't mind either - we > just need to keep it consistent across arm and arm64. ARCH_ACTIONS seems best to me. We tend to go for the broader names per company these days even when things are not closely related. This avoids having to rename things when a new line of products comes up that shares a subset of the components but doesn't fit under the old name. Arnd
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 129cc5a..5ecb925 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -1,5 +1,10 @@ menu "Platform selection" +config ARCH_OWL + bool "Actions Semi S900 SoC Family" + help + This enables support for the Actions Semiconductor S900 SoC family. + config ARCH_SUNXI bool "Allwinner sunxi 64-bit SoC Family" select GENERIC_IRQ_CHIP
Add ARCH_OWL. Signed-off-by: Andreas Färber <afaerber@suse.de> --- arch/arm64/Kconfig.platforms | 5 +++++ 1 file changed, 5 insertions(+)