| Message ID | 20161206171714.22738-4-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Dec 06, 2016 at 06:17:13PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > So far we were specifying only the first block which is always limited > up to 128 MiB. There are many devices with 256 MiB and few with 512 MiB. Assuming that NS is like NSP (and I'm pretty sure it is), there are 2 ways to access the first 128M of RAM, a proxy starting at address 0 and the real address. I think you are splitting RAM by accessing it both ways, when you really should just be accessing it at the real address. Thanks, Jon > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts | 3 ++- > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts | 3 ++- > arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 3 ++- > arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 3 ++- > arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 3 ++- > arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts | 3 ++- > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 3 ++- > arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts | 3 ++- > arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 3 ++- > arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 3 ++- > arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 3 ++- > arch/arm/boot/dts/bcm47094-netgear-r8500.dts | 3 ++- > 15 files changed, 30 insertions(+), 15 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > index 112a5a8..d241cee 100644 > --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > index 3600f56..b0e6204 100644 > --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > index d49afec0..c9ba6b9 100644 > --- a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > +++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > spi { > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > index 8519548..b9f66c0 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > index 6229ef2..ae0199f 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > index 74cfcd3..36b628b1 100644 > --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > index 71b98cf..db8608b 100644 > --- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > +++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > index 2922536..d51586d 100644 > --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > spi { > diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > index 184fd92..de041b8 100644 > --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > gpio-keys { > diff --git a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > index eac0f52..eaca687 100644 > --- a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > +++ b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > index aab39c9..b32957c 100644 > --- a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > +++ b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > index 7ab1176..f459a98 100644 > --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > index 56d38a3..cd13534 100644 > --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > index 7fb9270..64ded76 100644 > --- a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > +++ b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > nand: nand@18028000 { > diff --git a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > index 7ecd57c..600795e 100644 > --- a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > +++ b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > @@ -18,7 +18,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > leds { > -- > 2.10.1 >
On 6 December 2016 at 21:06, Jon Mason <jon.mason@broadcom.com> wrote: > On Tue, Dec 06, 2016 at 06:17:13PM +0100, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> So far we were specifying only the first block which is always limited >> up to 128 MiB. There are many devices with 256 MiB and few with 512 MiB. > > Assuming that NS is like NSP (and I'm pretty sure it is), there are 2 > ways to access the first 128M of RAM, a proxy starting at address 0 > and the real address. I think you are splitting RAM by accessing it > both ways, when you really should just be accessing it at the real > address. I need some more help, please. This patch (quite well tested) confirms that 0x88000000 can be used to access RAM at offset 128 MiB. If this is a real address and whole space is contiguous, it means the base real address should be 0x80000000. So using 0x0 and 0x80000000 should allow accessing beginning of the RAM. I took a device that was working just fine with: reg = <0x00000000 0x08000000>; and I replaced it with: reg = <0x80000000 0x08000000>; but it broke things, kernel didn't boot with the last message being: [ 0.000000] Memory policy: Data cache writealloc I can see that bcm958525er.dts, bcm958525xmc.dts, bcm958623hr.dts, bcm958625k.dts bcm988312hr.dts are using 0x60000000 as base address. It seems to be different from Northstar but I tried following entry anyway: reg = <0x60000000 0x08000000>; and I got kernel hang just like in the previous try. Did I miss something? Or does Northstar seem to be actually different than NSP?
On Tue, Dec 06, 2016 at 09:57:31PM +0100, Rafał Miłecki wrote: > On 6 December 2016 at 21:06, Jon Mason <jon.mason@broadcom.com> wrote: > > On Tue, Dec 06, 2016 at 06:17:13PM +0100, Rafał Miłecki wrote: > >> From: Rafał Miłecki <rafal@milecki.pl> > >> > >> So far we were specifying only the first block which is always limited > >> up to 128 MiB. There are many devices with 256 MiB and few with 512 MiB. > > > > Assuming that NS is like NSP (and I'm pretty sure it is), there are 2 > > ways to access the first 128M of RAM, a proxy starting at address 0 > > and the real address. I think you are splitting RAM by accessing it > > both ways, when you really should just be accessing it at the real > > address. > > I need some more help, please. > > This patch (quite well tested) confirms that 0x88000000 can be used to > access RAM at offset 128 MiB. If this is a real address and whole > space is contiguous, it means the base real address should be > 0x80000000. So using 0x0 and 0x80000000 should allow accessing > beginning of the RAM. I took a device that was working just fine with: > reg = <0x00000000 0x08000000>; > and I replaced it with: > reg = <0x80000000 0x08000000>; > but it broke things, kernel didn't boot with the last message being: > [ 0.000000] Memory policy: Data cache writealloc > > I can see that bcm958525er.dts, bcm958525xmc.dts, bcm958623hr.dts, > bcm958625k.dts bcm988312hr.dts are using 0x60000000 as base address. > It seems to be different from Northstar but I tried following entry > anyway: > reg = <0x60000000 0x08000000>; > and I got kernel hang just like in the previous try. > > Did I miss something? Or does Northstar seem to be actually different than NSP? Per the BCM5301X Preliminary Programmer's Register Reference guide (page 394), under the second titled "System Address Mapping". There is a table listing the System Address Mapping. The parts that are of interest in this converstation are (and forgive my approxmiation, but I cannot cut'n'paste from it): Address Range Size Description --------------------------------------------------- 0x0000_0000-0x07FF_FFFF 128 MB DDR2/3 SDRAM Memory Region* 0x8000_0000-0xBFFF_FFFF 1 G DDR2/3 SDRAM Large Region * The DDR2/3 SDRAM Memory Region (128MB) is a subset of the DDR2/3 SDRAM Large Region (1GB). Additionally, 0x0000_0000-0x07FF_FFFF is aliased to 0x8000_0000-0x87FF_FFFF However, since you say it isn't working for you, then there must be some other missing peice. I'll retract my comment for now, and hopefully we can double back and get it working in the future. Thanks, Jon
diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts index 112a5a8..d241cee 100644 --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts index 3600f56..b0e6204 100644 --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts index d49afec0..c9ba6b9 100644 --- a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts +++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x18000000>; }; spi { diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts index 8519548..b9f66c0 100644 --- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts +++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts index 6229ef2..ae0199f 100644 --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts index 74cfcd3..36b628b1 100644 --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts index 71b98cf..db8608b 100644 --- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts +++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts index 2922536..d51586d 100644 --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; spi { diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts index 184fd92..de041b8 100644 --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; gpio-keys { diff --git a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts index eac0f52..eaca687 100644 --- a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts +++ b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts index aab39c9..b32957c 100644 --- a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts +++ b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x18000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts index 7ab1176..f459a98 100644 --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts index 56d38a3..cd13534 100644 --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; leds { diff --git a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts index 7fb9270..64ded76 100644 --- a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts +++ b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts @@ -21,7 +21,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x08000000>; }; nand: nand@18028000 { diff --git a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts index 7ecd57c..600795e 100644 --- a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts +++ b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts @@ -18,7 +18,8 @@ }; memory { - reg = <0x00000000 0x08000000>; + reg = <0x00000000 0x08000000 + 0x88000000 0x18000000>; }; leds {