From patchwork Mon Jan 25 12:17:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "liviu.dudau@arm.com" X-Patchwork-Id: 572717 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0E6251402A9 for ; Mon, 25 Jan 2016 23:19:19 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aNg5d-0001EV-Lu; Mon, 25 Jan 2016 12:17:49 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aNg5X-0000wV-Hn for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2016 12:17:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 85BB94BF; Mon, 25 Jan 2016 04:16:41 -0800 (PST) Received: from e106497-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6C903F246; Mon, 25 Jan 2016 04:17:21 -0800 (PST) Received: by e106497-lin.cambridge.arm.com (Postfix, from userid 1005) id 3C1F5107DD7B; Mon, 25 Jan 2016 12:17:20 +0000 (GMT) Date: Mon, 25 Jan 2016 12:17:20 +0000 From: liviu.dudau@arm.com To: Amitoj Kaur Chawla Subject: Re: [PATCH] bus: vexpress-config: Add missing of_node_put Message-ID: <20160125121720.GC1194@e106497-lin.cambridge.arm.com> References: <20160122180838.GA12069@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160122180838.GA12069@amitoj-Inspiron-3542> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160125_041743_792348_A7B4361B X-CRM114-Status: GOOD ( 16.83 ) X-Spam-Score: -6.9 (------) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-6.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [217.140.101.70 listed in list.dnswl.org] -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julia.lawall@lip6.fr, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Fri, Jan 22, 2016 at 11:38:38PM +0530, Amitoj Kaur Chawla wrote: > for_each_compatible_node performs an of_node_get on each iteration, so > to break out of the loop an of_node_put is required. > > Found using Coccinelle. The semantic patch used for this is as follows: > > // > @@ > expression e; > local idexpression n; > @@ > > for_each_compatible_node(n, ...) { > ... when != of_node_put(n) > when != e = n > ( > return n; > + of_node_put(n); > ? return ...; > ) > ... > } > // > > Signed-off-by: Amitoj Kaur Chawla Hi Amitoj, > --- > drivers/bus/vexpress-config.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c > index 6575c0f..c3cb76b 100644 > --- a/drivers/bus/vexpress-config.c > +++ b/drivers/bus/vexpress-config.c > @@ -192,8 +192,10 @@ static int __init vexpress_config_init(void) > /* Need the config devices early, before the "normal" devices... */ > for_each_compatible_node(node, NULL, "arm,vexpress,config-bus") { > err = vexpress_config_populate(node); > - if (err) > + if (err) { > + of_node_put(node); > break; > + } This automatically generated patch only solves half of the problem (for the error path). > } > > return err; > -- > 1.9.1 > I feel that a better patch would be the following, where the node is released regardless of the result of vexpress_config_populate(). --8<-------------------------------------------------------------------------- -->8-------------------------------------------------------------------------- Best regards, Liviu Acked-by: Liviu Dudau diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index 6575c0f..c57453d 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -192,6 +192,7 @@ static int __init vexpress_config_init(void) /* Need the config devices early, before the "normal" devices... */ for_each_compatible_node(node, NULL, "arm,vexpress,config-bus") { err = vexpress_config_populate(node); + of_node_put(node); if (err) break; }