| Message ID | 20151007102822.GT23801@atomide.com |
|---|---|
| State | New |
| Headers | show |
Hello Tony, On Wed, Oct 07, 2015 at 03:41:19AM -0700, Tony Lindgren wrote: > * Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [151007 00:57]: > > On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: > > > > > > How about this instead? > > > > > > NOTE: Apart from matching the register setup with the bootloader you also need to > > > match the GPMC FCLK frequency used by the bootloader else the GPMC timings > > > won't be identical with the bootloader timings. > > Yeah, sounds better, thanks. > > > > > Also you might need to build this patch on top of > > > http://article.gmane.org/gmane.linux.kernel/2054796 > > I talked to Tony about this patch yesterday on irc, but I didn't find it > > in the archives yet when I sent my mail. > > Yes sorry here's a repost with your and Roger's changes folded in and > edited a bit. Probably best to keep them together with this patch. > > Does the following look OK to you guys? Yes, Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On 07/10/15 14:02, Uwe Kleine-König wrote: > Hello Tony, > > On Wed, Oct 07, 2015 at 03:41:19AM -0700, Tony Lindgren wrote: >> * Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [151007 00:57]: >>> On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: >>>> >>>> How about this instead? >>>> >>>> NOTE: Apart from matching the register setup with the bootloader you also need to >>>> match the GPMC FCLK frequency used by the bootloader else the GPMC timings >>>> won't be identical with the bootloader timings. >>> Yeah, sounds better, thanks. >>> >>>> Also you might need to build this patch on top of >>>> http://article.gmane.org/gmane.linux.kernel/2054796 >>> I talked to Tony about this patch yesterday on irc, but I didn't find it >>> in the archives yet when I sent my mail. >> >> Yes sorry here's a repost with your and Roger's changes folded in and >> edited a bit. Probably best to keep them together with this patch. >> >> Does the following look OK to you guys? > Yes, > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Looks good to me too. cheers, -roger
* Roger Quadros <rogerq@ti.com> [151007 04:12]: > On 07/10/15 14:02, Uwe Kleine-König wrote: > > Hello Tony, > > > > On Wed, Oct 07, 2015 at 03:41:19AM -0700, Tony Lindgren wrote: > >> * Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [151007 00:57]: > >>> On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: > >>>> > >>>> How about this instead? > >>>> > >>>> NOTE: Apart from matching the register setup with the bootloader you also need to > >>>> match the GPMC FCLK frequency used by the bootloader else the GPMC timings > >>>> won't be identical with the bootloader timings. > >>> Yeah, sounds better, thanks. > >>> > >>>> Also you might need to build this patch on top of > >>>> http://article.gmane.org/gmane.linux.kernel/2054796 > >>> I talked to Tony about this patch yesterday on irc, but I didn't find it > >>> in the archives yet when I sent my mail. > >> > >> Yes sorry here's a repost with your and Roger's changes folded in and > >> edited a bit. Probably best to keep them together with this patch. > >> > >> Does the following look OK to you guys? > > Yes, > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Looks good to me too. Are you OK if I use your Acked-by from the previous version on this updated version? Regards, Tony
On 07/10/15 16:40, Tony Lindgren wrote: > * Roger Quadros <rogerq@ti.com> [151007 04:12]: >> On 07/10/15 14:02, Uwe Kleine-König wrote: >>> Hello Tony, >>> >>> On Wed, Oct 07, 2015 at 03:41:19AM -0700, Tony Lindgren wrote: >>>> * Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [151007 00:57]: >>>>> On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: >>>>>> >>>>>> How about this instead? >>>>>> >>>>>> NOTE: Apart from matching the register setup with the bootloader you also need to >>>>>> match the GPMC FCLK frequency used by the bootloader else the GPMC timings >>>>>> won't be identical with the bootloader timings. >>>>> Yeah, sounds better, thanks. >>>>> >>>>>> Also you might need to build this patch on top of >>>>>> http://article.gmane.org/gmane.linux.kernel/2054796 >>>>> I talked to Tony about this patch yesterday on irc, but I didn't find it >>>>> in the archives yet when I sent my mail. >>>> >>>> Yes sorry here's a repost with your and Roger's changes folded in and >>>> edited a bit. Probably best to keep them together with this patch. >>>> >>>> Does the following look OK to you guys? >>> Yes, >>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> >> Looks good to me too. > > Are you OK if I use your Acked-by from the previous version on > this updated version? Yes please. cheers, -roger
--- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -58,12 +58,18 @@ config OMAP_GPMC memory drives like NOR, NAND, OneNAND, SRAM. config OMAP_GPMC_DEBUG - bool + bool "Enable GPMC debug output and skip reset of GPMC during init" depends on OMAP_GPMC help Enables verbose debugging mostly to decode the bootloader provided - timings. Enable this during development to configure devices - connected to the GPMC bus. + timings. To preserve the bootloader provided timings, the reset + of GPMC is skipped during init. Enable this during development to + configure devices connected to the GPMC bus. + + NOTE: In addition to matching the register setup with the bootloader + you also need to match the GPMC FCLK frequency used by the + bootloader or else the GPMC timings won't be identical with the + bootloader timings. config MVEBU_DEVBUS bool "Marvell EBU Device Bus Controller"