| Message ID | 20150106015220.27249.74970.stgit@dusk.lan |
|---|---|
| State | New |
| Headers | show |
Hi Paul, On Tue, Jan 06, 2015 at 01:52:26AM +0000, Paul Walmsley wrote: > On next-20150105, defconfig compilation breaks with: > > arch/arm64/kernel/smp_spin_table.c:80:2: error: implicit declaration of function ‘ioremap_cache’ [-Werror=implicit-function-declaration] > arch/arm64/kernel/smp_spin_table.c:92:2: error: implicit declaration of function ‘writeq_relaxed’ [-Werror=implicit-function-declaration] > arch/arm64/kernel/smp_spin_table.c:101:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] > > Fix by including asm/io.h, which contains definitions or prototypes > for these macros or functions. > > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Paul Walmsley <pwalmsley@nvidia.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > arch/arm64/kernel/smp_spin_table.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/smp_spin_table.c b/arch/arm64/kernel/smp_spin_table.c > index 4f93c67e63de..4d9f10b9d869 100644 > --- a/arch/arm64/kernel/smp_spin_table.c > +++ b/arch/arm64/kernel/smp_spin_table.c > @@ -26,6 +26,7 @@ > #include <asm/cpu_ops.h> > #include <asm/cputype.h> > #include <asm/smp_plat.h> > +#include <asm/io.h> Nit: please move between the include of asm/cputype and asm/smp_plat.h, so as to keep the list in alphabetical order. Otherwise: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark. > > extern void secondary_holding_pen(void); > volatile unsigned long secondary_holding_pen_release = INVALID_HWID; > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/kernel/smp_spin_table.c b/arch/arm64/kernel/smp_spin_table.c index 4f93c67e63de..4d9f10b9d869 100644 --- a/arch/arm64/kernel/smp_spin_table.c +++ b/arch/arm64/kernel/smp_spin_table.c @@ -26,6 +26,7 @@ #include <asm/cpu_ops.h> #include <asm/cputype.h> #include <asm/smp_plat.h> +#include <asm/io.h> extern void secondary_holding_pen(void); volatile unsigned long secondary_holding_pen_release = INVALID_HWID;
On next-20150105, defconfig compilation breaks with: arch/arm64/kernel/smp_spin_table.c:80:2: error: implicit declaration of function ‘ioremap_cache’ [-Werror=implicit-function-declaration] arch/arm64/kernel/smp_spin_table.c:92:2: error: implicit declaration of function ‘writeq_relaxed’ [-Werror=implicit-function-declaration] arch/arm64/kernel/smp_spin_table.c:101:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] Fix by including asm/io.h, which contains definitions or prototypes for these macros or functions. Signed-off-by: Paul Walmsley <paul@pwsan.com> Cc: Paul Walmsley <pwalmsley@nvidia.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> --- arch/arm64/kernel/smp_spin_table.c | 1 + 1 file changed, 1 insertion(+)