mbox

[GIT,PULL] Allwinner drivers additions for 3.18

Message ID 20140920202855.GA20329@lukather
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-drivers-for-3.18

Message

Maxime Ripard Sept. 20, 2014, 8:28 p.m. UTC
Hi,

Please pull the following changes for the next merge window.

Thanks!
Maxime


The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:

  Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-drivers-for-3.18

for you to fetch changes up to 64a1925c00706253aa887431fc45f96db48aa727:

  rtc: sunxi: Depend on platforms sun4i/sun7i that actually have the rtc (2014-09-19 12:39:30 +0200)

----------------------------------------------------------------
Allwinner drivers additions for 3.18

Nothing major, just handling the RTC driver changes needed for the A31/A23.

----------------------------------------------------------------
Chen-Yu Tsai (2):
      rtc: sun6i: Add sun6i RTC driver
      rtc: sunxi: Depend on platforms sun4i/sun7i that actually have the rtc

 .../devicetree/bindings/rtc/sun6i-rtc.txt          |  17 +
 drivers/rtc/Kconfig                                |   9 +-
 drivers/rtc/Makefile                               |   1 +
 drivers/rtc/rtc-sun6i.c                            | 447 +++++++++++++++++++++
 4 files changed, 473 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/sun6i-rtc.txt
 create mode 100644 drivers/rtc/rtc-sun6i.c

Comments

Arnd Bergmann Sept. 25, 2014, 4:20 p.m. UTC | #1
On Saturday 20 September 2014, Maxime Ripard wrote:
> Hi,
> 
> Please pull the following changes for the next merge window.
> 

Pulled into next/drivers. The patches look good, but please note that the RTC
subsystem does have a maintainer and mailing list. You should really keep
them in the loop for the reviews *and* the submission.

	Arnd

> The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:
> 
>   Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-drivers-for-3.18
> 
> for you to fetch changes up to 64a1925c00706253aa887431fc45f96db48aa727:
> 
>   rtc: sunxi: Depend on platforms sun4i/sun7i that actually have the rtc (2014-09-19 12:39:30 +0200)
> 
> ----------------------------------------------------------------
> Allwinner drivers additions for 3.18
> 
> Nothing major, just handling the RTC driver changes needed for the A31/A23.
> 
> ----------------------------------------------------------------
> Chen-Yu Tsai (2):
>       rtc: sun6i: Add sun6i RTC driver
>       rtc: sunxi: Depend on platforms sun4i/sun7i that actually have the rtc
> 
>  .../devicetree/bindings/rtc/sun6i-rtc.txt          |  17 +
>  drivers/rtc/Kconfig                                |   9 +-
>  drivers/rtc/Makefile                               |   1 +
>  drivers/rtc/rtc-sun6i.c                            | 447 +++++++++++++++++++++
>  4 files changed, 473 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/sun6i-rtc.txt
>  create mode 100644 drivers/rtc/rtc-sun6i.c
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
Maxime Ripard Sept. 25, 2014, 4:31 p.m. UTC | #2
Hi,

On Thu, Sep 25, 2014 at 06:20:37PM +0200, Arnd Bergmann wrote:
> On Saturday 20 September 2014, Maxime Ripard wrote:
> > Hi,
> > 
> > Please pull the following changes for the next merge window.
> > 
> 
> Pulled into next/drivers. The patches look good, but please note that the RTC
> subsystem does have a maintainer and mailing list. You should really keep
> them in the loop for the reviews *and* the submission.

They were. And have been ping'd multiple time, without any answer.

Plus, this thread from last december
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/220778.html,
clearly showed that it's nothing new, and that Alessandro doesn't
maintain any tree, hence why I ended up merging it.

Maxime
Arnd Bergmann Sept. 25, 2014, 5:04 p.m. UTC | #3
On Thursday 25 September 2014 18:31:03 Maxime Ripard wrote:
> On Thu, Sep 25, 2014 at 06:20:37PM +0200, Arnd Bergmann wrote:
> > On Saturday 20 September 2014, Maxime Ripard wrote:
> > > Hi,
> > > 
> > > Please pull the following changes for the next merge window.
> > > 
> > 
> > Pulled into next/drivers. The patches look good, but please note that the RTC
> > subsystem does have a maintainer and mailing list. You should really keep
> > them in the loop for the reviews *and* the submission.
> 
> They were. And have been ping'd multiple time, without any answer.

Ok.

> Plus, this thread from last december
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/220778.html,
> clearly showed that it's nothing new, and that Alessandro doesn't
> maintain any tree, hence why I ended up merging it.

Yes, and that's why I merged it, too. Still you should have him on Cc
for the actual pull request.

	Arnd
Alessandro Zummo Sept. 25, 2014, 5:18 p.m. UTC | #4
On Thu, 25 Sep 2014 18:31:03 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Plus, this thread from last december
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/220778.html,
> clearly showed that it's nothing new, and that Alessandro doesn't
> maintain any tree, hence why I ended up merging it.

 I review the drivers, when appropriate, and Andrew thankfully picks them up.
 Important emails will usually get my attention. Even if I do not answer,
 is always a good idea to post in the mailing list, as there are a lot
 of competent people there.
Maxime Ripard Sept. 26, 2014, 3:04 p.m. UTC | #5
On Thu, Sep 25, 2014 at 07:04:51PM +0200, Arnd Bergmann wrote:
> > Plus, this thread from last december
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/220778.html,
> > clearly showed that it's nothing new, and that Alessandro doesn't
> > maintain any tree, hence why I ended up merging it.
> 
> Yes, and that's why I merged it, too. Still you should have him on Cc
> for the actual pull request.

Yep, my bad :(

Maxime
Maxime Ripard Sept. 26, 2014, 3:16 p.m. UTC | #6
On Thu, Sep 25, 2014 at 07:18:00PM +0200, Alessandro Zummo wrote:
> On Thu, 25 Sep 2014 18:31:03 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> 
> > Plus, this thread from last december
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/220778.html,
> > clearly showed that it's nothing new, and that Alessandro doesn't
> > maintain any tree, hence why I ended up merging it.
> 
>  I review the drivers, when appropriate, and Andrew thankfully picks them up.
>  Important emails will usually get my attention. Even if I do not answer,
>  is always a good idea to post in the mailing list, as there are a lot
>  of competent people there.

Then may I suggest adding Andrew to the maintainers? Because if you
follow get_maintainers.pl right now, it only states that you are the
maintainer. That strongly implies that you should be the one doing
reviews, and we should at least wait for your Acked-by in order to
merge any RTC patches. And past experience show that we can wait for a
while.

Don't get this wrong, but the way you maintain it is rather unusual,
and your silence about this just makes us wonder what to do with your
patches, up until completely merging them anyway. For the record, it's
something I feel rather uncomfortable about, but it seems like it's
the only way to get something merged anyway.

Not having time to maintain your subsystem is totally fine, and as a
hobbyist maintainer too, I completely understand it. But if you can't
cope with the patches anymore, maybe you should find another
co-maintainer? Especially if you have reliable contributors, like
you're suggesting.

Maxime
Alessandro Zummo Sept. 26, 2014, 3:24 p.m. UTC | #7
On Fri, 26 Sep 2014 17:16:25 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Then may I suggest adding Andrew to the maintainers? Because if you
> follow get_maintainers.pl right now, it only states that you are the

 That would be appropriate, but the decision to add himself
 is up to Andrew.