Message ID | 20130503111537.GH24153@gmail.com |
---|---|
State | New |
Headers | show |
On Fri, May 3, 2013 at 1:15 PM, Lee Jones <lee.jones@linaro.org> wrote: > drivers/mfd/ab8500-gpadc.c: In function ‘ab8500_gpadc_resume’: > drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of > ‘regulator_enable’, declared with attribute warn_unused_result > [-Wunused-result] > > Cc: Samuel Ortiz <sameo@linux.intel.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, 03 May 2013, Linus Walleij wrote: > On Fri, May 3, 2013 at 1:15 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > drivers/mfd/ab8500-gpadc.c: In function ‘ab8500_gpadc_resume’: > > drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of > > ‘regulator_enable’, declared with attribute warn_unused_result > > [-Wunused-result] > > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij Nice, thanks. I'm applying this now.
diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c index 5e65b28..13f7866 100644 --- a/drivers/mfd/ab8500-gpadc.c +++ b/drivers/mfd/ab8500-gpadc.c @@ -907,14 +907,17 @@ static int ab8500_gpadc_suspend(struct device *dev) static int ab8500_gpadc_resume(struct device *dev) { struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); + int ret; - regulator_enable(gpadc->regu); + ret = regulator_enable(gpadc->regu); + if (ret) + dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret); pm_runtime_mark_last_busy(gpadc->dev); pm_runtime_put_autosuspend(gpadc->dev); mutex_unlock(&gpadc->ab8500_gpadc_lock); - return 0; + return ret; } static int ab8500_gpadc_probe(struct platform_device *pdev)
drivers/mfd/ab8500-gpadc.c: In function ‘ab8500_gpadc_resume’: drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result] Cc: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>