From patchwork Thu Jan 31 13:30:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 217189 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4F6482C008E for ; Fri, 1 Feb 2013 00:34:32 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U0uEZ-0001i3-Rx; Thu, 31 Jan 2013 13:31:19 +0000 Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14] helo=va3outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U0uEW-0001hh-B5 for linux-arm-kernel@lists.infradead.org; Thu, 31 Jan 2013 13:31:16 +0000 Received: from mail39-va3-R.bigfish.com (10.7.14.241) by VA3EHSOBE010.bigfish.com (10.7.40.12) with Microsoft SMTP Server id 14.1.225.23; Thu, 31 Jan 2013 13:31:08 +0000 Received: from mail39-va3 (localhost [127.0.0.1]) by mail39-va3-R.bigfish.com (Postfix) with ESMTP id 85B0A4201C2; Thu, 31 Jan 2013 13:31:08 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dI1432Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzzz2dh87h2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h1155h) X-FB-DOMAIN-IP-MATCH: fail Received: from mail39-va3 (localhost.localdomain [127.0.0.1]) by mail39-va3 (MessageSwitch) id 1359639065549903_7779; Thu, 31 Jan 2013 13:31:05 +0000 (UTC) Received: from VA3EHSMHS019.bigfish.com (unknown [10.7.14.237]) by mail39-va3.bigfish.com (Postfix) with ESMTP id 81CD7201BA; Thu, 31 Jan 2013 13:31:05 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS019.bigfish.com (10.7.99.29) with Microsoft SMTP Server (TLS) id 14.1.225.23; Thu, 31 Jan 2013 13:31:00 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.318.3; Thu, 31 Jan 2013 13:30:59 +0000 Received: from S2101-09.ap.freescale.net ([10.192.185.61]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id r0VDUuJn022946; Thu, 31 Jan 2013 06:30:57 -0700 Date: Thu, 31 Jan 2013 21:30:56 +0800 From: Shawn Guo To: Paolo Pisati Subject: Re: [REGRESSION+BISECT] imx6: 3.8+: sata failure with 24d340ac "ARM i.MX6: Fix ethernet PLL clocks" Message-ID: <20130131133054.GD2735@S2101-09.ap.freescale.net> References: <20130131113627.GA5452@luxor.wired.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130131113627.GA5452@luxor.wired.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130131_083116_458291_E8E756DB X-CRM114-Status: GOOD ( 11.49 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [216.32.180.14 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Sascha Hauer , linux-arm X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Thu, Jan 31, 2013 at 12:36:27PM +0100, Paolo Pisati wrote: > Hi, > > sata doesn't work anymore in 3.8rcX (while it was ok in 3.7 + 1 patch[1]) and i've bisected > it down to: > Technically, it's not a regression since vanilla 3.7 kernel does not have SATA work out of box. So we do not have to maintain the function when changing clock code. Can you please try to see if the following change bring that SATA back to work? Shawn Tested-by: diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index c0c4e72..8f756af 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-imx6q.c @@ -436,6 +436,9 @@ int __init mx6q_clocks_init(void) for (i = 0; i < ARRAY_SIZE(clks_init_on); i++) clk_prepare_enable(clk[clks_init_on[i]]); + if (IS_ENABLED(CONFIG_SATA_AHCI_PLATFORM)) + clk_prepare_enable(clk[sata_ref_100m]); + /* Set initial power mode */ imx6q_set_lpm(WAIT_CLOCKED);